Code Review
/
bgpcep.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
BUG-5685: Register BGP Peer Cluster Singleton Service
[bgpcep.git]
/
bgp
/
rib-impl
/
src
/
test
/
java
/
org
/
opendaylight
/
controller
/
config
/
yang
/
bgp
/
rib
/
impl
/
BGPPeerModuleTest.java
diff --git
a/bgp/rib-impl/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java
b/bgp/rib-impl/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java
index 78f265a5a1bf13c7f5feef2c00204d7027000af0..2b5f9b997fc794711855f0d7058022a2309b8628 100755
(executable)
--- a/
bgp/rib-impl/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java
+++ b/
bgp/rib-impl/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java
@@
-17,7
+17,6
@@
import java.util.Collections;
import java.util.List;
import javax.management.InstanceAlreadyExistsException;
import javax.management.ObjectName;
import java.util.List;
import javax.management.InstanceAlreadyExistsException;
import javax.management.ObjectName;
-import org.junit.Assert;
import org.junit.Test;
import org.opendaylight.controller.config.api.IdentityAttributeRef;
import org.opendaylight.controller.config.api.ValidationException;
import org.junit.Test;
import org.opendaylight.controller.config.api.IdentityAttributeRef;
import org.opendaylight.controller.config.api.ValidationException;
@@
-41,7
+40,7
@@
public class BGPPeerModuleTest extends AbstractRIBImplModuleTest {
private static final String FACTORY_NAME = BGPPeerModuleFactory.NAME;
private static final IpAddress HOST = new IpAddress(new Ipv4Address("127.0.0.1"));
private static final String FACTORY_NAME = BGPPeerModuleFactory.NAME;
private static final IpAddress HOST = new IpAddress(new Ipv4Address("127.0.0.1"));
- private static final PortNumber
portNumber
= new PortNumber(1);
+ private static final PortNumber
PORT_NUMBER
= new PortNumber(1);
@Override
protected BindingRuntimeContext getBindingRuntimeContext() {
@Override
protected BindingRuntimeContext getBindingRuntimeContext() {
@@
-84,7
+83,7
@@
public class BGPPeerModuleTest extends AbstractRIBImplModuleTest {
@Test
public void testValidationExceptionHostNotSet() throws Exception {
try {
@Test
public void testValidationExceptionHostNotSet() throws Exception {
try {
- createBgpPeerInstance(null,
portNumber
, false);
+ createBgpPeerInstance(null,
PORT_NUMBER
, false);
fail();
} catch (final ValidationException e) {
assertTrue(e.getMessage().contains("Host value is not set."));
fail();
} catch (final ValidationException e) {
assertTrue(e.getMessage().contains("Host value is not set."));
@@
-186,7
+185,7
@@
public class BGPPeerModuleTest extends AbstractRIBImplModuleTest {
}
private CommitStatus createBgpPeerInstance(final boolean md5) throws Exception {
}
private CommitStatus createBgpPeerInstance(final boolean md5) throws Exception {
- return createBgpPeerInstance(HOST,
portNumber
, md5);
+ return createBgpPeerInstance(HOST,
PORT_NUMBER
, md5);
}
private CommitStatus createBgpPeerInstance(final IpAddress host, final PortNumber port, final boolean md5) throws Exception {
}
private CommitStatus createBgpPeerInstance(final IpAddress host, final PortNumber port, final boolean md5) throws Exception {
@@
-198,7
+197,7
@@
public class BGPPeerModuleTest extends AbstractRIBImplModuleTest {
private CommitStatus createInternalBgpPeerInstance()
throws Exception {
final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
private CommitStatus createInternalBgpPeerInstance()
throws Exception {
final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- createBgpPeerInstance(transaction, HOST,
portNumber
, false, true);
+ createBgpPeerInstance(transaction, HOST,
PORT_NUMBER
, false, true);
return transaction.commit();
}
}
return transaction.commit();
}
}