Code Review
/
mdsal.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
SchemaUnawareCodec is AbstractIllegalArgumentCodec
[mdsal.git]
/
binding
/
mdsal-binding-dom-codec
/
src
/
main
/
java
/
org
/
opendaylight
/
mdsal
/
binding
/
dom
/
codec
/
impl
/
BitsCodec.java
diff --git
a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/BitsCodec.java
b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/BitsCodec.java
index 5da1c038fe7e4515ccc7a86aa27cec71c9d44b78..ea16c388ab1f05d234b9e6549962b5cb56552979 100644
(file)
--- a/
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/BitsCodec.java
+++ b/
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/BitsCodec.java
@@
-34,6
+34,8
@@
import org.opendaylight.yangtools.yang.model.api.type.BitsTypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.BitsTypeDefinition.Bit;
// FIXME: 'SchemaUnawareCodec' is not correct: we use BitsTypeDefinition in construction
import org.opendaylight.yangtools.yang.model.api.type.BitsTypeDefinition.Bit;
// FIXME: 'SchemaUnawareCodec' is not correct: we use BitsTypeDefinition in construction
+// FIXME: require the base class to be a TypeObject
+// FIXME: MDSAL-743: require BitsTypeObject base class
final class BitsCodec extends SchemaUnawareCodec {
/*
* Use identity comparison for keys and allow classes to be GCd themselves.
final class BitsCodec extends SchemaUnawareCodec {
/*
* Use identity comparison for keys and allow classes to be GCd themselves.
@@
-88,7
+90,7
@@
final class BitsCodec extends SchemaUnawareCodec {
@Override
@SuppressWarnings("checkstyle:illegalCatch")
@Override
@SuppressWarnings("checkstyle:illegalCatch")
- p
ublic Object deserialize
(final Object input) {
+ p
rotected Object deserializeImpl
(final Object input) {
checkArgument(input instanceof Set);
@SuppressWarnings("unchecked")
final Set<String> casted = (Set<String>) input;
checkArgument(input instanceof Set);
@SuppressWarnings("unchecked")
final Set<String> casted = (Set<String>) input;
@@
-113,7
+115,7
@@
final class BitsCodec extends SchemaUnawareCodec {
}
@Override
}
@Override
- p
ublic Set<String> serialize
(final Object input) {
+ p
rotected Set<String> serializeImpl
(final Object input) {
final Collection<String> result = new ArrayList<>(getters.size());
for (Entry<String, Method> valueGet : getters.entrySet()) {
final Boolean value;
final Collection<String> result = new ArrayList<>(getters.size());
for (Entry<String, Method> valueGet : getters.entrySet()) {
final Boolean value;