Code Review
/
mdsal.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Speed up AbstractBuilderTemplate.removeProperty()
[mdsal.git]
/
binding
/
mdsal-binding-java-api-generator
/
src
/
main
/
java
/
org
/
opendaylight
/
mdsal
/
binding
/
java
/
api
/
generator
/
AbstractBuilderTemplate.xtend
diff --git
a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend
b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend
index 0fa83fee998fa6aa602c35302dd3728a61cd0756..da98b8c7bf829ab7aaec277b7249545e34912044 100644
(file)
--- a/
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend
+++ b/
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend
@@
-173,15
+173,13
@@
abstract class AbstractBuilderTemplate extends BaseTemplate {
}
private def void removeProperty(Collection<GeneratedProperty> props, String name) {
}
private def void removeProperty(Collection<GeneratedProperty> props, String name) {
- var GeneratedProperty toRemove = null
- for (p : props) {
- if (p.name.equals(name)) {
- toRemove = p;
+ val iter = props.iterator
+ while (iter.hasNext) {
+ if (name.equals(iter.next.name)) {
+ iter.remove
+ return
}
}
}
}
- if (toRemove !== null) {
- props.remove(toRemove);
- }
}
private static def findDeprecatedAnnotation(List<AnnotationType> annotations) {
}
private static def findDeprecatedAnnotation(List<AnnotationType> annotations) {