Code Review
/
openflowplugin.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix checkstyle violations in openflowjava extensions
[openflowplugin.git]
/
extension
/
openflowjava-extension-nicira
/
src
/
test
/
java
/
org
/
opendaylight
/
openflowjava
/
nx
/
codec
/
match
/
ArpTpaCodecTest.java
diff --git
a/extension/openflowjava-extension-nicira/src/test/java/org/opendaylight/openflowjava/nx/codec/match/ArpTpaCodecTest.java
b/extension/openflowjava-extension-nicira/src/test/java/org/opendaylight/openflowjava/nx/codec/match/ArpTpaCodecTest.java
index 3cbb9dd41587ea832e8954530b055dd5cc51632c..dfbf04f6724b24633fd047d57a25091f3bb9a7db 100644
(file)
--- a/
extension/openflowjava-extension-nicira/src/test/java/org/opendaylight/openflowjava/nx/codec/match/ArpTpaCodecTest.java
+++ b/
extension/openflowjava-extension-nicira/src/test/java/org/opendaylight/openflowjava/nx/codec/match/ArpTpaCodecTest.java
@@
-56,7
+56,7
@@
public class ArpTpaCodecTest {
createBuffer(buffer);
input = arpTpaCodec.deserialize(buffer);
createBuffer(buffer);
input = arpTpaCodec.deserialize(buffer);
-
ArpTpaCaseValue result = ((ArpTpaCaseValue) input.getMatchEntryValue()
);
+
final ArpTpaCaseValue result = (ArpTpaCaseValue) input.getMatchEntryValue(
);
assertEquals(Nxm0Class.class, input.getOxmClass());
assertEquals(NxmOfArpTpa.class, input.getOxmMatchField());
assertEquals(Nxm0Class.class, input.getOxmClass());
assertEquals(NxmOfArpTpa.class, input.getOxmMatchField());
@@
-66,8
+66,8
@@
public class ArpTpaCodecTest {
private MatchEntry createMatchEntry() {
MatchEntryBuilder matchEntryBuilder = new MatchEntryBuilder();
private MatchEntry createMatchEntry() {
MatchEntryBuilder matchEntryBuilder = new MatchEntryBuilder();
- ArpTpaCaseValueBuilder caseBuilder = new ArpTpaCaseValueBuilder();
- ArpTpaValuesBuilder valuesBuilder = new ArpTpaValuesBuilder();
+
final
ArpTpaCaseValueBuilder caseBuilder = new ArpTpaCaseValueBuilder();
+
final
ArpTpaValuesBuilder valuesBuilder = new ArpTpaValuesBuilder();
matchEntryBuilder.setOxmClass(Nxm0Class.class);
matchEntryBuilder.setOxmMatchField(NxmOfArpTpa.class);
matchEntryBuilder.setOxmClass(Nxm0Class.class);
matchEntryBuilder.setOxmMatchField(NxmOfArpTpa.class);
@@
-83,10
+83,9
@@
public class ArpTpaCodecTest {
private void createBuffer(ByteBuf message) {
message.writeShort(OxmMatchConstants.NXM_0_CLASS);
private void createBuffer(ByteBuf message) {
message.writeShort(OxmMatchConstants.NXM_0_CLASS);
- int fieldMask =
(NXM_FIELD_CODE << 1)
;
+ int fieldMask =
NXM_FIELD_CODE << 1
;
message.writeByte(fieldMask);
message.writeByte(VALUE_LENGTH);
message.writeInt(2);
}
message.writeByte(fieldMask);
message.writeByte(VALUE_LENGTH);
message.writeInt(2);
}
-
-}
\ No newline at end of file
+}