Code Review
/
transportpce.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix some small issues pointed by Sonar
[transportpce.git]
/
inventory
/
src
/
main
/
java
/
org
/
opendaylight
/
transportpce
/
inventory
/
INode.java
diff --git
a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
index cdcfc621ef6d5e2bb71cc8796a702240ad15d7e7..c7299c835b230c05d60ca0d7e821627c3b159407 100644
(file)
--- a/
inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
+++ b/
inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
@@
-39,7
+39,7
@@
public class INode {
}
public boolean addNode(String deviceId, String openROADMversion) {
}
public boolean addNode(String deviceId, String openROADMversion) {
- boolean sqlResult = false;
+
//
boolean sqlResult = false;
return inode121.addNode(deviceId);
}
return inode121.addNode(deviceId);
}
@@
-60,7
+60,7
@@
public class INode {
} catch (SQLException e) {
LOG.error("Something wrong when fetching node in DB", e);
}
} catch (SQLException e) {
LOG.error("Something wrong when fetching node in DB", e);
}
- return nodeExists
== 0 ? false : true
;
+ return nodeExists
!= 0
;
}
public boolean dataExists(String tableName, String searchKeys) {
}
public boolean dataExists(String tableName, String searchKeys) {
@@
-79,7
+79,7
@@
public class INode {
} catch (SQLException e) {
LOG.error("Something wrong when fetching data in DB", e);
}
} catch (SQLException e) {
LOG.error("Something wrong when fetching data in DB", e);
}
- return dataExists
== 0 ? false : true
;
+ return dataExists
!= 0
;
}
/* public void getRoadmShelves(String nodeId, String openRoadmVersion)
}
/* public void getRoadmShelves(String nodeId, String openRoadmVersion)