Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Usage of Collections.unmodifiableCollection is unsafe
[controller.git]
/
opendaylight
/
md-sal
/
sal-distributed-datastore
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
datastore
/
DataChangeListenerSupport.java
diff --git
a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
index 9b2beccdad99740cbcba027e4a893d8cf9555133..2e26e6ee36d170d4bb0d3da3ae3d276d8f62305c 100644
(file)
--- a/
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
+++ b/
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
@@
-11,8
+11,8
@@
import akka.actor.ActorRef;
import akka.actor.ActorSelection;
import com.google.common.base.Optional;
import com.google.common.collect.Sets;
import akka.actor.ActorSelection;
import com.google.common.base.Optional;
import com.google.common.collect.Sets;
+import java.util.ArrayList;
import java.util.Collection;
import java.util.Collection;
-import java.util.Collections;
import java.util.Map.Entry;
import java.util.Set;
import org.opendaylight.controller.cluster.datastore.messages.EnableNotification;
import java.util.Map.Entry;
import java.util.Set;
import org.opendaylight.controller.cluster.datastore.messages.EnableNotification;
@@
-38,7
+38,7
@@
final class DataChangeListenerSupport extends AbstractDataListenerSupport<
}
Collection<ActorSelection> getListenerActors() {
}
Collection<ActorSelection> getListenerActors() {
- return
Collections.unmodifiableCollection
(listenerActors);
+ return
new ArrayList<>
(listenerActors);
}
@Override
}
@Override