Code Review
/
openflowplugin.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
public methods imlemented only in impl's extracted to parent interfaces
[openflowplugin.git]
/
openflowplugin-impl
/
src
/
main
/
java
/
org
/
opendaylight
/
openflowplugin
/
impl
/
device
/
listener
/
OpenflowProtocolListenerFullImpl.java
diff --git
a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/listener/OpenflowProtocolListenerFullImpl.java
b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/listener/OpenflowProtocolListenerFullImpl.java
index 26091d0070682fe1be7908985493138d391cb4f4..7316729170d7a476a821ccfe7c26c667911dc205 100644
(file)
--- a/
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/listener/OpenflowProtocolListenerFullImpl.java
+++ b/
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/listener/OpenflowProtocolListenerFullImpl.java
@@
-7,11
+7,6
@@
*/
package org.opendaylight.openflowplugin.impl.device.listener;
*/
package org.opendaylight.openflowplugin.impl.device.listener;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.SettableFuture;
-import java.util.Collection;
-import javax.annotation.CheckForNull;
-import javax.annotation.Nonnull;
import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter;
import org.opendaylight.openflowplugin.api.openflow.device.handlers.DeviceReplyProcessor;
import org.opendaylight.openflowplugin.api.openflow.device.handlers.MultiMsgCollector;
import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter;
import org.opendaylight.openflowplugin.api.openflow.device.handlers.DeviceReplyProcessor;
import org.opendaylight.openflowplugin.api.openflow.device.handlers.MultiMsgCollector;
@@
-28,6
+23,7
@@
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PortStatusMessage;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PortStatusMessage;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import javax.annotation.Nonnull;
/**
*
/**
*
@@
-37,7
+33,7
@@
public class OpenflowProtocolListenerFullImpl implements OpenflowProtocolListene
private static final Logger LOG = LoggerFactory.getLogger(OpenflowProtocolListenerFullImpl.class);
private final ConnectionAdapter connectionAdapter;
private static final Logger LOG = LoggerFactory.getLogger(OpenflowProtocolListenerFullImpl.class);
private final ConnectionAdapter connectionAdapter;
- private
final
DeviceReplyProcessor deviceReplyProcessor;
+ private DeviceReplyProcessor deviceReplyProcessor;
private final MultiMsgCollectorImpl multiMsgCollector;
/**
private final MultiMsgCollectorImpl multiMsgCollector;
/**
@@
-100,17
+96,17
@@
public class OpenflowProtocolListenerFullImpl implements OpenflowProtocolListene
}
@Override
}
@Override
- public
ListenableFuture<Collection<MultipartReply>> registerMultipartMsg
(final long xid) {
-
return multiMsgCollector.registerMultipartMsg
(xid);
+ public
void registerMultipartXid
(final long xid) {
+
multiMsgCollector.registerMultipartXid
(xid);
}
@Override
}
@Override
- public void
registerMultipartFutureMsg(final long xid, @CheckForNull final SettableFuture<Collection<MultipartReply>> future
) {
- multiMsgCollector.
registerMultipartFutureMsg(xid, future
);
+ public void
addMultipartMsg(@Nonnull final MultipartReply reply
) {
+ multiMsgCollector.
addMultipartMsg(reply
);
}
@Override
}
@Override
- public void
addMultipartMsg(@Nonnull final MultipartReply reply
) {
-
multiMsgCollector.addMultipartMsg(reply)
;
+ public void
setDeviceReplyProcessor(final DeviceReplyProcessor deviceReplyProcessor
) {
+
this.deviceReplyProcessor = deviceReplyProcessor
;
}
}
}
}