Code Review
/
netconf.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Bug 8351: Enforce check-style rules for restconf - sal-rest-connector
[netconf.git]
/
restconf
/
sal-rest-connector
/
src
/
test
/
java
/
org
/
opendaylight
/
controller
/
sal
/
restconf
/
impl
/
websockets
/
client
/
WebSocketClientHandler.java
diff --git
a/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/websockets/client/WebSocketClientHandler.java
b/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/websockets/client/WebSocketClientHandler.java
index e07d8c48f0f2c9ba253a1282f4bf0e453ae19e3f..03c132b899469747430c7fd8ceabdf8075226dc4 100644
(file)
--- a/
restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/websockets/client/WebSocketClientHandler.java
+++ b/
restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/websockets/client/WebSocketClientHandler.java
@@
-23,7
+23,7
@@
import org.slf4j.LoggerFactory;
public class WebSocketClientHandler extends SimpleChannelInboundHandler<Object> {
public class WebSocketClientHandler extends SimpleChannelInboundHandler<Object> {
- private static final Logger
logger
= LoggerFactory.getLogger(WebSocketClientHandler.class.toString());
+ private static final Logger
LOG
= LoggerFactory.getLogger(WebSocketClientHandler.class.toString());
private final WebSocketClientHandshaker handshaker;
private ChannelPromise handshakeFuture;
private final IClientMessageCallback messageListener;
private final WebSocketClientHandshaker handshaker;
private ChannelPromise handshakeFuture;
private final IClientMessageCallback messageListener;
@@
-49,7
+49,7
@@
public class WebSocketClientHandler extends SimpleChannelInboundHandler<Object>
@Override
public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelInactive(ChannelHandlerContext ctx) throws Exception {
-
logger
.info("WebSocket Client disconnected!");
+
LOG
.info("WebSocket Client disconnected!");
}
@Override
}
@Override
@@
-57,7
+57,7
@@
public class WebSocketClientHandler extends SimpleChannelInboundHandler<Object>
Channel ch = ctx.channel();
if (!handshaker.isHandshakeComplete()) {
handshaker.finishHandshake(ch, (FullHttpResponse) msg);
Channel ch = ctx.channel();
if (!handshaker.isHandshakeComplete()) {
handshaker.finishHandshake(ch, (FullHttpResponse) msg);
-
logger
.info("WebSocket Client connected!");
+
LOG
.info("WebSocket Client connected!");
handshakeFuture.setSuccess();
return;
}
handshakeFuture.setSuccess();
return;
}
@@
-72,16
+72,16
@@
public class WebSocketClientHandler extends SimpleChannelInboundHandler<Object>
WebSocketFrame frame = (WebSocketFrame) msg;
if (frame instanceof PongWebSocketFrame) {
WebSocketFrame frame = (WebSocketFrame) msg;
if (frame instanceof PongWebSocketFrame) {
-
logger
.info("WebSocket Client received pong");
+
LOG
.info("WebSocket Client received pong");
} else if (frame instanceof CloseWebSocketFrame) {
} else if (frame instanceof CloseWebSocketFrame) {
-
logger
.info("WebSocket Client received closing");
+
LOG
.info("WebSocket Client received closing");
ch.close();
}
}
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
ch.close();
}
}
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
-
cause.printStackTrace(
);
+
LOG.info("Cause: {} .", cause.toString()
);
if (!handshakeFuture.isDone()) {
handshakeFuture.setFailure(cause);
if (!handshakeFuture.isDone()) {
handshakeFuture.setFailure(cause);