*/
package org.opendaylight.openflowplugin.applications.frm.impl;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.buildGroupInstanceIdentifier;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.getActiveBundle;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.getFlowId;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.getNodeIdFromNodeIdentifier;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.isFlowDependentOnGroup;
+import static org.opendaylight.openflowplugin.applications.frm.util.FrmUtil.isGroupExistsOnDevice;
+
+import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
-import com.google.common.util.concurrent.CheckedFuture;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.SettableFuture;
+import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import org.opendaylight.controller.md.sal.binding.api.DataBroker;
import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier;
import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
-import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
+import org.opendaylight.infrautils.utils.concurrent.JdkFutures;
import org.opendaylight.openflowplugin.applications.frm.ForwardingRulesManager;
-import org.opendaylight.openflowplugin.common.wait.SimpleTaskRetryLooper;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNode;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.StaleFlow;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.StaleFlowBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.StaleFlowKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.AddFlowInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.AddFlowInputBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.AddFlowOutput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.FlowTableRef;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.RemoveFlowInputBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.RemoveFlowOutput;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.UpdateFlowInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.UpdateFlowInputBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.UpdateFlowOutput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.flow.update.OriginalFlowBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.flow.update.UpdatedFlowBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.FlowRef;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.group.service.rev130918.AddGroupInput;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.group.service.rev130918.AddGroupInputBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.group.service.rev130918.AddGroupOutput;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupRef;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.groups.Group;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.onf.rev170124.BundleId;
import org.opendaylight.yangtools.concepts.ListenerRegistration;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.opendaylight.yangtools.yang.common.RpcError;
import org.opendaylight.yangtools.yang.common.RpcResult;
+import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class FlowForwarder extends AbstractListeningCommiter<Flow> {
private static final Logger LOG = LoggerFactory.getLogger(FlowForwarder.class);
- private final DataBroker dataBroker;
+
+ private static final String GROUP_EXISTS_IN_DEVICE_ERROR = "GROUPEXISTS";
+
private ListenerRegistration<FlowForwarder> listenerRegistration;
+ private final BundleFlowForwarder bundleFlowForwarder;
public FlowForwarder(final ForwardingRulesManager manager, final DataBroker db) {
- super(manager);
- dataBroker = Preconditions.checkNotNull(db, "DataBroker can not be null!");
- registrationListener(db);
+ super(manager, db);
+ bundleFlowForwarder = new BundleFlowForwarder(manager);
}
@SuppressWarnings("IllegalCatch")
- private void registrationListener(final DataBroker db) {
+ @Override
+ public void registerListener() {
final DataTreeIdentifier<Flow> treeId = new DataTreeIdentifier<>(LogicalDatastoreType.CONFIGURATION,
getWildCardPath());
try {
- SimpleTaskRetryLooper looper = new SimpleTaskRetryLooper(ForwardingRulesManagerImpl.STARTUP_LOOP_TICK,
- ForwardingRulesManagerImpl.STARTUP_LOOP_MAX_RETRIES);
- listenerRegistration = looper
- .loopUntilNoException(() -> db.registerDataTreeChangeListener(treeId, FlowForwarder.this));
+ listenerRegistration = dataBroker.registerDataTreeChangeListener(treeId, FlowForwarder.this);
} catch (final Exception e) {
LOG.warn("FRM Flow DataTreeChange listener registration fail!");
LOG.debug("FRM Flow DataTreeChange listener registration fail ..", e);
}
}
+
+ @Override
+ public void deregisterListener() {
+ close();
+ }
+
@Override
public void close() {
if (listenerRegistration != null) {
public void remove(final InstanceIdentifier<Flow> identifier, final Flow removeDataObj,
final InstanceIdentifier<FlowCapableNode> nodeIdent) {
- final TableKey tableKey = identifier.firstKeyOf(Table.class, TableKey.class);
+ final TableKey tableKey = identifier.firstKeyOf(Table.class);
if (tableIdValidationPrecondition(tableKey, removeDataObj)) {
- final RemoveFlowInputBuilder builder = new RemoveFlowInputBuilder(removeDataObj);
- builder.setFlowRef(new FlowRef(identifier));
- builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
- builder.setFlowTable(new FlowTableRef(nodeIdent.child(Table.class, tableKey)));
-
- // This method is called only when a given flow object has been
- // removed from datastore. So FRM always needs to set strict flag
- // into remove-flow input so that only a flow entry associated with
- // a given flow object is removed.
- builder.setTransactionUri(new Uri(provider.getNewTransactionId())).setStrict(Boolean.TRUE);
- provider.getSalFlowService().removeFlow(builder.build());
+ BundleId bundleId = getActiveBundle(nodeIdent, provider);
+ if (bundleId != null) {
+ bundleFlowForwarder.remove(identifier, removeDataObj, nodeIdent, bundleId);
+ } else {
+ final RemoveFlowInputBuilder builder = new RemoveFlowInputBuilder(removeDataObj);
+ builder.setFlowRef(new FlowRef(identifier));
+ builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
+ builder.setFlowTable(new FlowTableRef(nodeIdent.child(Table.class, tableKey)));
+
+ // This method is called only when a given flow object has been
+ // removed from datastore. So FRM always needs to set strict flag
+ // into remove-flow input so that only a flow entry associated with
+ // a given flow object is removed.
+ builder.setTransactionUri(new Uri(provider.getNewTransactionId())).setStrict(Boolean.TRUE);
+ final Future<RpcResult<RemoveFlowOutput>> resultFuture =
+ provider.getSalFlowService().removeFlow(builder.build());
+ JdkFutures.addErrorLogging(resultFuture, LOG, "removeFlow");
+ }
}
}
final Flow removeDataObj, final InstanceIdentifier<FlowCapableNode> nodeIdent) {
Future<RpcResult<RemoveFlowOutput>> resultFuture = SettableFuture.create();
- final TableKey tableKey = identifier.firstKeyOf(Table.class, TableKey.class);
+ final TableKey tableKey = identifier.firstKeyOf(Table.class);
if (tableIdValidationPrecondition(tableKey, removeDataObj)) {
final RemoveFlowInputBuilder builder = new RemoveFlowInputBuilder(removeDataObj);
builder.setFlowRef(new FlowRef(identifier));
public void update(final InstanceIdentifier<Flow> identifier, final Flow original, final Flow update,
final InstanceIdentifier<FlowCapableNode> nodeIdent) {
- final TableKey tableKey = identifier.firstKeyOf(Table.class, TableKey.class);
+ final TableKey tableKey = identifier.firstKeyOf(Table.class);
if (tableIdValidationPrecondition(tableKey, update)) {
- final UpdateFlowInputBuilder builder = new UpdateFlowInputBuilder();
-
- builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
- builder.setFlowRef(new FlowRef(identifier));
- builder.setTransactionUri(new Uri(provider.getNewTransactionId()));
-
- // This method is called only when a given flow object in datastore
- // has been updated. So FRM always needs to set strict flag into
- // update-flow input so that only a flow entry associated with
- // a given flow object is updated.
- builder.setUpdatedFlow(new UpdatedFlowBuilder(update).setStrict(Boolean.TRUE).build());
- builder.setOriginalFlow(new OriginalFlowBuilder(original).setStrict(Boolean.TRUE).build());
-
- provider.getSalFlowService().updateFlow(builder.build());
+ BundleId bundleId = getActiveBundle(nodeIdent, provider);
+ if (bundleId != null) {
+ bundleFlowForwarder.update(identifier, original, update, nodeIdent, bundleId);
+ } else {
+ final NodeId nodeId = getNodeIdFromNodeIdentifier(nodeIdent);
+ nodeConfigurator.enqueueJob(nodeId.getValue(), () -> {
+ final UpdateFlowInputBuilder builder = new UpdateFlowInputBuilder();
+ builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
+ builder.setFlowRef(new FlowRef(identifier));
+ builder.setTransactionUri(new Uri(provider.getNewTransactionId()));
+
+ // This method is called only when a given flow object in datastore
+ // has been updated. So FRM always needs to set strict flag into
+ // update-flow input so that only a flow entry associated with
+ // a given flow object is updated.
+ builder.setUpdatedFlow(new UpdatedFlowBuilder(update).setStrict(Boolean.TRUE).build());
+ builder.setOriginalFlow(new OriginalFlowBuilder(original).setStrict(Boolean.TRUE).build());
+
+ Long groupId = isFlowDependentOnGroup(update);
+ ListenableFuture<RpcResult<UpdateFlowOutput>> future = Futures.immediateFuture(null);
+ if (groupId != null) {
+ LOG.trace("The flow {} is dependent on group {}. Checking if the group is already present",
+ getFlowId(new FlowRef(identifier)), groupId);
+ if (isGroupExistsOnDevice(nodeIdent, groupId, provider)) {
+ LOG.trace("The dependent group {} is already programmed. Updating the flow {}", groupId,
+ getFlowId(new FlowRef(identifier)));
+ future = provider.getSalFlowService().updateFlow(builder.build());
+ JdkFutures.addErrorLogging(future, LOG, "updateFlow");
+ } else {
+ LOG.trace("The dependent group {} isn't programmed yet. Pushing the group", groupId);
+ ListenableFuture<RpcResult<AddGroupOutput>> groupFuture = pushDependentGroup(nodeIdent,
+ groupId);
+ Futures.addCallback(groupFuture,
+ new UpdateFlowCallBack(builder.build(), nodeId, future, groupId),
+ MoreExecutors.directExecutor());
+ }
+ } else {
+ LOG.trace("The flow {} is not dependent on any group. Updating the flow",
+ getFlowId(new FlowRef(identifier)));
+ future = provider.getSalFlowService().updateFlow(builder.build());
+ JdkFutures.addErrorLogging(future, LOG, "updateFlow");
+ }
+ return future;
+ });
+ }
}
}
@Override
- public Future<RpcResult<AddFlowOutput>> add(final InstanceIdentifier<Flow> identifier, final Flow addDataObj,
+ public Future<? extends RpcResult<?>> add(final InstanceIdentifier<Flow> identifier, final Flow addDataObj,
final InstanceIdentifier<FlowCapableNode> nodeIdent) {
- Future<RpcResult<AddFlowOutput>> future;
- final TableKey tableKey = identifier.firstKeyOf(Table.class, TableKey.class);
+ final TableKey tableKey = identifier.firstKeyOf(Table.class);
if (tableIdValidationPrecondition(tableKey, addDataObj)) {
- final AddFlowInputBuilder builder = new AddFlowInputBuilder(addDataObj);
-
- builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
- builder.setFlowRef(new FlowRef(identifier));
- builder.setFlowTable(new FlowTableRef(nodeIdent.child(Table.class, tableKey)));
- builder.setTransactionUri(new Uri(provider.getNewTransactionId()));
- future = provider.getSalFlowService().addFlow(builder.build());
- } else {
- future = Futures.<RpcResult<AddFlowOutput>>immediateFuture(null);
+ BundleId bundleId = getActiveBundle(nodeIdent, provider);
+ if (bundleId != null) {
+ return bundleFlowForwarder.add(identifier, addDataObj, nodeIdent, bundleId);
+ } else {
+ final NodeId nodeId = getNodeIdFromNodeIdentifier(nodeIdent);
+ nodeConfigurator.enqueueJob(nodeId.getValue(), () -> {
+ final AddFlowInputBuilder builder = new AddFlowInputBuilder(addDataObj);
+
+ builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
+ builder.setFlowRef(new FlowRef(identifier));
+ builder.setFlowTable(new FlowTableRef(nodeIdent.child(Table.class, tableKey)));
+ builder.setTransactionUri(new Uri(provider.getNewTransactionId()));
+ Long groupId = isFlowDependentOnGroup(addDataObj);
+ ListenableFuture<RpcResult<AddFlowOutput>> future = SettableFuture.create();
+ if (groupId != null) {
+ LOG.trace("The flow {} is dependent on group {}. Checking if the group is already present",
+ getFlowId(new FlowRef(identifier)), groupId);
+ if (isGroupExistsOnDevice(nodeIdent, groupId, provider)) {
+ LOG.trace("The dependent group {} is already programmed. Adding the flow {}", groupId,
+ getFlowId(new FlowRef(identifier)));
+ future = provider.getSalFlowService().addFlow(builder.build());
+ } else {
+ LOG.trace("The dependent group {} isn't programmed yet. Pushing the group", groupId);
+ ListenableFuture<RpcResult<AddGroupOutput>> groupFuture = pushDependentGroup(nodeIdent,
+ groupId);
+ Futures.addCallback(groupFuture, new AddFlowCallBack(builder.build(), nodeId, future,
+ groupId),
+ MoreExecutors.directExecutor());
+ }
+ } else {
+ LOG.trace("The flow {} is not dependent on any group. Adding the flow",
+ getFlowId(new FlowRef(identifier)));
+ future = provider.getSalFlowService().addFlow(builder.build());
+ }
+ return future;
+ });
+ }
}
-
- return future;
+ return Futures.immediateFuture(null);
}
@Override
public void createStaleMarkEntity(InstanceIdentifier<Flow> identifier, Flow del,
InstanceIdentifier<FlowCapableNode> nodeIdent) {
LOG.debug("Creating Stale-Mark entry for the switch {} for flow {} ", nodeIdent.toString(), del.toString());
-
StaleFlow staleFlow = makeStaleFlow(identifier, del, nodeIdent);
persistStaleFlow(staleFlow, nodeIdent);
-
}
@Override
writeTransaction.put(LogicalDatastoreType.CONFIGURATION, getStaleFlowInstanceIdentifier(staleFlow, nodeIdent),
staleFlow, false);
- CheckedFuture<Void, TransactionCommitFailedException> submitFuture = writeTransaction.submit();
+ ListenableFuture<Void> submitFuture = writeTransaction.submit();
handleStaleFlowResultFuture(submitFuture);
}
- private void handleStaleFlowResultFuture(CheckedFuture<Void, TransactionCommitFailedException> submitFuture) {
+ private void handleStaleFlowResultFuture(ListenableFuture<Void> submitFuture) {
Futures.addCallback(submitFuture, new FutureCallback<Void>() {
@Override
public void onSuccess(Void result) {
public void onFailure(Throwable throwable) {
LOG.error("Stale Flow creation failed {}", throwable);
}
- });
+ }, MoreExecutors.directExecutor());
}
org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.StaleFlow.class,
new StaleFlowKey(new FlowId(staleFlow.getId())));
}
+
+ private ListenableFuture<RpcResult<AddGroupOutput>> pushDependentGroup(
+ final InstanceIdentifier<FlowCapableNode> nodeIdent, final Long groupId) {
+
+ //TODO This read to the DS might have a performance impact.
+ //if the dependent group is not installed than we should just cache the parent group,
+ //till we receive the dependent group DTCN and then push it.
+
+ InstanceIdentifier<Group> groupIdent = buildGroupInstanceIdentifier(nodeIdent, groupId);
+ ListenableFuture<RpcResult<AddGroupOutput>> resultFuture;
+ LOG.info("Reading the group from config inventory: {}", groupId);
+ try {
+ Optional<Group> group;
+ group = provider.getReadTranaction().read(LogicalDatastoreType.CONFIGURATION, groupIdent).get();
+ if (group.isPresent()) {
+ final AddGroupInputBuilder builder = new AddGroupInputBuilder(group.get());
+ builder.setNode(new NodeRef(nodeIdent.firstIdentifierOf(Node.class)));
+ builder.setGroupRef(new GroupRef(nodeIdent));
+ builder.setTransactionUri(new Uri(provider.getNewTransactionId()));
+ AddGroupInput addGroupInput = builder.build();
+ resultFuture = this.provider.getSalGroupService().addGroup(addGroupInput);
+ } else {
+ resultFuture = Futures.immediateFuture(RpcResultBuilder.<AddGroupOutput>failed()
+ .withError(RpcError.ErrorType.APPLICATION,
+ "Group " + groupId + " not present in the config inventory").build());
+ }
+ } catch (InterruptedException | ExecutionException e) {
+ LOG.error("Error while reading group from config datastore for the group ID {}", groupId, e);
+ resultFuture = Futures.immediateFuture(RpcResultBuilder.<AddGroupOutput>failed()
+ .withError(RpcError.ErrorType.APPLICATION,
+ "Error while reading group " + groupId + " from inventory").build());
+ }
+ return resultFuture;
+ }
+
+ private final class AddFlowCallBack implements FutureCallback<RpcResult<AddGroupOutput>> {
+ private final AddFlowInput addFlowInput;
+ private final NodeId nodeId;
+ private ListenableFuture<RpcResult<AddFlowOutput>> future;
+ private final Long groupId;
+
+ private AddFlowCallBack(final AddFlowInput addFlowInput, final NodeId nodeId,
+ ListenableFuture<RpcResult<AddFlowOutput>> future, Long groupId) {
+ this.addFlowInput = addFlowInput;
+ this.nodeId = nodeId;
+ this.future = future;
+ this.groupId = groupId;
+ }
+
+ @Override
+ public void onSuccess(RpcResult<AddGroupOutput> rpcResult) {
+ if (rpcResult.isSuccessful()) {
+ provider.getDevicesGroupRegistry().storeGroup(nodeId, groupId);
+ future = provider.getSalFlowService().addFlow(addFlowInput);
+ LOG.debug("Flow add with id {} finished without error for node {}",
+ getFlowId(addFlowInput.getFlowRef()), nodeId);
+ } else {
+ if (rpcResult.getErrors().size() == 1
+ && rpcResult.getErrors().iterator().next().getMessage()
+ .contains(GROUP_EXISTS_IN_DEVICE_ERROR)) {
+ provider.getDevicesGroupRegistry().storeGroup(nodeId, groupId);
+ future = provider.getSalFlowService().addFlow(addFlowInput);
+ LOG.debug("Group {} already programmed in the device. Adding the flow {}", groupId,
+ getFlowId(addFlowInput.getFlowRef()));
+ } else {
+ LOG.error("Flow add with id {} failed for node {} with error {}",
+ getFlowId(addFlowInput.getFlowRef()), nodeId, rpcResult.getErrors().toString());
+ future = Futures.immediateFuture(null);
+ }
+ }
+ }
+
+ @Override
+ public void onFailure(Throwable throwable) {
+ LOG.error("Service call for adding flow with id {} failed for node {} with error {}",
+ getFlowId(addFlowInput.getFlowRef()), nodeId, throwable.getCause());
+ Futures.immediateFailedFuture(null);
+ }
+ }
+
+ private final class UpdateFlowCallBack implements FutureCallback<RpcResult<AddGroupOutput>> {
+ private final UpdateFlowInput updateFlowInput;
+ private final NodeId nodeId;
+ private ListenableFuture<RpcResult<UpdateFlowOutput>> future;
+ private final Long groupId;
+
+ private UpdateFlowCallBack(final UpdateFlowInput updateFlowInput, final NodeId nodeId,
+ ListenableFuture<RpcResult<UpdateFlowOutput>> future, Long groupId) {
+ this.updateFlowInput = updateFlowInput;
+ this.nodeId = nodeId;
+ this.future = future;
+ this.groupId = groupId;
+ }
+
+ @Override
+ public void onSuccess(RpcResult<AddGroupOutput> rpcResult) {
+ if (rpcResult.isSuccessful()) {
+ provider.getDevicesGroupRegistry().storeGroup(nodeId, groupId);
+ future = provider.getSalFlowService().updateFlow(updateFlowInput);
+ LOG.debug("Flow update with id {} finished without error for node {}",
+ getFlowId(updateFlowInput.getFlowRef()), nodeId);
+ } else {
+ if (rpcResult.getErrors().size() == 1
+ && rpcResult.getErrors().iterator().next().getMessage()
+ .contains(GROUP_EXISTS_IN_DEVICE_ERROR)) {
+ provider.getDevicesGroupRegistry().storeGroup(nodeId, groupId);
+ future = provider.getSalFlowService().updateFlow(updateFlowInput);
+ LOG.debug("Group {} already programmed in the device. Updating the flow {}", groupId,
+ getFlowId(updateFlowInput.getFlowRef()));
+ } else {
+ LOG.error("Flow update with id {} failed for node {} with error {}",
+ getFlowId(updateFlowInput.getFlowRef()), nodeId, rpcResult.getErrors().toString());
+ future = Futures.immediateFuture(null);
+ }
+ }
+ }
+
+ @Override
+ public void onFailure(Throwable throwable) {
+ LOG.error("Service call for updating flow with id {} failed for node {} with error {}",
+ getFlowId(updateFlowInput.getFlowRef()), nodeId, throwable);
+ future = Futures.immediateFailedFuture(null);
+ }
+ }
}
Code Review / openflowplugin.git / blobdiff