* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.openflowplugin.applications.frm.impl;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.SettableFuture;
import javax.inject.Inject;
import javax.inject.Singleton;
-
-import org.apache.aries.blueprint.annotation.service.Service;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNode;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflowplugin.app.frm.reconciliation.service.rev180227.ReconcileNodeOutput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflowplugin.app.frm.reconciliation.service.rev180227.ReconcileNodeOutputBuilder;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
-import org.opendaylight.yangtools.yang.common.RpcError;
+import org.opendaylight.yangtools.yang.common.ErrorType;
import org.opendaylight.yangtools.yang.common.RpcResult;
import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@Singleton
-@Service(classes = FrmReconciliationService.class)
public class FrmReconciliationServiceImpl implements FrmReconciliationService {
private static final Logger LOG = LoggerFactory.getLogger(FrmReconciliationServiceImpl.class);
this.forwardingRulesManagerImpl = forwardingRulesManagerImpl;
}
- private Node buildNode(long nodeIid) {
+ private static Node buildNode(long nodeIid) {
NodeId nodeId = new NodeId("openflow:" + nodeIid);
Node nodeDpn = new NodeBuilder().setId(nodeId).withKey(new NodeKey(nodeId)).build();
return nodeDpn;
@Override
public ListenableFuture<RpcResult<ReconcileNodeOutput>> reconcileNode(ReconcileNodeInput input) {
- LOG.debug("Triggering reconciliation for node: {}", input.getNodeId().toString());
+ LOG.debug("Triggering reconciliation for node: {}", input.getNodeId());
Node nodeDpn = buildNode(input.getNodeId().longValue());
InstanceIdentifier<FlowCapableNode> connectedNode = InstanceIdentifier.builder(Nodes.class)
.child(Node.class, nodeDpn.key()).augmentation(FlowCapableNode.class).build();
SettableFuture<RpcResult<ReconcileNodeOutput>> rpcResult = SettableFuture.create();
ListenableFuture<Boolean> futureResult = forwardingRulesManagerImpl
.getNodeListener().reconcileConfiguration(connectedNode);
- Futures.addCallback(futureResult, new ResultCallBack(futureResult, rpcResult));
- LOG.debug("Completing reconciliation for node: {}", input.getNodeId().toString());
+ Futures.addCallback(futureResult, new ResultCallBack(futureResult, rpcResult),
+ MoreExecutors.directExecutor());
+ LOG.debug("Completing reconciliation for node: {}", input.getNodeId());
return rpcResult;
}
futureResult.set(RpcResultBuilder.success(output).build());
} else {
futureResult.set(RpcResultBuilder.<ReconcileNodeOutput>failed()
- .withError(RpcError.ErrorType.APPLICATION, "Error while triggering reconciliation").build());
+ .withError(ErrorType.APPLICATION, "Error while triggering reconciliation").build());
}
}
public void onFailure(Throwable error) {
LOG.error("initReconciliation failed", error);
futureResult.set(RpcResultBuilder.<ReconcileNodeOutput>failed()
- .withError(RpcError.ErrorType.RPC,"Error while calling RPC").build());
+ .withError(ErrorType.RPC, "Error while calling RPC").build());
}
}
}