-/**
+/*
* Copyright (c) 2016 Cisco Systems, Inc. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.openflowplugin.applications.frsync.impl;
-import com.google.common.base.Preconditions;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
import java.util.concurrent.Semaphore;
import java.util.concurrent.TimeUnit;
-import javax.annotation.Nullable;
import org.opendaylight.openflowplugin.applications.frsync.SemaphoreKeeper;
import org.opendaylight.openflowplugin.applications.frsync.SyncReactor;
import org.opendaylight.openflowplugin.applications.frsync.util.PathUtil;
+import org.opendaylight.openflowplugin.applications.frsync.util.SemaphoreKeeperGuavaImpl;
import org.opendaylight.openflowplugin.applications.frsync.util.SyncupEntry;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNode;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
public class SyncReactorGuardDecorator implements SyncReactor {
private static final Logger LOG = LoggerFactory.getLogger(SyncReactorGuardDecorator.class);
-
private final SyncReactor delegate;
- private final SemaphoreKeeper<InstanceIdentifier<FlowCapableNode>> semaphoreKeeper;
+ private final SemaphoreKeeper<InstanceIdentifier<FlowCapableNode>> semaphoreKeeper =
+ new SemaphoreKeeperGuavaImpl<>(1, true);
- public SyncReactorGuardDecorator(SyncReactor delegate,
- SemaphoreKeeper<InstanceIdentifier<FlowCapableNode>> semaphoreKeeper) {
+ public SyncReactorGuardDecorator(final SyncReactor delegate) {
this.delegate = delegate;
- this.semaphoreKeeper = semaphoreKeeper;
}
+ @Override
public ListenableFuture<Boolean> syncup(final InstanceIdentifier<FlowCapableNode> flowcapableNodePath,
- final SyncupEntry syncupEntry) throws InterruptedException {
+ final SyncupEntry syncupEntry) {
final NodeId nodeId = PathUtil.digNodeId(flowcapableNodePath);
- LOG.trace("syncup guard decorator: {}", nodeId.getValue());
-
final long stampBeforeGuard = System.nanoTime();
- final Semaphore guard = summonGuardAndAcquire(flowcapableNodePath);
+ final Semaphore guard = semaphoreKeeper.summonGuardAndAcquire(flowcapableNodePath);
if (guard == null) {
- return Futures.immediateFuture(false);
+ return Futures.immediateFuture(Boolean.FALSE);
}
final long stampAfterGuard = System.nanoTime();
- try {
- if (LOG.isDebugEnabled()) {
- LOG.debug("syncup start {} waiting:{} guard:{} thread:{}", nodeId.getValue(),
- formatNanos(stampAfterGuard - stampBeforeGuard),
- guard, threadName());
- }
-
- final ListenableFuture<Boolean> endResult =
- delegate.syncup(flowcapableNodePath, syncupEntry);
-
- Futures.addCallback(endResult, createSyncupCallback(guard, stampBeforeGuard, stampAfterGuard, nodeId));
- return endResult;
- } catch (InterruptedException e) {
- releaseGuardForNodeId(guard);
- throw e;
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Syncup guard acquired and running for {} ", nodeId.getValue());
}
+ final ListenableFuture<Boolean> endResult = delegate.syncup(flowcapableNodePath, syncupEntry);
+ Futures.addCallback(endResult, createSyncupCallback(guard, stampBeforeGuard, stampAfterGuard, nodeId),
+ MoreExecutors.directExecutor());
+ return endResult;
}
- private static FutureCallback<Boolean> createSyncupCallback(final Semaphore guard,
- final long stampBeforeGuard,
- final long stampAfterGuard,
- final NodeId nodeId) {
- return new FutureCallback<Boolean>() {
+ private FutureCallback<Boolean> createSyncupCallback(final Semaphore guard,
+ final long stampBeforeGuard,
+ final long stampAfterGuard,
+ final NodeId nodeId) {
+ return new FutureCallback<>() {
@Override
- public void onSuccess(@Nullable final Boolean result) {
+ public void onSuccess(final Boolean result) {
if (LOG.isDebugEnabled()) {
final long stampFinished = System.nanoTime();
- LOG.debug("syncup finished {} took:{} rpc:{} wait:{} guard:{} permits thread:{}", nodeId.getValue(),
+ LOG.debug("Syncup finished {} took:{} rpc:{} wait:{}", nodeId.getValue(),
formatNanos(stampFinished - stampBeforeGuard), formatNanos(stampFinished - stampAfterGuard),
- formatNanos(stampAfterGuard - stampBeforeGuard), guard.availablePermits(), threadName());
+ formatNanos(stampAfterGuard - stampBeforeGuard));
}
- releaseGuardForNodeId(guard);
+ semaphoreKeeper.releaseGuard(guard);
}
+
@Override
- public void onFailure(final Throwable t) {
+ public void onFailure(final Throwable failure) {
final long stampFinished = System.nanoTime();
- LOG.error("syncup failed {} took:{} rpc:{} wait:{} guard:{} permits thread:{}", nodeId.getValue(),
+ LOG.warn("Syncup failed {} took:{} rpc:{} wait:{}", nodeId.getValue(),
formatNanos(stampFinished - stampBeforeGuard), formatNanos(stampFinished - stampAfterGuard),
- formatNanos(stampAfterGuard - stampBeforeGuard), guard.availablePermits(), threadName());
- releaseGuardForNodeId(guard);
- }};
+ formatNanos(stampAfterGuard - stampBeforeGuard));
+ semaphoreKeeper.releaseGuard(guard);
+ }
+ };
}
- private static String formatNanos(long nanos) {
+ private static String formatNanos(final long nanos) {
return "'" + TimeUnit.NANOSECONDS.toMillis(nanos) + " ms'";
}
-
- /**
- * Get guard and lock for node.
- * @param flowcapableNodePath II of node for which guard should be acquired
- * @return semaphore guard
- */
- private Semaphore summonGuardAndAcquire(final InstanceIdentifier<FlowCapableNode> flowcapableNodePath) {
- final NodeId nodeId = PathUtil.digNodeId(flowcapableNodePath);
- final Semaphore guard = Preconditions.checkNotNull(semaphoreKeeper.summonGuard(flowcapableNodePath),
- "no guard for " + nodeId.getValue());
- try {
- guard.acquire();
- } catch (InterruptedException e) {
- LOG.error("syncup summon {} failed {}", nodeId.getValue(), e);
- return null;
- }
- LOG.trace("syncup summon {} guard:{} thread:{}", nodeId.getValue(), guard, threadName());
- return guard;
- }
-
- /**
- * Unlock and release guard.
- * @param guard semaphore guard which should be unlocked
- */
- private static void releaseGuardForNodeId(final Semaphore guard) {
- if (guard != null) {
- guard.release();
- LOG.trace("syncup release guard:{} thread:{}", guard, threadName());
- }
- }
-
- private static String threadName() {
- final Thread currentThread = Thread.currentThread();
- return currentThread.getName();
- }
-
}
Code Review / openflowplugin.git / blobdiff