Enforce findbug & checkstyle for bgp inet

[bgpcep.git] / bgp / inet / src / test / java / org / opendaylight / protocol / bgp / inet / codec / nexthop / NextHopParserSerializerTest.java

diff --git a/bgp/inet/src/test/java/org/opendaylight/protocol/bgp/inet/codec/nexthop/NextHopParserSerializerTest.java b/bgp/inet/src/test/java/org/opendaylight/protocol/bgp/inet/codec/nexthop/NextHopParserSerializerTest.java
index 786d45d11a403525856732faf5f0a77b32f90e60..31207f51cf9958e9c2dd302a83ad092a671964f5 100644 (file)
--- a/bgp/inet/src/test/java/org/opendaylight/protocol/bgp/inet/codec/nexthop/NextHopParserSerializerTest.java
+++ b/bgp/inet/src/test/java/org/opendaylight/protocol/bgp/inet/codec/nexthop/NextHopParserSerializerTest.java
@@ -16,8 +16,6 @@ import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import org.junit.Before;
 import org.junit.Test;
-import org.opendaylight.protocol.bgp.inet.codec.nexthop.Ipv4NextHopParserSerializer;
-import org.opendaylight.protocol.bgp.inet.codec.nexthop.Ipv6NextHopParserSerializer;
 import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.protocol.util.ByteArray;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Address;
@@ -32,16 +30,16 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.type
 
 public class NextHopParserSerializerTest {
 
-    public static final byte[] ipv6lB = {0x20, 1, 0x0d, (byte) 0xb8, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+    private static final byte[] IPV6LB = {0x20, 1, 0x0d, (byte) 0xb8, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
         1, (byte) 0xfe, (byte) 0x80, 0, 0, 0, 0, 0, 0, (byte) 0xc0, 1, 0x0b, (byte) 0xff, (byte) 0xfe, 0x7e, 0, 0};
 
-    public static final Ipv6Address ipv6 = new Ipv6Address("2001:db8::1");
-    public static final Ipv6Address ipv6l = new Ipv6Address("fe80::c001:bff:fe7e:0");
+    private static final Ipv6Address IPV6 = new Ipv6Address("2001:db8::1");
+    private static final Ipv6Address IPV6L = new Ipv6Address("fe80::c001:bff:fe7e:0");
 
-    Ipv4NextHopParserSerializer ipv4NextHopParserSerializer;
-    Ipv6NextHopParserSerializer ipv6NextHopParserSerializer;
-    CNextHop hop;
-    ByteBuf buffer;
+    private Ipv4NextHopParserSerializer ipv4NextHopParserSerializer;
+    private Ipv6NextHopParserSerializer ipv6NextHopParserSerializer;
+    private CNextHop hop;
+    private ByteBuf buffer;
 
     @Before
     public final void setUp() {
@@ -66,12 +64,13 @@ public class NextHopParserSerializerTest {
 
     @Test
     public void testSerializeIpv6LinkNextHopCase() throws BGPParsingException {
-        this.hop = new Ipv6NextHopCaseBuilder().setIpv6NextHop(new Ipv6NextHopBuilder().setGlobal(ipv6).setLinkLocal(ipv6l).build()).build();
+        this.hop = new Ipv6NextHopCaseBuilder().setIpv6NextHop(new Ipv6NextHopBuilder()
+                .setGlobal(IPV6).setLinkLocal(IPV6L).build()).build();
         this.buffer.clear();
         this.ipv6NextHopParserSerializer.serializeNextHop(this.hop, this.buffer);
-        assertArrayEquals(ipv6lB, ByteArray.readAllBytes(this.buffer));
+        assertArrayEquals(IPV6LB, ByteArray.readAllBytes(this.buffer));
 
-        final CNextHop parsedHop = this.ipv6NextHopParserSerializer.parseNextHop(Unpooled.wrappedBuffer(ipv6lB));
+        final CNextHop parsedHop = this.ipv6NextHopParserSerializer.parseNextHop(Unpooled.wrappedBuffer(IPV6LB));
         assertTrue(parsedHop instanceof Ipv6NextHopCase);
         assertEquals(this.hop, parsedHop);
     }