import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
-import com.google.common.collect.Lists;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
-import java.util.Collections;
import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.ServiceLoader;
import org.junit.BeforeClass;
import org.junit.Test;
+import org.opendaylight.protocol.bgp.parser.BGPDocumentedException;
import org.opendaylight.protocol.bgp.parser.impl.message.BGPUpdateMessageParser;
import org.opendaylight.protocol.bgp.parser.impl.message.update.CommunityUtil;
+import org.opendaylight.protocol.bgp.parser.spi.BGPExtensionConsumerContext;
import org.opendaylight.protocol.bgp.parser.spi.MessageUtil;
-import org.opendaylight.protocol.bgp.parser.spi.pojo.ServiceLoaderBGPExtensionProviderContext;
+import org.opendaylight.protocol.bgp.parser.spi.MultiPathSupport;
+import org.opendaylight.protocol.bgp.parser.spi.NlriRegistry;
+import org.opendaylight.protocol.bgp.parser.spi.PeerSpecificParserConstraint;
+import org.opendaylight.protocol.bgp.parser.spi.RevisedErrorHandlingSupport;
+import org.opendaylight.protocol.bgp.parser.spi.pojo.PeerSpecificParserConstraintImpl;
+import org.opendaylight.protocol.bgp.parser.spi.pojo.RevisedErrorHandlingSupportImpl;
+import org.opendaylight.protocol.bgp.util.HexDumpBGPFileParser;
import org.opendaylight.protocol.util.ByteArray;
import org.opendaylight.protocol.util.NoopReferenceCache;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.AsNumber;
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Address;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4AddressNoZone;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Prefix;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.Update;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.UpdateBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.Attributes;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.AttributesBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.Aggregator;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.AggregatorBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.AsPathBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.AtomicAggregateBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.Communities;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.ExtendedCommunities;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.ExtendedCommunitiesBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.LocalPrefBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.MultiExitDiscBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.OriginBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.as.path.Segments;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.as.path.SegmentsBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.update.message.Nlri;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.update.message.NlriBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.update.message.WithdrawnRoutesBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.Attributes2;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.BgpOrigin;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.Ipv6AddressFamily;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.UnicastSubsequentAddressFamily;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.extended.community.extended.community.RouteTargetIpv4CaseBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.extended.community.extended.community.route.target.ipv4._case.RouteTargetIpv4Builder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.Ipv4NextHopCase;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.Ipv4NextHopCaseBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.ipv4.next.hop._case.Ipv4NextHopBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.PathId;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.Update;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.UpdateBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.Attributes;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.AttributesBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.Aggregator;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.AggregatorBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.AsPathBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.AtomicAggregateBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.Communities;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.ExtendedCommunities;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.ExtendedCommunitiesBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.LocalPrefBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.MultiExitDiscBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.OriginBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.as.path.Segments;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.attributes.as.path.SegmentsBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.update.message.Nlri;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.update.message.NlriBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.update.message.WithdrawnRoutes;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.update.message.WithdrawnRoutesBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev180329.AttributesUnreach;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.AddressFamily;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.BgpOrigin;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.Ipv6AddressFamily;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.SubsequentAddressFamily;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.UnicastSubsequentAddressFamily;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.extended.community.extended.community.RouteTargetIpv4CaseBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.Ipv4NextHopCase;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.Ipv4NextHopCaseBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.ipv4.next.hop._case.Ipv4NextHopBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.route.target.ipv4.grouping.RouteTargetIpv4Builder;
+import org.opendaylight.yangtools.yang.common.Uint16;
+import org.opendaylight.yangtools.yang.common.Uint32;
public class BGPParserTest {
+ private static final List<byte[]> INPUT_BYTES = new ArrayList<>();
- /**
- * Used by other tests as well
- */
- static final List<byte[]> inputBytes = new ArrayList<>();
-
- private static int COUNTER = 7;
+ private static final int COUNTER = 8;
- private static int MAX_SIZE = 300;
+ private static final int MAX_SIZE = 300;
private static BGPUpdateMessageParser updateParser;
private static final int LENGTH_FIELD_LENGTH = 2;
+ private static final String MULTIPATH_HEX_FILE = "/bgp-update-multipath.txt";
+
+ private static List<byte[]> updatesWithMultiplePath;
+
+ private static PeerSpecificParserConstraint mpConstraint;
+
+ private static MultiPathSupport mpSupport;
+
@BeforeClass
public static void setUp() throws Exception {
- updateParser = new BGPUpdateMessageParser(ServiceLoaderBGPExtensionProviderContext.getSingletonInstance().getAttributeRegistry());
+ updateParser = new BGPUpdateMessageParser(ServiceLoader.load(BGPExtensionConsumerContext.class).findFirst()
+ .orElseThrow().getAttributeRegistry(), mock(NlriRegistry.class));
for (int i = 1; i <= COUNTER; i++) {
final String name = "/up" + i + ".bin";
- try (final InputStream is = BGPParserTest.class.getResourceAsStream(name)){
+ try (InputStream is = BGPParserTest.class.getResourceAsStream(name)) {
if (is == null) {
throw new IOException("Failed to get resource " + name);
}
final ByteArrayOutputStream bis = new ByteArrayOutputStream();
final byte[] data = new byte[MAX_SIZE];
- int nRead = 0;
- while ((nRead = is.read(data, 0, data.length)) != -1) {
- bis.write(data, 0, nRead);
+ int numRead = 0;
+ while ((numRead = is.read(data, 0, data.length)) != -1) {
+ bis.write(data, 0, numRead);
}
bis.flush();
- inputBytes.add(bis.toByteArray());
+ INPUT_BYTES.add(bis.toByteArray());
is.close();
}
}
+ updatesWithMultiplePath = HexDumpBGPFileParser.parseMessages(BGPParserTest.class.getResourceAsStream(
+ MULTIPATH_HEX_FILE));
+ mpConstraint = mock(PeerSpecificParserConstraint.class);
+ mpSupport = mock(MultiPathSupport.class);
+ doReturn(Optional.empty()).when(mpConstraint).getPeerConstraint(any());
+ doReturn(Optional.of(mpSupport)).when(mpConstraint).getPeerConstraint(MultiPathSupport.class);
+ doReturn(true).when(mpSupport).isTableTypeSupported(any());
}
-
@Test
public void testResource() {
- assertNotNull(inputBytes);
+ assertNotNull(INPUT_BYTES);
}
/*
@Test
public void testGetUpdateMessage1() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(0), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(0), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(0), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(0), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
// check fields
-
assertNull(message.getWithdrawnRoutes());
// attributes
- final List<AsNumber> asNumbers = new ArrayList<>();
- asNumbers.add(new AsNumber(65002L));
- final List<Segments> asPath = Lists.newArrayList();
- asPath.add(new SegmentsBuilder().setAsSequence(asNumbers).build());
-
final Ipv4NextHopCase nextHop = new Ipv4NextHopCaseBuilder().setIpv4NextHop(
- new Ipv4NextHopBuilder().setGlobal(new Ipv4Address("10.0.0.2")).build()).build();
+ new Ipv4NextHopBuilder().setGlobal(new Ipv4AddressNoZone("10.0.0.2")).build()).build();
- final List<Communities> comms = Lists.newArrayList();
+ final List<Communities> comms = new ArrayList<>();
comms.add((Communities) CommunityUtil.NO_EXPORT);
comms.add((Communities) CommunityUtil.NO_ADVERTISE);
comms.add((Communities) CommunityUtil.NO_EXPORT_SUBCONFED);
// check nlri
- final List<Ipv4Prefix> prefs = Lists.newArrayList();
- prefs.add(new Ipv4Prefix("172.17.2.0/24"));
- prefs.add(new Ipv4Prefix("172.17.1.0/24"));
- prefs.add(new Ipv4Prefix("172.17.0.0/24"));
-
- final Nlri nlri = new NlriBuilder().setNlri(prefs).build();
+ final List<Nlri> nlris = List.of(
+ new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.2.0/24")).build(),
+ new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.1.0/24")).build(),
+ new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.0.0/24")).build());
- assertEquals(nlri, message.getNlri());
+ assertEquals(nlris, message.getNlri());
- builder.setNlri(nlri);
+ builder.setNlri(nlris);
// check path attributes
paBuilder.setOrigin(new OriginBuilder().setValue(BgpOrigin.Igp).build());
assertEquals(paBuilder.getOrigin(), attrs.getOrigin());
- paBuilder.setAsPath(new AsPathBuilder().setSegments(asPath).build());
+ paBuilder.setAsPath(new AsPathBuilder()
+ .setSegments(List.of(new SegmentsBuilder()
+ .setAsSequence(List.of(new AsNumber(Uint32.valueOf(65002)))).build()))
+ .build());
assertEquals(paBuilder.getAsPath(), attrs.getAsPath());
paBuilder.setCNextHop(nextHop);
assertEquals(paBuilder.getCNextHop(), attrs.getCNextHop());
- paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed((long) 0).build());
+ paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed(Uint32.ZERO).build());
assertEquals(paBuilder.getMultiExitDisc(), attrs.getMultiExitDisc());
paBuilder.setAtomicAggregate(new AtomicAggregateBuilder().build());
paBuilder.setCommunities(comms);
assertEquals(paBuilder.getCommunities(), attrs.getCommunities());
- paBuilder.setUnrecognizedAttributes(Collections.emptyList());
+ paBuilder.setUnrecognizedAttributes(Map.of());
builder.setAttributes(paBuilder.build());
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(0), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(0), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testGetUpdateMessage3() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(2), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(2), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(2), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(2), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
final UpdateBuilder builder = new UpdateBuilder();
// check nlri
- final Ipv4Prefix pref1 = new Ipv4Prefix("172.16.0.0/21");
-
- final List<Ipv4Prefix> nlri = Lists.newArrayList(pref1);
- builder.setNlri(new NlriBuilder().setNlri(nlri).build());
+ final List<Nlri> nlris = List.of(new NlriBuilder().setPrefix(new Ipv4Prefix("172.16.0.0/21")).build());
+ builder.setNlri(nlris);
assertEquals(builder.getNlri(), message.getNlri());
// check fields
// attributes
final List<AsNumber> asNumbers = new ArrayList<>();
- asNumbers.add(new AsNumber(30L));
- final List<Segments> asPath = Lists.newArrayList();
+ asNumbers.add(new AsNumber(Uint32.valueOf(30)));
+ final List<Segments> asPath = new ArrayList<>();
asPath.add(new SegmentsBuilder().setAsSequence(asNumbers).build());
- final List<AsNumber> asSet = Lists.newArrayList(new AsNumber(10L), new AsNumber(20L));
+ final List<AsNumber> asSet = List.of(new AsNumber(Uint32.TEN), new AsNumber(Uint32.valueOf(20)));
asPath.add(new SegmentsBuilder().setAsSet(asSet).build());
- final Aggregator aggregator = new AggregatorBuilder().setAsNumber(new AsNumber((long) 30)).setNetworkAddress(
- new Ipv4Address("10.0.0.9")).build();
+ final Aggregator aggregator = new AggregatorBuilder().setAsNumber(new AsNumber(Uint32.valueOf(30)))
+ .setNetworkAddress(new Ipv4AddressNoZone("10.0.0.9")).build();
final Ipv4NextHopCase nextHop = new Ipv4NextHopCaseBuilder().setIpv4NextHop(
- new Ipv4NextHopBuilder().setGlobal(new Ipv4Address("10.0.0.9")).build()).build();
+ new Ipv4NextHopBuilder().setGlobal(new Ipv4AddressNoZone("10.0.0.9")).build()).build();
// check path attributes
final Attributes attrs = message.getAttributes();
paBuilder.setCNextHop(nextHop);
assertEquals(paBuilder.getCNextHop(), attrs.getCNextHop());
- paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed((long) 0).build());
+ paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed(Uint32.ZERO).build());
assertEquals(paBuilder.getMultiExitDisc(), attrs.getMultiExitDisc());
paBuilder.setAggregator(aggregator);
assertEquals(paBuilder.getAggregator(), attrs.getAggregator());
- paBuilder.setUnrecognizedAttributes(Collections.emptyList());
+ paBuilder.setUnrecognizedAttributes(Map.of());
builder.setAttributes(paBuilder.build());
assertEquals(builder.build(), message);
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(2), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(2), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testGetUpdateMessage4() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(3), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(3), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(3), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(3), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
final UpdateBuilder builder = new UpdateBuilder();
assertNull(message.getWithdrawnRoutes());
// check nlri
- final Ipv4Prefix pref1 = new Ipv4Prefix("10.30.3.0/24");
- final Ipv4Prefix pref2 = new Ipv4Prefix("10.30.2.0/24");
- final Ipv4Prefix pref3 = new Ipv4Prefix("10.30.1.0/24");
+ final List<Nlri> nlris = new ArrayList<>();
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("10.30.3.0/24")).build());
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("10.30.2.0/24")).build());
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("10.30.1.0/24")).build());
- final List<Ipv4Prefix> nlri = Lists.newArrayList(pref1, pref2, pref3);
- builder.setNlri(new NlriBuilder().setNlri(nlri).build());
- assertEquals(builder.getNlri(), message.getNlri());
+ assertEquals(nlris, message.getNlri());
+
+ builder.setNlri(nlris);
// attributes
final Ipv4NextHopCase nextHop = new Ipv4NextHopCaseBuilder().setIpv4NextHop(
- new Ipv4NextHopBuilder().setGlobal(new Ipv4Address("3.3.3.3")).build()).build();
-
- final List<ExtendedCommunities> comms = Lists.newArrayList();
- comms.add(new ExtendedCommunitiesBuilder().setTransitive(true).setExtendedCommunity(
- new RouteTargetIpv4CaseBuilder().setRouteTargetIpv4(
- new RouteTargetIpv4Builder().setGlobalAdministrator(
- new Ipv4Address("192.168.1.0")).setLocalAdministrator(4660).build()).build()).build());
+ new Ipv4NextHopBuilder().setGlobal(new Ipv4AddressNoZone("3.3.3.3")).build()).build();
+
+ final List<ExtendedCommunities> comms = new ArrayList<>();
+ comms.add(new ExtendedCommunitiesBuilder()
+ .setTransitive(true)
+ .setExtendedCommunity(new RouteTargetIpv4CaseBuilder()
+ .setRouteTargetIpv4(new RouteTargetIpv4Builder()
+ .setGlobalAdministrator(new Ipv4AddressNoZone("192.168.1.0"))
+ .setLocalAdministrator(Uint16.valueOf(4660))
+ .build())
+ .build())
+ .build());
// check path attributes
final Attributes attrs = message.getAttributes();
paBuilder.setOrigin(new OriginBuilder().setValue(BgpOrigin.Egp).build());
assertEquals(paBuilder.getOrigin(), attrs.getOrigin());
- paBuilder.setAsPath(new AsPathBuilder().setSegments(Collections.emptyList()).build());
+ paBuilder.setAsPath(new AsPathBuilder().setSegments(List.of()).build());
assertEquals(paBuilder.getAsPath(), attrs.getAsPath());
paBuilder.setCNextHop(nextHop);
assertEquals(paBuilder.getCNextHop(), attrs.getCNextHop());
- paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed((long) 0).build());
+ paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed(Uint32.ZERO).build());
assertEquals(paBuilder.getMultiExitDisc(), attrs.getMultiExitDisc());
- paBuilder.setLocalPref(new LocalPrefBuilder().setPref(100L).build());
+ paBuilder.setLocalPref(new LocalPrefBuilder().setPref(Uint32.valueOf(100)).build());
assertEquals(paBuilder.getLocalPref(), attrs.getLocalPref());
paBuilder.setExtendedCommunities(comms);
assertEquals(paBuilder.getExtendedCommunities(), attrs.getExtendedCommunities());
- paBuilder.setUnrecognizedAttributes(Collections.emptyList());
+ paBuilder.setUnrecognizedAttributes(Map.of());
// check API message
builder.setAttributes(paBuilder.build());
assertEquals(builder.build(), message);
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(3), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(3), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testGetUpdateMessage5() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(4), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(4), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(4), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(4), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
// attributes
- final List<Ipv4Prefix> prefs = Lists.newArrayList(new Ipv4Prefix("172.16.0.4/30"));
+ final List<WithdrawnRoutes> withdrawnRoutes = List.of(new WithdrawnRoutesBuilder()
+ .setPrefix(new Ipv4Prefix("172.16.0.4/30")).build());
// check API message
- final Update expectedMessage = new UpdateBuilder().setWithdrawnRoutes(
- new WithdrawnRoutesBuilder().setWithdrawnRoutes(prefs).build()).build();
+ final Update expectedMessage = new UpdateBuilder().setWithdrawnRoutes(withdrawnRoutes).build();
assertEquals(expectedMessage.getWithdrawnRoutes(), message.getWithdrawnRoutes());
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(4), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(4), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testEORIpv4() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(5), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(5), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(5), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(5), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
assertEquals(new UpdateBuilder().build(), message);
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(5), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(5), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testEORIpv6() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(6), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(6), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(6), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(6), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
- final Class<? extends AddressFamily> afi = message.getAttributes().getAugmentation(Attributes2.class).getMpUnreachNlri().getAfi();
- final Class<? extends SubsequentAddressFamily> safi = message.getAttributes().getAugmentation(Attributes2.class).getMpUnreachNlri().getSafi();
+ final Class<? extends AddressFamily> afi = message.getAttributes()
+ .augmentation(AttributesUnreach.class).getMpUnreachNlri().getAfi();
+ final Class<? extends SubsequentAddressFamily> safi = message.getAttributes()
+ .augmentation(AttributesUnreach.class).getMpUnreachNlri().getSafi();
assertEquals(Ipv6AddressFamily.class, afi);
assertEquals(UnicastSubsequentAddressFamily.class, safi);
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(6), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(6), ByteArray.readAllBytes(buffer));
}
/*
*/
@Test
public void testEORIpv6exLength() throws Exception {
- final byte[] body = ByteArray.cutBytes(inputBytes.get(6), MessageUtil.COMMON_HEADER_LENGTH);
- final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(inputBytes.get(6), MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
- final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength);
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(6), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(6), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ null);
- final Class<? extends AddressFamily> afi = message.getAttributes().getAugmentation(Attributes2.class).getMpUnreachNlri().getAfi();
- final Class<? extends SubsequentAddressFamily> safi = message.getAttributes().getAugmentation(Attributes2.class).getMpUnreachNlri().getSafi();
+ final Class<? extends AddressFamily> afi = message.getAttributes()
+ .augmentation(AttributesUnreach.class).getMpUnreachNlri().getAfi();
+ final Class<? extends SubsequentAddressFamily> safi = message.getAttributes()
+ .augmentation(AttributesUnreach.class).getMpUnreachNlri().getSafi();
assertEquals(Ipv6AddressFamily.class, afi);
assertEquals(UnicastSubsequentAddressFamily.class, safi);
final ByteBuf buffer = Unpooled.buffer();
BGPParserTest.updateParser.serializeMessage(message, buffer);
- assertArrayEquals(inputBytes.get(6), ByteArray.readAllBytes(buffer));
+ assertArrayEquals(INPUT_BYTES.get(6), ByteArray.readAllBytes(buffer));
+ }
+
+ /*
+ * Tests IPv4 NEXT_HOP, ATOMIC_AGGREGATE, COMMUNITY, NLRI with multiple paths.
+ *
+ * ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff <- marker
+ * 00 60 <- length (96) - including header
+ * 02 <- message type
+ * 00 00 <- withdrawn routes length
+ * 00 31 <- total path attribute length (49)
+ * 40 <- attribute flags
+ * 01 <- attribute type code (origin)
+ * 01 <- attribute length
+ * 00 <- Origin value (IGP)
+ * 40 <- attribute flags
+ * 02 <- attribute type code (as path)
+ * 06 <- attribute length
+ * 02 <- AS_SEQUENCE
+ * 01 <- path segment count
+ * 00 00 fd ea <- path segment value (65002)
+ * 40 <- attribute flags
+ * 03 <- attribute type code (Next Hop)
+ * 04 <- attribute length
+ * 0a 00 00 02 <- value (10.0.0.2)
+ * 80 <- attribute flags
+ * 04 <- attribute type code (multi exit disc)
+ * 04 <- attribute length
+ * 00 00 00 00 <- value
+ * 40 <- attribute flags
+ * 06 <- attribute type code (atomic aggregate)
+ * 00 <- attribute length
+ * C0 <- attribute flags
+ * 08 <- attribute type code (community)
+ * 10 <- attribute length
+ * FF FF FF 01 <- value (NO_EXPORT)
+ * FF FF FF 02 <- value (NO_ADVERTISE)
+ * FF FF FF 03 <- value (NO_EXPORT_SUBCONFED)
+ * FF FF FF 10 <- unknown Community
+ *
+ * //NLRI
+ * 00 00 00 01 <- path-id (1)
+ * 18 ac 11 02 <- IPv4 Prefix (172.17.1.0 / 24)
+ * 00 00 00 01 <- path-id (2)
+ * 18 ac 11 01 <- IPv4 Prefix (172.17.1.0 / 24)
+ * 00 00 00 01 <- path-id (1)
+ * 18 ac 11 00 <- IPv4 Prefix (172.17.0.0 / 24)
+ */
+ @Test
+ public void testUpdateMessageNlriAddPath() throws Exception {
+ final byte[] body = ByteArray.cutBytes(updatesWithMultiplePath.get(0), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(updatesWithMultiplePath.get(0),
+ MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ mpConstraint);
+
+ // check fields
+
+ assertNull(message.getWithdrawnRoutes());
+
+ // attributes
+ final List<AsNumber> asNumbers = new ArrayList<>();
+ asNumbers.add(new AsNumber(Uint32.valueOf(65002)));
+ final List<Segments> asPath = new ArrayList<>();
+ asPath.add(new SegmentsBuilder().setAsSequence(asNumbers).build());
+
+ final Ipv4NextHopCase nextHop = new Ipv4NextHopCaseBuilder().setIpv4NextHop(
+ new Ipv4NextHopBuilder().setGlobal(new Ipv4AddressNoZone("10.0.0.2")).build()).build();
+
+ final List<Communities> comms = new ArrayList<>();
+ comms.add((Communities) CommunityUtil.NO_EXPORT);
+ comms.add((Communities) CommunityUtil.NO_ADVERTISE);
+ comms.add((Communities) CommunityUtil.NO_EXPORT_SUBCONFED);
+ comms.add((Communities) CommunityUtil.create(NoopReferenceCache.getInstance(), 0xFFFF, 0xFF10));
+
+ final UpdateBuilder builder = new UpdateBuilder();
+
+ // check nlri
+
+ final List<Nlri> nlris = new ArrayList<>();
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.1.0/24")).setPathId(new PathId(Uint32.ONE))
+ .build());
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.1.0/24")).setPathId(new PathId(Uint32.TWO))
+ .build());
+ nlris.add(new NlriBuilder().setPrefix(new Ipv4Prefix("172.17.0.0/24")).setPathId(new PathId(Uint32.ONE))
+ .build());
+
+ assertEquals(nlris, message.getNlri());
+
+ builder.setNlri(nlris);
+
+ // check path attributes
+
+ final Attributes attrs = message.getAttributes();
+
+ final AttributesBuilder paBuilder = new AttributesBuilder();
+
+ paBuilder.setOrigin(new OriginBuilder().setValue(BgpOrigin.Igp).build());
+ assertEquals(paBuilder.getOrigin(), attrs.getOrigin());
+
+ paBuilder.setAsPath(new AsPathBuilder().setSegments(asPath).build());
+ assertEquals(paBuilder.getAsPath(), attrs.getAsPath());
+
+ paBuilder.setCNextHop(nextHop);
+ assertEquals(paBuilder.getCNextHop(), attrs.getCNextHop());
+
+ paBuilder.setMultiExitDisc(new MultiExitDiscBuilder().setMed(Uint32.ZERO).build());
+ assertEquals(paBuilder.getMultiExitDisc(), attrs.getMultiExitDisc());
+
+ paBuilder.setAtomicAggregate(new AtomicAggregateBuilder().build());
+ assertEquals(paBuilder.getAtomicAggregate(), attrs.getAtomicAggregate());
+
+ paBuilder.setCommunities(comms);
+ assertEquals(paBuilder.getCommunities(), attrs.getCommunities());
+
+ paBuilder.setUnrecognizedAttributes(Map.of());
+
+ builder.setAttributes(paBuilder.build());
+
+ assertEquals(builder.build(), message);
+
+ final ByteBuf buffer = Unpooled.buffer();
+ BGPParserTest.updateParser.serializeMessage(message, buffer);
+ assertArrayEquals(updatesWithMultiplePath.get(0), ByteArray.readAllBytes(buffer));
+ }
+
+ /*
+ * Tests withdrawn routes with multiple paths.
+ *
+ * ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff <- marker
+ * 00 29 <- length (41) - including header
+ * 02 <- message type
+ * 00 12 <- withdrawn routes length (18)
+ * 00 00 00 01 <- path-id (1)
+ * 1e ac 10 00 04 <- route (172.16.0.4)
+ * 00 00 00 02 <- path-id (2)
+ * 1e ac 10 00 04 <- route (172.16.0.4)
+ * 00 00 <- total path attribute length
+ *
+ */
+ @Test
+ public void testUpdateMessageWithdrawAddPath() throws Exception {
+ final byte[] body = ByteArray.cutBytes(updatesWithMultiplePath.get(1), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(updatesWithMultiplePath.get(1),
+ MessageUtil.MARKER_LENGTH, LENGTH_FIELD_LENGTH));
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ mpConstraint);
+
+ // attributes
+ final List<WithdrawnRoutes> withdrawnRoutes = new ArrayList<>();
+ withdrawnRoutes.add(new WithdrawnRoutesBuilder().setPrefix(new Ipv4Prefix("172.16.0.4/30"))
+ .setPathId(new PathId(Uint32.ONE)).build());
+ withdrawnRoutes.add(new WithdrawnRoutesBuilder().setPrefix(new Ipv4Prefix("172.16.0.4/30"))
+ .setPathId(new PathId(Uint32.TWO)).build());
+
+ // check API message
+ final Update expectedMessage = new UpdateBuilder().setWithdrawnRoutes(withdrawnRoutes).build();
+
+ assertEquals(expectedMessage.getWithdrawnRoutes(), message.getWithdrawnRoutes());
+
+ final ByteBuf buffer = Unpooled.buffer();
+ BGPParserTest.updateParser.serializeMessage(message, buffer);
+ assertArrayEquals(updatesWithMultiplePath.get(1), ByteArray.readAllBytes(buffer));
+ }
+
+ /*
+ * Tests withdrawn routes with malformed attribute.
+ *
+ * ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff <- marker
+ * 00 35 <- length (53) - including header
+ * 02 <- message type
+ * 00 00 <- withdrawn routes length
+ * 00 1a <- total path attribute length (26)
+ * 40 <- attribute flags
+ * 01 <- attribute type code (origin)
+ * 02 <- WRONG attribute length
+ * 00 <- Origin value (IGP)
+ * 40 <- attribute flags
+ * 03 <- attribute type code (Next Hop)
+ * 04 <- attribute length
+ * 0a 00 00 02 <- value (10.0.0.2)
+ * 40 <- attribute flags
+ * 0e <- attribute type code (MP_REACH)
+ * 00 01 <- AFI (Ipv4)
+ * 01 <- SAFI (Unicast)
+ * 04 <- next hop length
+ * ff ff ff ff <- next hop
+ * 00 <- reserved
+ * 18 <- length
+ * 0a 00 01 <- prefix (10.0.1.0)
+ * //NLRI
+ * 18 <- length
+ * 0a 00 02 <- prefix (10.0.2.0)
+ */
+ @Test
+ public void testUpdateMessageWithMalformedAttribute() throws BGPDocumentedException {
+ final byte[] body = ByteArray.cutBytes(INPUT_BYTES.get(7), MessageUtil.COMMON_HEADER_LENGTH);
+ final int messageLength = ByteArray.bytesToInt(ByteArray.subByte(INPUT_BYTES.get(6), MessageUtil.MARKER_LENGTH,
+ LENGTH_FIELD_LENGTH));
+ final PeerSpecificParserConstraintImpl constraint = new PeerSpecificParserConstraintImpl();
+ constraint.addPeerConstraint(RevisedErrorHandlingSupport.class,
+ RevisedErrorHandlingSupportImpl.forExternalPeer());
+ final Update message = BGPParserTest.updateParser.parseMessageBody(Unpooled.copiedBuffer(body), messageLength,
+ constraint);
+ assertNotNull(message);
+ assertNull(message.getNlri());
+ final List<WithdrawnRoutes> withdrawnRoutes = message.getWithdrawnRoutes();
+ assertNotNull(withdrawnRoutes);
+ assertEquals(1, withdrawnRoutes.size());
}
}
Code Review / bgpcep.git / blobdiff