Fix findbug and checkstyle issues

[bgpcep.git] / bgp / parser-spi / src / main / java / org / opendaylight / protocol / bgp / parser / spi / PathIdUtil.java

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/PathIdUtil.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/PathIdUtil.java
index cca87d6bc7ddd23b8a0970a241c3237f3dd53176..9fe8c3204426569372b1346d46f09be23917fcd6 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/PathIdUtil.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/PathIdUtil.java
@@ -70,22 +70,23 @@ public final class PathIdUtil {
     }
 
     /**
-     * Create a Add Path PathArgument Key(prefix+pathId)
+     * Create a Add Path PathArgument Key(prefix+pathId).
      *
-     * @param pathId Path Id value
-     * @param routeId Route Id value
-     * @param routeQname route QName provided per each RibSupport
-     * @param pathidQname Path Id QName provided per each RibSupport
+     * @param pathId        Path Id value
+     * @param routeId       Route Id value
+     * @param routeQname    route QName provided per each RibSupport
+     * @param pathidQname   Path Id QName provided per each RibSupport
      * @param routeKeyQname Prefix QName provided per each RibSupport
      * @return Route Key Nid
      */
-    public static PathArgument createNidKey(final long pathId, final PathArgument routeId, final QName routeQname, final QName pathidQname,
-        final QName routeKeyQname) {
-        return createNodeIdentifierWithPredicates(routeQname, pathidQname, pathId, routeKeyQname, getObjectKey(routeId, routeKeyQname));
+    public static NodeIdentifierWithPredicates createNidKey(final long pathId, final PathArgument routeId,
+        final QName routeQname, final QName pathidQname, final QName routeKeyQname) {
+        return createNodeIdentifierWithPredicates(routeQname, pathidQname, pathId, routeKeyQname,
+            getObjectKey(routeId, routeKeyQname));
     }
 
     /**
-     * Get route key object ( prefgit stat  ix / key-value/ .. )
+     * Get route key object ( prefgit stat  ix / key-value/ .. ).
      *
      * @param routeId PathArgument containing the key
      * @param routeKeyQname routeKey Qname
@@ -95,37 +96,40 @@ public final class PathIdUtil {
         return (((NodeIdentifierWithPredicates) routeId).getKeyValues()).get(routeKeyQname);
     }
 
-    public static NodeIdentifierWithPredicates createNodeIdentifierWithPredicates(final QName routeQname, final QName pathidQname, final Object pathId,
-        final QName routeKeyQname, final Object keyObject) {
+    public static NodeIdentifierWithPredicates createNodeIdentifierWithPredicates(final QName routeQname,
+        final QName pathidQname, final Object pathId, final QName routeKeyQname, final Object keyObject) {
         final ImmutableMap<QName, Object> keyValues = ImmutableMap.of(pathidQname, pathId, routeKeyQname, keyObject);
         return new NodeIdentifierWithPredicates(routeQname, keyValues);
     }
 
     /**
-     * Build Path Id
+     * Build Path Id.
      *
      * @param routesCont route container
      * @param pathIdNii path Id node Identifier
      * @return PathId or null in case is not the container
      */
-    public static PathId buildPathId(final DataContainerNode<? extends PathArgument> routesCont, final NodeIdentifier pathIdNii) {
+    public static PathId buildPathId(final DataContainerNode<? extends PathArgument> routesCont,
+            final NodeIdentifier pathIdNii) {
         final Long pathIdVal = PathIdUtil.extractPathId(routesCont, pathIdNii);
         return pathIdVal == null ? null : new PathId(pathIdVal);
     }
 
     /**
-     * Build Route Key for supporting mp
-     * Key is composed by 2 elements (route-key + path Id)
+     * Build Route Key for supporting mp.
+     * Key is composed by 2 elements (route-key + path Id).
      *
      * @param routeQname route Qname
      * @param routeKeyQname route key Qname
      * @param pathIdQname path Id Qname
      * @param routeKeyValue route key value
-     * @param maybePathIdLeaf path id container, it might me supported or not, in that case default 0 value will be assigned
+     * @param maybePathIdLeaf path id container, it might me supported or not, in that case default 0 value will
+     * be assigned
      * @return Route Key Nid
      */
-    public static NodeIdentifierWithPredicates createNidKey(final QName routeQname, final QName routeKeyQname, final QName pathIdQname,
-        final Object routeKeyValue, final Optional<DataContainerChild<? extends PathArgument, ?>> maybePathIdLeaf) {
+    public static NodeIdentifierWithPredicates createNidKey(final QName routeQname, final QName routeKeyQname,
+            final QName pathIdQname, final Object routeKeyValue,
+            final Optional<DataContainerChild<? extends PathArgument, ?>> maybePathIdLeaf) {
         // FIXME: a cache here would mean we instantiate the same identifier for each route making comparison quicker.
         final Object pathId = maybePathIdLeaf.isPresent() ? (maybePathIdLeaf.get()).getValue() : NON_PATH_ID;
         return createNodeIdentifierWithPredicates(routeQname, pathIdQname, pathId, routeKeyQname, routeKeyValue);