Fix an eclipse nullness warning

[bgpcep.git] / bgp / rib-impl / src / main / java / org / opendaylight / protocol / bgp / rib / impl / LocRibWriter.java

diff --git a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/LocRibWriter.java b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/LocRibWriter.java
index 30f89b32f5953596feea192c27cc66b75d2f9d2e..5e03801026c463677e885be523ace22a1951405b 100644 (file)
--- a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/LocRibWriter.java
+++ b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/LocRibWriter.java
@@ -261,7 +261,6 @@ final class LocRibWriter<C extends Routes & DataObject & ChoiceIn<Tables>, S ext
         return ret;
     }
 
-    @SuppressWarnings("unchecked")
     private void updateNodes(
             final DataObjectModification<Tables> table,
             final UnsignedInteger peerUuid,
@@ -271,14 +270,16 @@ final class LocRibWriter<C extends Routes & DataObject & ChoiceIn<Tables>, S ext
 
         final DataObjectModification<Attributes> attUpdate = table.getModifiedChildContainer(Attributes.class);
 
-        if (attUpdate != null && attUpdate.getDataAfter() != null) {
+        if (attUpdate != null) {
             final Attributes newAttValue = attUpdate.getDataAfter();
-            LOG.trace("Uptodate found for {}", newAttValue);
-            tx.put(LogicalDatastoreType.OPERATIONAL, this.locRibTableIID.child(Attributes.class), newAttValue);
+            if (newAttValue != null) {
+                LOG.trace("Uptodate found for {}", newAttValue);
+                tx.put(LogicalDatastoreType.OPERATIONAL, this.locRibTableIID.child(Attributes.class), newAttValue);
+            }
         }
 
-        final DataObjectModification routesChangesContainer
-                = table.getModifiedChildContainer((Class) this.ribSupport.routesContainerClass());
+        final DataObjectModification<S> routesChangesContainer
+                = table.getModifiedChildContainer(ribSupport.routesCaseClass(), ribSupport.routesContainerClass());
         if (routesChangesContainer == null) {
             return;
         }
@@ -286,11 +287,11 @@ final class LocRibWriter<C extends Routes & DataObject & ChoiceIn<Tables>, S ext
     }
 
     private void updateRoutesEntries(
-            final Collection<DataObjectModification<? extends DataObject>> routeChanges,
+            final Collection<? extends DataObjectModification<? extends DataObject>> collection,
             final UnsignedInteger routerId,
             final Map<RouteUpdateKey, RouteEntry<C,S,R,I>> routes
     ) {
-        for (final DataObjectModification<? extends DataObject> route : routeChanges) {
+        for (final DataObjectModification<? extends DataObject> route : collection) {
             final R newRoute = (R) route.getDataAfter();
             final R oldRoute = (R) route.getDataBefore();
             String routeKey;