import static org.junit.Assert.assertSame;
import static org.junit.Assert.fail;
+import com.google.common.base.Optional;
+import com.google.common.collect.Lists;
+import com.google.common.util.concurrent.Futures;
import java.net.InetSocketAddress;
import java.util.Collections;
+import java.util.List;
import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
import org.opendaylight.protocol.bgp.parser.BGPDocumentedException;
import org.opendaylight.protocol.bgp.parser.BGPError;
import org.opendaylight.protocol.bgp.rib.impl.spi.BGPSessionPreferences;
-import org.opendaylight.protocol.bgp.rib.impl.spi.ReusableBGPPeer;
+import org.opendaylight.protocol.bgp.rib.impl.spi.PeerRegistrySessionListener;
import org.opendaylight.protocol.bgp.rib.spi.BGPSessionListener;
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.AsNumber;
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress;
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Address;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.AsNumber;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Address;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.Open;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.OpenBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.message.BgpParameters;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.message.BgpParametersBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.message.bgp.parameters.OptionalCapabilitiesBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.message.bgp.parameters.optional.capabilities.CParametersBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.message.bgp.parameters.optional.capabilities.c.parameters.As4BytesCapabilityBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.BgpId;
public class StrictBGPPeerRegistryTest {
- private StrictBGPPeerRegistry droppingBGPSessionRegistry;
+ private static final AsNumber LOCAL_AS = new AsNumber(1234L);
+ private static final AsNumber REMOTE_AS = new AsNumber(1235L);
+ private static final Ipv4Address FROM = new Ipv4Address("0.0.0.1");
+ private static final IpAddress REMOTE_IP = new IpAddress(FROM);
+ private static final Ipv4Address TO = new Ipv4Address("255.255.255.255");
+
+ private final BGPSessionListener peer1 = getMockSession();
+ private final Open classicOpen = createOpen(TO, LOCAL_AS);
+ private StrictBGPPeerRegistry peerRegistry;
private BGPSessionPreferences mockPreferences;
- private final AsNumber AS1 = new AsNumber(1234L);
+
+ private static Open createOpen(final Ipv4Address bgpId, final AsNumber as) {
+ final List<BgpParameters> params = Lists.newArrayList(new BgpParametersBuilder()
+ .setOptionalCapabilities(Lists.newArrayList(new OptionalCapabilitiesBuilder()
+ .setCParameters(new CParametersBuilder()
+ .setAs4BytesCapability(new As4BytesCapabilityBuilder().setAsNumber(as).build()).build()).build())).build());
+ return new OpenBuilder().setBgpIdentifier(bgpId).setBgpParameters(params).build();
+ }
+
@Before
public void setUp() throws Exception {
- this.droppingBGPSessionRegistry = new StrictBGPPeerRegistry();
- this.mockPreferences = getMockPreferences();
+ this.peerRegistry = new StrictBGPPeerRegistry();
+ this.mockPreferences = new BGPSessionPreferences(LOCAL_AS, 1, new BgpId("0.0.0.1"), LOCAL_AS, Collections.emptyList(),
+ Optional.absent());
+ }
+
+ private static BGPSessionListener getMockSession() {
+ final BGPSessionListener mock = Mockito.mock(BGPSessionListener.class);
+ Mockito.doReturn(Futures.immediateFuture(null)).when(mock).releaseConnection();
+ return mock;
+ }
+
+ private static PeerRegistrySessionListener getMockSessionListener() {
+ final PeerRegistrySessionListener mock = Mockito.mock(PeerRegistrySessionListener.class);
+ Mockito.doNothing().when(mock).onSessionCreated(Mockito.any(IpAddress.class));
+ Mockito.doNothing().when(mock).onSessionRemoved(Mockito.any(IpAddress.class));
+ return mock;
}
@Test
}
@Test
- public void testDuplicate() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
-
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
-
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
+ public void testDuplicatePeerConnection() throws Exception {
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
} catch (final BGPDocumentedException e) {
assertEquals(BGPError.CEASE, e.getError());
return;
}
-
fail("Same peer cannot be connected twice");
}
@Test
- public void testNotAllowed() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
-
+ public void testPeerNotConfigured() throws Exception {
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
} catch (final IllegalStateException e) {
return;
}
}
@Test
- public void testOk() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
-
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
- final IpAddress remoteIp = new IpAddress(to);
+ public void testPeerConnectionSuccessfull() throws Exception {
final Ipv4Address to2 = new Ipv4Address("255.255.255.254");
final IpAddress remoteIp2 = new IpAddress(to2);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
- final ReusableBGPPeer session2 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp2, session2, this.mockPreferences);
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
+ final BGPSessionListener session2 = getMockSession();
+ this.peerRegistry.addPeer(remoteIp2, session2, this.mockPreferences);
- final BGPSessionListener returnedSession1 = this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
- assertSame(session1, returnedSession1);
- final BGPSessionListener returnedSession2 = this.droppingBGPSessionRegistry.getPeer(remoteIp2, from, to2, AS1);
+ final BGPSessionListener returnedSession1 = this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
+ assertSame(this.peer1, returnedSession1);
+ final BGPSessionListener returnedSession2 = this.peerRegistry.getPeer(remoteIp2, FROM, to2, this.classicOpen);
assertSame(session2, returnedSession2);
- Mockito.verifyZeroInteractions(session1);
+ Mockito.verifyZeroInteractions(this.peer1);
Mockito.verifyZeroInteractions(session2);
}
@Test
- public void testDropSecond() throws Exception {
+ public void testDropSecondPeer() throws Exception {
final Ipv4Address higher = new Ipv4Address("192.168.200.200");
final Ipv4Address lower = new Ipv4Address("10.10.10.10");
final IpAddress remoteIp = new IpAddress(lower);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
+ this.peerRegistry.addPeer(remoteIp, this.peer1, this.mockPreferences);
- this.droppingBGPSessionRegistry.getPeer(remoteIp, higher, lower, AS1);
+ this.peerRegistry.getPeer(remoteIp, higher, lower, createOpen(lower, LOCAL_AS));
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, lower, higher, AS1);
+ this.peerRegistry.getPeer(remoteIp, lower, higher, createOpen(higher, LOCAL_AS));
} catch (final BGPDocumentedException e) {
assertEquals(BGPError.CEASE, e.getError());
return;
}
-
fail("Same peer cannot be connected twice");
}
@Test
- public void testDropFirst() throws Exception {
+ public void testDropFirstPeer() throws Exception {
final Ipv4Address higher = new Ipv4Address("123.123.123.123");
final Ipv4Address lower = new Ipv4Address("123.123.123.122");
final IpAddress remoteIp = new IpAddress(lower);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
+ this.peerRegistry.addPeer(remoteIp, this.peer1, this.mockPreferences);
- this.droppingBGPSessionRegistry.getPeer(remoteIp, lower, higher, AS1);
- this.droppingBGPSessionRegistry.getPeer(remoteIp, higher, lower, AS1);
- Mockito.verify(session1).releaseConnection();
+ this.peerRegistry.getPeer(remoteIp, lower, higher, createOpen(higher, LOCAL_AS));
+ this.peerRegistry.getPeer(remoteIp, higher, lower, createOpen(lower, LOCAL_AS));
+ Mockito.verify(this.peer1).releaseConnection();
}
@Test
- public void testDuplicateDifferentIds() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
+ public void testDuplicatePeersWDifferentIds() throws Exception {
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
-
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, to, to, AS1);
+ this.peerRegistry.getPeer(REMOTE_IP, TO, TO, this.classicOpen);
} catch (final BGPDocumentedException e) {
assertEquals(BGPError.CEASE, e.getError());
return;
}
-
fail("Same peer cannot be connected twice");
}
@Test
- public void testDuplicateHigerAs() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
- final AsNumber as2 = new AsNumber(1235L);
+ public void testDuplicatePeersHigherAs() throws Exception {
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
-
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, as2);
- Mockito.verify(session1).releaseConnection();
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, createOpen(TO, REMOTE_AS));
+ Mockito.verify(this.peer1).releaseConnection();
}
@Test
- public void testDuplicateLowerAs() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
+ public void testDuplicatePeersLowerAs() throws Exception {
final AsNumber as2 = new AsNumber(3L);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, AS1);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, as2);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, createOpen(TO, as2));
} catch (final BGPDocumentedException e) {
assertEquals(BGPError.CEASE, e.getError());
return;
}
-
fail("Same peer cannot be connected twice");
}
@Test
public void testAsMismatch() throws Exception {
- final Ipv4Address from = new Ipv4Address("0.0.0.1");
- final IpAddress remoteIp = new IpAddress(from);
- final Ipv4Address to = new Ipv4Address("255.255.255.255");
final AsNumber as2 = new AsNumber(3L);
- final ReusableBGPPeer session1 = getMockSession();
- this.droppingBGPSessionRegistry.addPeer(remoteIp, session1, this.mockPreferences);
-
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
try {
- this.droppingBGPSessionRegistry.getPeer(remoteIp, from, to, as2);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, createOpen(TO, as2));
} catch (final BGPDocumentedException e) {
assertEquals(BGPError.BAD_PEER_AS, e.getError());
return;
}
-
fail("Peer AS number mismatch");
}
- private ReusableBGPPeer getMockSession() {
- final ReusableBGPPeer mock = Mockito.mock(ReusableBGPPeer.class);
- Mockito.doNothing().when(mock).releaseConnection();
- return mock;
+ @Test
+ public void testRegisterPeerSessionListener() throws Exception {
+ final PeerRegistrySessionListener sessionListener1 = getMockSessionListener();
+ this.peerRegistry.registerPeerSessionListener(sessionListener1);
+
+ final PeerRegistrySessionListener sessionListener2 = getMockSessionListener();
+ this.peerRegistry.registerPeerSessionListener(sessionListener2);
+
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
+ Mockito.verify(sessionListener1, Mockito.times(1)).onSessionCreated(REMOTE_IP);
+ Mockito.verify(sessionListener2, Mockito.times(1)).onSessionCreated(REMOTE_IP);
+
+ this.peerRegistry.removePeerSession(REMOTE_IP);
+ Mockito.verify(sessionListener1, Mockito.times(1)).onSessionRemoved(REMOTE_IP);
+ Mockito.verify(sessionListener2, Mockito.times(1)).onSessionRemoved(REMOTE_IP);
}
- public BGPSessionPreferences getMockPreferences() {
- return new BGPSessionPreferences(AS1, 1, new Ipv4Address("0.0.0.1"), Collections.<BgpParameters>emptyList());
+ @Test
+ public void testClosePeerSessionOneListener() throws Exception {
+ final PeerRegistrySessionListener sessionListener1 = getMockSessionListener();
+ final AutoCloseable registration1 = this.peerRegistry.registerPeerSessionListener(sessionListener1);
+
+ final PeerRegistrySessionListener sessionListener2 = getMockSessionListener();
+ this.peerRegistry.registerPeerSessionListener(sessionListener2);
+
+ this.peerRegistry.addPeer(REMOTE_IP, this.peer1, this.mockPreferences);
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
+ this.peerRegistry.removePeerSession(REMOTE_IP);
+
+ registration1.close();
+ this.peerRegistry.getPeer(REMOTE_IP, FROM, TO, this.classicOpen);
+ this.peerRegistry.removePeerSession(REMOTE_IP);
+
+ Mockito.verify(sessionListener1, Mockito.times(1)).onSessionCreated(REMOTE_IP);
+ Mockito.verify(sessionListener2, Mockito.times(2)).onSessionCreated(REMOTE_IP);
+ Mockito.verify(sessionListener1, Mockito.times(1)).onSessionRemoved(REMOTE_IP);
+ Mockito.verify(sessionListener2, Mockito.times(2)).onSessionRemoved(REMOTE_IP);
}
-}
\ No newline at end of file
+}
Code Review / bgpcep.git / blobdiff