* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.protocol.bgp.rib.impl.config;
-import static junit.framework.TestCase.fail;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyInt;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
-import java.math.BigDecimal;
import java.net.InetSocketAddress;
-import java.util.Collections;
-import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
import org.junit.Before;
import org.junit.Test;
-import org.mockito.Mockito;
-import org.opendaylight.controller.sal.binding.api.RpcProviderRegistry;
-import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonService;
+import org.opendaylight.mdsal.binding.api.RpcProviderService;
+import org.opendaylight.protocol.bgp.rib.impl.state.BGPStateCollector;
import org.opendaylight.protocol.concepts.KeyMapping;
import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.multiprotocol.rev151009.bgp.common.afi.safi.list.AfiSafi;
import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.multiprotocol.rev151009.bgp.common.afi.safi.list.AfiSafiBuilder;
+import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.multiprotocol.rev151009.bgp.common.afi.safi.list.AfiSafiKey;
import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbor.group.AddPaths;
import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbor.group.AddPathsBuilder;
import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbor.group.AfiSafis;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Address;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.PortNumber;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.AfiSafi1;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.AfiSafi1Builder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.Config1;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.Config1Builder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev180329.network.instance.protocol.NeighborAddPathsConfigBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev180329.network.instance.protocol.NeighborTransportConfigBuilder;
+import org.opendaylight.yangtools.yang.common.Decimal64;
+import org.opendaylight.yangtools.yang.common.Uint16;
+import org.opendaylight.yangtools.yang.common.Uint8;
public class BgpPeerTest extends AbstractConfig {
- static final short SHORT = 0;
+ static final Uint8 SHORT = Uint8.ZERO;
static final IpAddress NEIGHBOR_ADDRESS = new IpAddress(new Ipv4Address("127.0.0.1"));
- static final BigDecimal DEFAULT_TIMERS = BigDecimal.valueOf(30);
static final String MD5_PASSWORD = "123";
- static final PortNumber PORT = new PortNumber(179);
+ static final PortNumber PORT = new PortNumber(Uint16.valueOf(179));
static final AfiSafi AFI_SAFI_IPV4 = new AfiSafiBuilder().setAfiSafiName(IPV4UNICAST.class)
- .addAugmentation(AfiSafi1.class, new AfiSafi1Builder().setReceive(true).setSendMax(SHORT).build()).build();
- static final List<AfiSafi> AFI_SAFI = Collections.singletonList(AFI_SAFI_IPV4);
+ .addAugmentation(new NeighborAddPathsConfigBuilder().setReceive(true).setSendMax(Uint8.ZERO).build())
+ .build();
+ static final Map<AfiSafiKey, AfiSafi> AFI_SAFI = Map.of(AFI_SAFI_IPV4.key(), AFI_SAFI_IPV4);
+ private static final Decimal64 DEFAULT_TIMERS = Decimal64.valueOf(2, 30);
private BgpPeer bgpPeer;
static Neighbor createNeighborExpected(final IpAddress neighborAddress) {
}
static Transport createTransport() {
- return new TransportBuilder().setConfig(new org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp
- .rev151009.bgp.neighbor.group.transport.ConfigBuilder().setMtuDiscovery(false).setPassiveMode(false)
- .addAugmentation(Config1.class, new Config1Builder().setRemotePort(PORT).build()).build()).build();
+ return new TransportBuilder().setConfig(new org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009
+ .bgp.neighbor.group.transport.ConfigBuilder()
+ .setMtuDiscovery(false)
+ .setPassiveMode(false)
+ .addAugmentation(new NeighborTransportConfigBuilder().setRemotePort(PORT).build())
+ .build())
+ .build();
}
static Timers createTimers() {
return new TimersBuilder().setConfig(new org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009
- .bgp.neighbor.group.timers.ConfigBuilder().setHoldTime(DEFAULT_TIMERS)
+ .bgp.neighbor.group.timers.ConfigBuilder()
+ .setHoldTime(DEFAULT_TIMERS)
.setMinimumAdvertisementInterval(DEFAULT_TIMERS)
- .setKeepaliveInterval(DEFAULT_TIMERS).setConnectRetry(DEFAULT_TIMERS).build()).build();
+ .setKeepaliveInterval(DEFAULT_TIMERS)
+ .setConnectRetry(DEFAULT_TIMERS).build()).build();
}
- static RouteReflector createRR() {
+ private static RouteReflector createRR() {
return new RouteReflectorBuilder().setConfig(new org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp
.rev151009.bgp.neighbor.group.route.reflector.ConfigBuilder()
.setRouteReflectorClusterId(RrClusterIdTypeBuilder.getDefaultInstance("127.0.0.1"))
static Config createConfig() {
return new org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbor.group
- .ConfigBuilder().setPeerAs(AS).setPeerType(PeerType.INTERNAL).setAuthPassword(MD5_PASSWORD)
- .setRouteFlapDamping(false).setSendCommunity(CommunityType.NONE).build();
+ .ConfigBuilder()
+ .setPeerAs(AS)
+ .setLocalAs(LOCAL_AS)
+ .setPeerType(PeerType.INTERNAL)
+ .setAuthPassword(MD5_PASSWORD)
+ .setRouteFlapDamping(false)
+ .setSendCommunity(CommunityType.NONE).build();
}
static AfiSafis createAfiSafi() {
@Before
public void setUp() throws Exception {
super.setUp();
- this.bgpPeer = new BgpPeer(Mockito.mock(RpcProviderRegistry.class));
- Mockito.doNothing().when(this.serviceRegistration).unregister();
+ bgpPeer = new BgpPeer(mock(RpcProviderService.class), new BGPStateCollector());
}
@Test
- public void testBgpPeer() throws Exception {
- final Neighbor neighbor = new NeighborBuilder().setAfiSafis(createAfiSafi()).setConfig(createConfig())
- .setNeighborAddress(NEIGHBOR_ADDRESS).setRouteReflector(createRR()).setTimers(createTimers())
- .setTransport(createTransport()).setAddPaths(createAddPath()).build();
-
- this.bgpPeer.start(this.rib, neighbor, this.tableTypeRegistry);
- Mockito.verify(this.rib).createPeerChain(any());
- Mockito.verify(this.rib, times(2)).getLocalAs();
- Mockito.verify(this.rib).getLocalTables();
- Mockito.verify(this.rib).getRibIServiceGroupIdentifier();
- Mockito.verify(this.rib).registerClusterSingletonService(any(ClusterSingletonService.class));
-
- this.singletonService.instantiateServiceInstance();
- Mockito.verify(this.bgpPeerRegistry).addPeer(any(), any(), any());
- Mockito.verify(this.dispatcher).createReconnectingClient(any(InetSocketAddress.class),
- anyInt(), any(KeyMapping.class));
-
- try {
- this.bgpPeer.start(this.rib, neighbor, this.tableTypeRegistry);
- fail("Expected Exception");
- } catch (final IllegalStateException expected) {
- assertEquals("Previous peer instance was not closed.", expected.getMessage());
- }
- this.bgpPeer.setServiceRegistration(this.serviceRegistration);
- this.bgpPeer.close();
- Mockito.verify(this.singletonServiceRegistration).close();
- Mockito.verify(this.future).cancel(true);
-
- this.bgpPeer.restart(this.rib, this.tableTypeRegistry);
- Mockito.verify(this.rib, times(2)).createPeerChain(any());
- Mockito.verify(this.rib, times(4)).getLocalAs();
- Mockito.verify(this.rib, times(2)).getLocalTables();
- Mockito.verify(this.rib, times(2)).getRibIServiceGroupIdentifier();
- Mockito.verify(this.rib, times(2)).registerClusterSingletonService(any(ClusterSingletonService.class));
- this.singletonService.instantiateServiceInstance();
+ public void testBgpPeer() throws ExecutionException, InterruptedException {
+ final Neighbor neighbor = new NeighborBuilder()
+ .setAfiSafis(createAfiSafi())
+ .setConfig(createConfig())
+ .setNeighborAddress(NEIGHBOR_ADDRESS)
+ .setRouteReflector(createRR())
+ .setTimers(createTimers())
+ .setTransport(createTransport())
+ .setAddPaths(createAddPath())
+ .build();
+
+ bgpPeer.start(rib, neighbor, null, peerGroupLoader, tableTypeRegistry);
+ verify(rib).createPeerDOMChain(any());
+ verify(rib, times(2)).getLocalAs();
+ verify(rib).getLocalTables();
+
+ bgpPeer.instantiateServiceInstance();
+ verify(bgpPeerRegistry).addPeer(any(), any(), any());
+ verify(dispatcher).createReconnectingClient(any(InetSocketAddress.class), any(), anyInt(),
+ any(KeyMapping.class));
+
+ final var ex = assertThrows(IllegalStateException.class,
+ () -> bgpPeer.start(rib, neighbor, null, peerGroupLoader, tableTypeRegistry));
+ assertEquals("Previous peer instance was not closed.", ex.getMessage());
+ bgpPeer.closeServiceInstance();
+ verify(bgpPeerRegistry).removePeer(any());
+ verify(future).cancel(true);
+ bgpPeer.stop().get();
+ bgpPeer.start(rib, bgpPeer.getCurrentConfiguration(), null, peerGroupLoader, tableTypeRegistry);
+ bgpPeer.instantiateServiceInstance();
+ verify(rib, times(2)).createPeerDOMChain(any());
+ verify(rib, times(4)).getLocalAs();
+ verify(rib, times(2)).getLocalTables();
+ verify(bgpPeerRegistry, times(2)).addPeer(any(), any(), any());
+ verify(dispatcher, times(2)).createReconnectingClient(any(InetSocketAddress.class), any(), anyInt(),
+ any(KeyMapping.class));
final Neighbor neighborExpected = createNeighborExpected(NEIGHBOR_ADDRESS);
- assertTrue(this.bgpPeer.containsEqualConfiguration(neighborExpected));
- assertFalse(this.bgpPeer.containsEqualConfiguration(createNeighborExpected(new IpAddress(new Ipv4Address("127.0.0.2")))));
- Mockito.verify(this.bgpPeerRegistry).removePeer(any(IpAddress.class));
-
- this.bgpPeer.close();
- Mockito.verify(this.singletonServiceRegistration, times(2)).close();
- Mockito.verify(this.serviceRegistration).unregister();
- Mockito.verify(this.future, times(2)).cancel(true);
-
- final Neighbor neighborDiffConfig = new NeighborBuilder().setNeighborAddress(NEIGHBOR_ADDRESS)
- .setAfiSafis(createAfiSafi()).build();
- this.bgpPeer.start(this.rib, neighborDiffConfig, this.tableTypeRegistry);
- assertTrue(this.bgpPeer.containsEqualConfiguration(neighborDiffConfig));
- this.bgpPeer.close();
+ assertTrue(bgpPeer.containsEqualConfiguration(neighborExpected));
+ assertFalse(bgpPeer.containsEqualConfiguration(createNeighborExpected(
+ new IpAddress(new Ipv4Address("127.0.0.2")))));
+
+ bgpPeer.closeServiceInstance();
+ verify(bgpPeerRegistry, times(2)).removePeer(any());
+ verify(future, times(2)).cancel(true);
+
+ bgpPeer.instantiateServiceInstance();
+ verify(bgpPeerRegistry, times(3)).addPeer(any(), any(), any());
+ verify(dispatcher, times(3)).createReconnectingClient(any(InetSocketAddress.class), any(), anyInt(),
+ any(KeyMapping.class));
+
+ bgpPeer.closeServiceInstance();
+ verify(bgpPeerRegistry, times(3)).removePeer(any());
+ verify(future, times(3)).cancel(true);
+ verify(rib, times(3)).createPeerDOMChain(any());
+
+ bgpPeer.stop().get();
+ bgpPeer.start(rib, bgpPeer.getCurrentConfiguration(), null, peerGroupLoader, tableTypeRegistry);
+ bgpPeer.instantiateServiceInstance();
+ verify(rib, times(4)).createPeerDOMChain(any());
+ verify(rib, times(6)).getLocalAs();
+ verify(rib, times(3)).getLocalTables();
+ verify(bgpPeerRegistry, times(4)).addPeer(any(), any(), any());
+ verify(dispatcher, times(4)).createReconnectingClient(any(InetSocketAddress.class), any(), anyInt(),
+ any(KeyMapping.class));
+ bgpPeer.closeServiceInstance();
+ verify(bgpPeerRegistry, times(4)).removePeer(any());
+ verify(future, times(4)).cancel(true);
+ bgpPeer.stop().get();
+
+ final Neighbor neighborDiffConfig = new NeighborBuilder()
+ .setNeighborAddress(NEIGHBOR_ADDRESS)
+ .setAfiSafis(createAfiSafi())
+ .build();
+ bgpPeer.start(rib, neighborDiffConfig, null, peerGroupLoader, tableTypeRegistry);
+ assertTrue(bgpPeer.containsEqualConfiguration(neighborDiffConfig));
+ bgpPeer.stop().get();
}
-}
\ No newline at end of file
+}
Code Review / bgpcep.git / blobdiff