import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
+import com.google.common.collect.Lists;
+import java.util.Collections;
import java.util.List;
-
import javax.management.InstanceAlreadyExistsException;
import javax.management.ObjectName;
-
import org.junit.Test;
+import org.opendaylight.bgpcep.tcpmd5.jni.NativeTestSupport;
import org.opendaylight.controller.config.api.IdentityAttributeRef;
import org.opendaylight.controller.config.api.ValidationException;
import org.opendaylight.controller.config.api.jmx.CommitStatus;
import org.opendaylight.controller.config.spi.ModuleFactory;
import org.opendaylight.controller.config.util.ConfigTransactionJMXClient;
-import org.opendaylight.controller.config.yang.bgp.rib.spi.RIBExtensionsImplModuleFactory;
-import org.opendaylight.controller.config.yang.md.sal.binding.impl.DataBrokerImplModuleFactory;
-import org.opendaylight.controller.config.yang.md.sal.dom.impl.DomBrokerImplModuleFactory;
-import org.opendaylight.controller.config.yang.md.sal.dom.impl.HashMapDataStoreModuleFactory;
-import org.opendaylight.controller.config.yang.netty.eventexecutor.GlobalEventExecutorModuleFactory;
-import org.opendaylight.controller.config.yang.reconnectstrategy.TimedReconnectStrategyModuleFactory;
+import org.opendaylight.controller.config.yang.tcpmd5.jni.cfg.NativeKeyAccessFactoryModuleFactory;
+import org.opendaylight.controller.config.yang.tcpmd5.netty.cfg.MD5ClientChannelFactoryModuleFactory;
+import org.opendaylight.controller.config.yang.tcpmd5.netty.cfg.MD5ClientChannelFactoryModuleMXBean;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.PortNumber;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.Ipv4AddressFamily;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.MplsLabeledVpnSubsequentAddressFamily;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.tcpmd5.cfg.rev140427.Rfc2385Key;
import org.opendaylight.yangtools.yang.data.impl.codec.CodecRegistry;
import org.opendaylight.yangtools.yang.data.impl.codec.IdentityCodec;
-import com.google.common.collect.Lists;
-
-public class BGPPeerModuleTest extends RIBImplModuleTest {
-
- private final String instanceName = "bgp-impl1";
-
- public static ObjectName createBgpPeerInstance(final ConfigTransactionJMXClient transaction,
- final String instanceName, final String host, final Integer port) throws Exception {
- final ObjectName nameCreated = transaction.createModule(BGPPeerModuleFactory.NAME, instanceName);
- final BGPPeerModuleMXBean mxBean = transaction.newMXBeanProxy(nameCreated, BGPPeerModuleMXBean.class);
-
- // FIXME JMX crashes if union was not created via artificial constructor
- // annotated for JMX as value
- // IpAddress host1 = new IpAddress(new Ipv4Address(host));
- mxBean.setHost(host == null ? null : new IpAddress(host.toCharArray()));
- mxBean.setPort(port==null ? null : new PortNumber(port));
- mxBean.setAdvertizedTable(Lists.newArrayList(createAdvertisedTable(transaction, BGPTableTypeImplModuleFactory.NAME)));
- mxBean.setRib(createInstance(transaction, RIBImplModuleFactory.NAME, "ribImpl",
- DataBrokerImplModuleFactory.NAME, TimedReconnectStrategyModuleFactory.NAME,
- GlobalEventExecutorModuleFactory.NAME, BGPDispatcherImplModuleFactory.NAME,
- RIBExtensionsImplModuleFactory.NAME, DomBrokerImplModuleFactory.NAME,
- HashMapDataStoreModuleFactory.NAME));
- return nameCreated;
- }
-
- private static ObjectName createAdvertisedTable(final ConfigTransactionJMXClient transaction, final String tableTypeModuleName) throws InstanceAlreadyExistsException {
- String instanceName = "table-type";
- final ObjectName nameCreated = transaction.createModule(tableTypeModuleName, instanceName);
- BGPTableTypeImplModuleMXBean mxBean = transaction.newMXBeanProxy(nameCreated, BGPTableTypeImplModuleMXBean.class);
-
- mxBean.setAfi(new IdentityAttributeRef(Ipv4AddressFamily.QNAME.toString()));
- mxBean.setSafi(new IdentityAttributeRef(MplsLabeledVpnSubsequentAddressFamily.QNAME.toString()));
- return nameCreated;
- }
-
- @Override
- protected List<ModuleFactory> getModuleFactories() {
- List<ModuleFactory> moduleFactories = super.getModuleFactories();
- moduleFactories.add(new BGPPeerModuleFactory());
- moduleFactories.add(new BGPTableTypeImplModuleFactory());
- return moduleFactories;
- }
-
- @Test
- public void testValidationExceptionPortNotSet() throws Exception {
- final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- try {
- createBgpPeerInstance(transaction, this.instanceName, "127.0.0.1", null);
- transaction.validateConfig();
- fail();
- } catch (final ValidationException e) {
- transaction.abortConfig();
- assertTrue(e.getMessage().contains("Port value is not set."));
- }
- }
-
- @Test
- public void testValidationExceptionHostNotSet() throws Exception {
- final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- try {
- createBgpPeerInstance(transaction, this.instanceName, null, null);
- transaction.validateConfig();
- fail();
- } catch (final ValidationException e) {
- transaction.abortConfig();
- assertTrue(e.getMessage().contains("Host value is not set."));
- }
- }
-
- @Override
- @Test
- public void testCreateBean() throws Exception {
- final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- createBgpPeerInstance(transaction, this.instanceName, "127.0.0.1", 1);
- transaction.validateConfig();
- final CommitStatus status = transaction.commit();
- assertBeanCount(1, BGPPeerModuleFactory.NAME);
- assertStatus(status, 16, 0, 0);
- }
-
- @Override
- protected CodecRegistry getCodecRegistry() {
- IdentityCodec<?> idCodec = mock(IdentityCodec.class);
- doReturn(Ipv4AddressFamily.class).when(idCodec).deserialize(Ipv4AddressFamily.QNAME);
- doReturn(MplsLabeledVpnSubsequentAddressFamily.class).when(idCodec).deserialize(MplsLabeledVpnSubsequentAddressFamily.QNAME);
-
- CodecRegistry codecReg = super.getCodecRegistry();
- doReturn(idCodec).when(codecReg).getIdentityCodec();
- return codecReg;
- }
-
- @Test
- public void testReusingOldInstance() throws Exception {
- ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- createBgpPeerInstance(transaction, this.instanceName, "127.0.0.1", 1);
- transaction.validateConfig();
- CommitStatus status = transaction.commit();
- transaction = this.configRegistryClient.createTransaction();
- assertBeanCount(1, BGPPeerModuleFactory.NAME);
- status = transaction.commit();
- assertBeanCount(1, BGPPeerModuleFactory.NAME);
- assertStatus(status, 0, 0, 16);
- }
-
- @Test
- public void testReconfigure() throws Exception {
- ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
- createBgpPeerInstance(transaction, this.instanceName, "127.0.0.1", 1);
- transaction.validateConfig();
- CommitStatus status = transaction.commit();
- transaction = this.configRegistryClient.createTransaction();
- assertBeanCount(1, BGPPeerModuleFactory.NAME);
- final BGPPeerModuleMXBean mxBean = transaction.newMXBeanProxy(
- transaction.lookupConfigBean(BGPPeerModuleFactory.NAME, this.instanceName), BGPPeerModuleMXBean.class);
- mxBean.setPort(new PortNumber(10));
- status = transaction.commit();
- assertBeanCount(1, BGPPeerModuleFactory.NAME);
- assertStatus(status, 0, 1, 15);
- }
+public class BGPPeerModuleTest extends AbstractRIBImplModuleTest {
+
+ private static final String INSTANCE_NAME = "bgp-peer-module-impl";
+ private static final String FACTORY_NAME = BGPPeerModuleFactory.NAME;
+
+ private static final String HOST = "127.0.0.1";
+ private static final PortNumber portNumber = new PortNumber(1);
+
+ @Override
+ protected CodecRegistry getCodecRegistry() {
+ IdentityCodec<?> idCodec = mock(IdentityCodec.class);
+ doReturn(Ipv4AddressFamily.class).when(idCodec).deserialize(Ipv4AddressFamily.QNAME);
+ doReturn(MplsLabeledVpnSubsequentAddressFamily.class).when(idCodec).deserialize(MplsLabeledVpnSubsequentAddressFamily.QNAME);
+
+ CodecRegistry codecReg = super.getCodecRegistry();
+ doReturn(idCodec).when(codecReg).getIdentityCodec();
+ return codecReg;
+ }
+
+ @Override
+ protected List<ModuleFactory> getModuleFactories() {
+ List<ModuleFactory> moduleFactories = super.getModuleFactories();
+ moduleFactories.add(new BGPPeerModuleFactory());
+ moduleFactories.add(new BGPTableTypeImplModuleFactory());
+ moduleFactories.add(new NativeKeyAccessFactoryModuleFactory());
+ moduleFactories.add(new MD5ClientChannelFactoryModuleFactory());
+ moduleFactories.add(new StrictBgpPeerRegistryModuleFactory());
+ return moduleFactories;
+ }
+
+ @Test
+ public void testValidationExceptionPortNotSet() throws Exception {
+ try {
+ createBgpPeerInstance(HOST, null, false);
+ fail();
+ } catch (final ValidationException e) {
+ assertTrue(e.getMessage().contains("Port value is not set."));
+ }
+ }
+
+ @Test
+ public void testValidationExceptionHostNotSet() throws Exception {
+ try {
+ createBgpPeerInstance(null, portNumber, false);
+ fail();
+ } catch (final ValidationException e) {
+ assertTrue(e.getMessage().contains("Host value is not set."));
+ }
+ }
+
+ @Test
+ public void testCreateBean() throws Exception {
+ final CommitStatus status = createBgpPeerInstance();
+ assertBeanCount(1, FACTORY_NAME);
+ assertStatus(status, 17, 0, 0);
+ }
+
+ @Test
+ public void testCreateBeanWithMD5() throws Exception {
+ NativeTestSupport.assumeSupportedPlatform();
+ final CommitStatus status = createBgpPeerInstance(true);
+ assertBeanCount(1, FACTORY_NAME);
+ assertStatus(status, 19, 0, 0);
+ }
+
+ @Test
+ public void testMD5ValidationFailure() throws Exception {
+ NativeTestSupport.assumeSupportedPlatform();
+ createBgpPeerInstance(true);
+ // now remove md5 from dispatcher
+ ConfigTransactionJMXClient transaction = configRegistryClient.createTransaction();
+ final ObjectName nameCreated = transaction.lookupConfigBean(FACTORY_NAME, INSTANCE_NAME);
+ final BGPPeerModuleMXBean mxBean = transaction.newMXBeanProxy(nameCreated, BGPPeerModuleMXBean.class);
+ BGPDispatcherImplModuleMXBean bgpDispatcherImplModuleMXBean = getBgpDispatcherImplModuleMXBean(transaction, mxBean);
+ bgpDispatcherImplModuleMXBean.setMd5ChannelFactory(null);
+ try {
+ transaction.validateConfig();
+ fail();
+ } catch (ValidationException e) {
+ assertTrue(e.getMessage(), e.getMessage().contains("Underlying dispatcher does not support MD5 clients"));
+ }
+ }
+
+ @Test
+ public void testReusingOldInstance() throws Exception {
+ CommitStatus status = createBgpPeerInstance();
+ ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
+ assertBeanCount(1, FACTORY_NAME);
+ status = transaction.commit();
+ assertBeanCount(1, FACTORY_NAME);
+ assertStatus(status, 0, 0, 17);
+ }
+
+ @Test
+ public void testReconfigure() throws Exception {
+ CommitStatus status = createBgpPeerInstance();
+ ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
+ assertBeanCount(1, FACTORY_NAME);
+ final BGPPeerModuleMXBean mxBean = transaction.newMXBeanProxy(transaction.lookupConfigBean(FACTORY_NAME, INSTANCE_NAME),
+ BGPPeerModuleMXBean.class);
+ mxBean.setPort(new PortNumber(10));
+ status = transaction.commit();
+ assertBeanCount(1, FACTORY_NAME);
+ assertStatus(status, 0, 1, 16);
+ }
+
+ private ObjectName createBgpPeerInstance(final ConfigTransactionJMXClient transaction, final String host,
+ final PortNumber port, boolean md5)
+ throws Exception {
+ final ObjectName nameCreated = transaction.createModule(FACTORY_NAME, INSTANCE_NAME);
+ final BGPPeerModuleMXBean mxBean = transaction.newMXBeanProxy(nameCreated, BGPPeerModuleMXBean.class);
+
+ mxBean.setPeerRegistry(createPeerRegistry(transaction));
+
+ // FIXME JMX crashes if union was not created via artificial constructor - Bug:1276
+ // annotated for JMX as value
+ // IpAddress host1 = new IpAddress(new Ipv4Address(host));
+ mxBean.setHost(host == null ? null : new IpAddress(host.toCharArray()));
+ mxBean.setPort(port);
+ mxBean.setAdvertizedTable(Collections.<ObjectName> emptyList());
+ {
+ ObjectName ribON = createRIBImplModuleInstance(transaction);
+ mxBean.setRib(ribON);
+ }
+ if (md5) {
+ BGPDispatcherImplModuleMXBean bgpDispatcherProxy = getBgpDispatcherImplModuleMXBean(transaction, mxBean);
+ ObjectName jniON = transaction.createModule(NativeKeyAccessFactoryModuleFactory.NAME, NativeKeyAccessFactoryModuleFactory.NAME);
+ ObjectName md5ClientON = transaction.createModule(MD5ClientChannelFactoryModuleFactory.NAME,
+ MD5ClientChannelFactoryModuleFactory.NAME);
+ MD5ClientChannelFactoryModuleMXBean md5ClientProxy =
+ transaction.newMXBeanProxy(md5ClientON, MD5ClientChannelFactoryModuleMXBean.class);
+ md5ClientProxy.setKeyAccessFactory(jniON);
+
+ bgpDispatcherProxy.setMd5ChannelFactory(md5ClientON);
+
+ mxBean.setPassword(Rfc2385Key.getDefaultInstance("foo"));
+
+ }
+
+ mxBean.setAdvertizedTable(Lists.newArrayList(BGPTableTypeImplModuleTest.createTableInstance(transaction,
+ new IdentityAttributeRef(Ipv4AddressFamily.QNAME.toString()),
+ new IdentityAttributeRef(MplsLabeledVpnSubsequentAddressFamily.QNAME.toString()))));
+ return nameCreated;
+ }
+
+ private ObjectName createPeerRegistry(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
+ return transaction.createModule(StrictBgpPeerRegistryModuleFactory.NAME, "peer-registry");
+ }
+
+ private BGPDispatcherImplModuleMXBean getBgpDispatcherImplModuleMXBean(ConfigTransactionJMXClient transaction,
+ BGPPeerModuleMXBean mxBean) {
+ RIBImplModuleMXBean ribProxy = transaction.newMXBeanProxy(mxBean.getRib(), RIBImplModuleMXBean.class);
+ ObjectName dispatcherON = ribProxy.getBgpDispatcher();
+ return transaction.newMXBeanProxy(dispatcherON, BGPDispatcherImplModuleMXBean.class);
+ }
+
+ private CommitStatus createBgpPeerInstance() throws Exception {
+ return createBgpPeerInstance(false);
+ }
+
+ private CommitStatus createBgpPeerInstance(boolean md5) throws Exception {
+ return createBgpPeerInstance(HOST, portNumber, md5);
+ }
+
+ private CommitStatus createBgpPeerInstance(final String host, final PortNumber port, boolean md5) throws Exception {
+ final ConfigTransactionJMXClient transaction = this.configRegistryClient.createTransaction();
+ createBgpPeerInstance(transaction, host, port, md5);
+ return transaction.commit();
+ }
}
Code Review / bgpcep.git / blobdiff