Fix checkstyle issues under rib-spi

[bgpcep.git] / bgp / rib-spi / src / main / java / org / opendaylight / protocol / bgp / rib / spi / SimpleRIBExtensionProviderContext.java

diff --git a/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/SimpleRIBExtensionProviderContext.java b/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/SimpleRIBExtensionProviderContext.java
index eb91dd0efad3863e4a083f9397461860295da2c4..5a5ff1fb72c3112a3a6a8af232ff2bf174065d60 100644 (file)
--- a/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/SimpleRIBExtensionProviderContext.java
+++ b/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/SimpleRIBExtensionProviderContext.java
@@ -39,8 +39,9 @@ public class SimpleRIBExtensionProviderContext implements RIBExtensionProviderCo
             final Class<? extends SubsequentAddressFamily> safi, final T support) {
         final TablesKey key = new TablesKey(afi, safi);
         final RIBSupport prev = this.supports.putIfAbsent(key, support);
-        Preconditions.checkArgument(prev == null, "AFI %s SAFI %s is already registered with %s", afi, safi, prev);
-        this.domSupports.put(RibSupportUtils.toYangTablesKey(afi,safi), support);
+        Preconditions.checkArgument(prev == null, "AFI %s SAFI %s is already registered with %s",
+                afi, safi, prev);
+        this.domSupports.put(RibSupportUtils.toYangTablesKey(afi, safi), support);
         addClassLoadingSupport(afi, safi, support);
         return new AbstractRIBSupportRegistration<T>(support) {
             @Override
@@ -50,17 +51,18 @@ public class SimpleRIBExtensionProviderContext implements RIBExtensionProviderCo
         };
     }
 
-    private void addClassLoadingSupport(final Class<?> afi, final Class<?> safi, final RIBSupport s) {
-        final Set<YangModuleInfo> moduleInfos =
-                getModuleInfos(afi, safi, s.routesListClass(), s.routesContainerClass(), s.routesCaseClass());
-        if(!moduleInfos.isEmpty()) {
+    private void addClassLoadingSupport(final Class<?> afi, final Class<?> safi, final RIBSupport support) {
+        final Set<YangModuleInfo> moduleInfos = getModuleInfos(afi, safi, support.routesListClass(),
+                support.routesContainerClass(), support.routesCaseClass());
+        if (!moduleInfos.isEmpty()) {
             this.classLoadingStrategy.addModuleInfos(moduleInfos);
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     private static Set<YangModuleInfo> getModuleInfos(final Class<?>... clazzes) {
         final Set<YangModuleInfo> moduleInfos = new HashSet<>();
-        for(final Class<?> clz : clazzes) {
+        for (final Class<?> clz : clazzes) {
             try {
                 moduleInfos.add(BindingReflections.getModuleInfo(clz));
             } catch (final Exception e) {
@@ -71,7 +73,8 @@ public class SimpleRIBExtensionProviderContext implements RIBExtensionProviderCo
     }
 
     @Override
-    public RIBSupport getRIBSupport(final Class<? extends AddressFamily> afi, final Class<? extends SubsequentAddressFamily> safi) {
+    public RIBSupport getRIBSupport(final Class<? extends AddressFamily> afi,
+            final Class<? extends SubsequentAddressFamily> safi) {
         return getRIBSupport(new TablesKey(afi, safi));
     }
 
@@ -86,6 +89,7 @@ public class SimpleRIBExtensionProviderContext implements RIBExtensionProviderCo
     }
 
     @Override
+    @SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
     public RIBSupport getRIBSupport(final NodeIdentifierWithPredicates key) {
         return this.domSupports.get(key);
     }