/*
- * Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved.
+ * Copyright (c) 2022 PANTHEON.tech, s.r.o. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
*/
package org.opendaylight.mdsal.binding.dom.adapter;
-import com.google.common.base.Preconditions;
-import com.google.common.cache.Cache;
-import com.google.common.cache.CacheBuilder;
-import com.google.common.util.concurrent.CheckedFuture;
-import com.google.common.util.concurrent.JdkFutureAdapters;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+import static org.opendaylight.mdsal.binding.dom.adapter.StaticConfiguration.ENABLE_CODEC_SHORTCUT;
+
import com.google.common.util.concurrent.ListenableFuture;
-import java.lang.reflect.Method;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Map.Entry;
-import java.util.concurrent.ExecutionException;
-import org.opendaylight.mdsal.dom.api.DOMRpcException;
+import org.eclipse.jdt.annotation.NonNull;
+import org.opendaylight.mdsal.binding.dom.codec.api.BindingLazyContainerNode;
import org.opendaylight.mdsal.dom.api.DOMRpcIdentifier;
-import org.opendaylight.mdsal.dom.api.DOMRpcImplementation;
-import org.opendaylight.mdsal.dom.api.DOMRpcResult;
-import org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry;
import org.opendaylight.yangtools.yang.binding.DataObject;
-import org.opendaylight.yangtools.yang.binding.RpcService;
-import org.opendaylight.yangtools.yang.binding.util.BindingReflections;
-import org.opendaylight.yangtools.yang.binding.util.RpcServiceInvoker;
+import org.opendaylight.yangtools.yang.binding.Rpc;
+import org.opendaylight.yangtools.yang.binding.RpcInput;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.common.RpcResult;
+import org.opendaylight.yangtools.yang.common.YangConstants;
import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
-import org.opendaylight.yangtools.yang.model.api.SchemaPath;
-
-public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation {
-
- private static final Cache<Class<?>, RpcServiceInvoker> SERVICE_INVOKERS
- = CacheBuilder.newBuilder().weakKeys().build();
-
- private final BindingNormalizedNodeCodecRegistry codec;
- private final RpcServiceInvoker invoker;
- private final RpcService delegate;
- private final QName inputQname;
-
- public <T extends RpcService> BindingDOMRpcImplementationAdapter(final BindingNormalizedNodeCodecRegistry codec,
- final Class<T> type, final Map<SchemaPath, Method> localNameToMethod, final T delegate) {
- try {
- this.invoker = SERVICE_INVOKERS.get(type, () -> {
- final Map<QName, Method> map = new HashMap<>();
- for (Entry<SchemaPath, Method> e : localNameToMethod.entrySet()) {
- map.put(e.getKey().getLastComponent(), e.getValue());
- }
-
- return RpcServiceInvoker.from(map);
- });
- } catch (ExecutionException e) {
- throw new IllegalArgumentException("Failed to create invokers for type " + type, e);
- }
-
- this.codec = Preconditions.checkNotNull(codec);
- this.delegate = Preconditions.checkNotNull(delegate);
- inputQname = QName.create(BindingReflections.getQNameModule(type), "input").intern();
+import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Absolute;
+
+final class BindingDOMRpcImplementationAdapter extends AbstractDOMRpcImplementationAdapter {
+ private final @NonNull Rpc<?, ?> delegate;
+ private final @NonNull QName rpcName;
+ private final @NonNull QName inputName;
+
+ BindingDOMRpcImplementationAdapter(final AdapterContext adapterContext, final Rpc<?, ?> delegate,
+ final QName rpcName) {
+ super(adapterContext);
+ this.delegate = requireNonNull(delegate);
+ this.rpcName = requireNonNull(rpcName);
+ inputName = YangConstants.operationInputQName(rpcName.getModule()).intern();
}
@Override
- public CheckedFuture<DOMRpcResult, DOMRpcException> invokeRpc(final DOMRpcIdentifier rpc,
- final NormalizedNode<?, ?> input) {
- final SchemaPath schemaPath = rpc.getType();
- final DataObject bindingInput = input != null ? deserilialize(rpc.getType(),input) : null;
- final ListenableFuture<RpcResult<?>> bindingResult = invoke(schemaPath,bindingInput);
- return transformResult(bindingResult);
+ ListenableFuture<RpcResult<?>> invokeRpc(final CurrentAdapterSerializer serializer, final DOMRpcIdentifier rpc,
+ final ContainerNode input) {
+ final var bindingInput = input != null ? deserialize(serializer, input) : null;
+ return ((Rpc) delegate).invoke((RpcInput) bindingInput);
}
- private DataObject deserilialize(final SchemaPath rpcPath, final NormalizedNode<?, ?> input) {
- if (input instanceof LazySerializedContainerNode) {
- return ((LazySerializedContainerNode) input).bindingData();
+ private DataObject deserialize(final CurrentAdapterSerializer serializer, final ContainerNode input) {
+ if (ENABLE_CODEC_SHORTCUT && input instanceof BindingLazyContainerNode<?> lazy) {
+ return lazy.getDataObject();
}
- final SchemaPath inputSchemaPath = rpcPath.createChild(inputQname);
- return codec.fromNormalizedNodeRpcData(inputSchemaPath, (ContainerNode) input);
- }
- private ListenableFuture<RpcResult<?>> invoke(final SchemaPath schemaPath, final DataObject input) {
- return JdkFutureAdapters.listenInPoolThread(invoker.invokeRpc(delegate, schemaPath.getLastComponent(), input));
+ // TODO: this is a bit inefficient: typically we get the same CurrentAdapterSerializer and the path is also
+ // constant, hence we should be able to cache this lookup and just have the appropriate
+ // BindingDataObjectCodecTreeNode and reuse it directly
+ checkArgument(inputName.equals(input.getIdentifier().getNodeType()),
+ "Unexpected RPC %s input %s", rpcName, input);
+ return serializer.fromNormalizedNodeRpcData(Absolute.of(rpcName, inputName), input);
}
-
- private CheckedFuture<DOMRpcResult, DOMRpcException> transformResult(
- final ListenableFuture<RpcResult<?>> bindingResult) {
- return LazyDOMRpcResultFuture.create(codec, bindingResult);
- }
-
}
Code Review / mdsal.git / blobdiff