/*
- * Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved.
+ * Copyright (c) 2022 PANTHEON.tech, s.r.o. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
*/
package org.opendaylight.mdsal.binding.dom.adapter;
-import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Verify.verifyNotNull;
import static java.util.Objects.requireNonNull;
import static org.opendaylight.mdsal.binding.dom.adapter.StaticConfiguration.ENABLE_CODEC_SHORTCUT;
-import com.google.common.cache.Cache;
-import com.google.common.cache.CacheBuilder;
import com.google.common.util.concurrent.ListenableFuture;
-import java.lang.reflect.Method;
-import java.util.Map;
-import java.util.concurrent.ExecutionException;
-import org.opendaylight.mdsal.binding.dom.adapter.invoke.RpcServiceInvoker;
+import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingLazyContainerNode;
-import org.opendaylight.mdsal.binding.spec.reflect.BindingReflections;
import org.opendaylight.mdsal.dom.api.DOMRpcIdentifier;
import org.opendaylight.mdsal.dom.api.DOMRpcImplementation;
import org.opendaylight.mdsal.dom.api.DOMRpcResult;
-import org.opendaylight.yangtools.yang.binding.DataObject;
-import org.opendaylight.yangtools.yang.binding.RpcService;
+import org.opendaylight.yangtools.yang.binding.Rpc;
+import org.opendaylight.yangtools.yang.binding.RpcInput;
import org.opendaylight.yangtools.yang.common.QName;
-import org.opendaylight.yangtools.yang.common.RpcResult;
-import org.opendaylight.yangtools.yang.common.YangConstants;
import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Absolute;
final class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation {
- private static final Cache<Class<?>, RpcServiceInvoker> SERVICE_INVOKERS = CacheBuilder.newBuilder().weakKeys()
- .build();
-
- // Default implementations are 0, we need to perform some translation, hence we have a slightly higher cost
- private static final int COST = 1;
-
- private final AdapterContext adapterContext;
- private final RpcServiceInvoker invoker;
- private final RpcService delegate;
- private final QName inputQname;
-
- <T extends RpcService> BindingDOMRpcImplementationAdapter(final AdapterContext adapterContext,
- final Class<T> type, final Map<QName, Method> localNameToMethod, final T delegate) {
- try {
- this.invoker = SERVICE_INVOKERS.get(type, () -> RpcServiceInvoker.from(localNameToMethod));
- } catch (ExecutionException e) {
- throw new IllegalArgumentException("Failed to create invokers for type " + type, e);
- }
+ private final @NonNull AdapterContext adapterContext;
+ private final @NonNull QName rpcName;
+ @SuppressWarnings("rawtypes")
+ private final @NonNull Rpc delegate;
+ BindingDOMRpcImplementationAdapter(final AdapterContext adapterContext, final QName rpcName,
+ final Rpc<?, ?> delegate) {
this.adapterContext = requireNonNull(adapterContext);
+ this.rpcName = requireNonNull(rpcName);
this.delegate = requireNonNull(delegate);
- inputQname = YangConstants.operationInputQName(BindingReflections.getQNameModule(type)).intern();
}
@Override
- public ListenableFuture<DOMRpcResult> invokeRpc(final DOMRpcIdentifier rpc, final NormalizedNode input) {
- final QName rpcType = rpc.getType();
- final CurrentAdapterSerializer serializer = adapterContext.currentSerializer();
- final DataObject bindingInput = input != null ? deserialize(serializer, rpcType, input) : null;
- final ListenableFuture<RpcResult<?>> bindingResult = invoke(rpcType, bindingInput);
- return LazyDOMRpcResultFuture.create(serializer, bindingResult);
+ public long invocationCost() {
+ // Default implementations are 0, we need to perform some translation, hence we have a slightly higher cost
+ return 1;
}
@Override
- public long invocationCost() {
- return COST;
+ public ListenableFuture<DOMRpcResult> invokeRpc(final DOMRpcIdentifier rpc, final ContainerNode input) {
+ final var serializer = adapterContext.currentSerializer();
+ @SuppressWarnings("unchecked")
+ final var future = delegate.invoke(deserialize(serializer, input));
+ return LazyDOMRpcResultFuture.create(serializer, future);
}
- private DataObject deserialize(final CurrentAdapterSerializer serializer, final QName rpcType,
- final NormalizedNode input) {
- if (ENABLE_CODEC_SHORTCUT && input instanceof BindingLazyContainerNode) {
- return ((BindingLazyContainerNode<?>) input).getDataObject();
+ private @NonNull RpcInput deserialize(final @NonNull CurrentAdapterSerializer serializer,
+ final @NonNull ContainerNode input) {
+ if (ENABLE_CODEC_SHORTCUT && input instanceof BindingLazyContainerNode<?> lazy) {
+ return (RpcInput) lazy.getDataObject();
}
- final ContainerNode container = (ContainerNode) input;
- checkArgument(inputQname.equals(container.getIdentifier().getNodeType()), "Unexpected RPC %s input %s", rpcType,
- input);
- return serializer.fromNormalizedNodeRpcData(Absolute.of(rpcType, inputQname), container);
- }
+ final var inputName = input.name().getNodeType();
+ if (!"input".equals(inputName.getLocalName()) || !rpcName.getModule().equals(inputName.getModule())) {
+ throw new IllegalArgumentException("Unexpected RPC " + rpcName + " input " + input.prettyTree());
+ }
- private ListenableFuture<RpcResult<?>> invoke(final QName rpcType, final DataObject input) {
- return invoker.invokeRpc(delegate, rpcType, input);
+ // TODO: this is a bit inefficient: typically we get the same CurrentAdapterSerializer and the path is also
+ // constant, hence we should be able to cache this lookup and just have the appropriate
+ // BindingDataObjectCodecTreeNode and reuse it directly
+ // FIXME: should be a guaranteed return, as input is @NonNull
+ return verifyNotNull((RpcInput) serializer.fromNormalizedNodeRpcData(Absolute.of(rpcName, inputName), input));
}
}
Code Review / mdsal.git / blobdiff