Use YANG binding from YANG Tools

[mdsal.git] / binding / mdsal-binding-dom-adapter / src / main / java / org / opendaylight / mdsal / binding / dom / adapter / BindingDOMRpcImplementationAdapter.java

diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java
index 2f44a2d28fd2f40b2dcb66163fce413b8dffbfd9..639830bab6f21456dd8d1ef3aa25f2ef21ab1804 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java
@@ -7,53 +7,64 @@
  */
 package org.opendaylight.mdsal.binding.dom.adapter;
 
-import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 import static org.opendaylight.mdsal.binding.dom.adapter.StaticConfiguration.ENABLE_CODEC_SHORTCUT;
 
 import com.google.common.util.concurrent.ListenableFuture;
 import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.mdsal.binding.dom.codec.api.BindingLazyContainerNode;
 import org.opendaylight.mdsal.dom.api.DOMRpcIdentifier;
-import org.opendaylight.yangtools.yang.binding.DataObject;
-import org.opendaylight.yangtools.yang.binding.Rpc;
-import org.opendaylight.yangtools.yang.binding.RpcInput;
+import org.opendaylight.mdsal.dom.api.DOMRpcImplementation;
+import org.opendaylight.mdsal.dom.api.DOMRpcResult;
+import org.opendaylight.yangtools.binding.Rpc;
+import org.opendaylight.yangtools.binding.RpcInput;
+import org.opendaylight.yangtools.binding.data.codec.api.BindingLazyContainerNode;
 import org.opendaylight.yangtools.yang.common.QName;
-import org.opendaylight.yangtools.yang.common.RpcResult;
-import org.opendaylight.yangtools.yang.common.YangConstants;
 import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
 import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Absolute;
 
-final class BindingDOMRpcImplementationAdapter extends AbstractDOMRpcImplementationAdapter {
-    private final @NonNull Rpc<?, ?> delegate;
+final class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation {
+    private final @NonNull AdapterContext adapterContext;
     private final @NonNull QName rpcName;
-    private final @NonNull QName inputName;
+    @SuppressWarnings("rawtypes")
+    private final @NonNull Rpc delegate;
 
-    BindingDOMRpcImplementationAdapter(final AdapterContext adapterContext, final Rpc<?, ?> delegate,
-            final QName rpcName) {
-        super(adapterContext);
-        this.delegate = requireNonNull(delegate);
+    BindingDOMRpcImplementationAdapter(final AdapterContext adapterContext, final QName rpcName,
+            final Rpc<?, ?> delegate) {
+        this.adapterContext = requireNonNull(adapterContext);
         this.rpcName = requireNonNull(rpcName);
-        inputName = YangConstants.operationInputQName(rpcName.getModule()).intern();
+        this.delegate = requireNonNull(delegate);
     }
 
     @Override
-    ListenableFuture<RpcResult<?>> invokeRpc(final CurrentAdapterSerializer serializer, final DOMRpcIdentifier rpc,
-            final ContainerNode input) {
-        final var bindingInput = input != null ? deserialize(serializer, input) : null;
-        return ((Rpc) delegate).invoke((RpcInput) bindingInput);
+    public long invocationCost() {
+        // Default implementations are 0, we need to perform some translation, hence we have a slightly higher cost
+        return 1;
     }
 
-    private DataObject deserialize(final CurrentAdapterSerializer serializer, final ContainerNode input) {
+    @Override
+    public ListenableFuture<DOMRpcResult> invokeRpc(final DOMRpcIdentifier rpc, final ContainerNode input) {
+        final var serializer = adapterContext.currentSerializer();
+        @SuppressWarnings("unchecked")
+        final var future = delegate.invoke(deserialize(serializer, input));
+        return LazyDOMRpcResultFuture.create(serializer, future);
+    }
+
+    private @NonNull RpcInput deserialize(final @NonNull CurrentAdapterSerializer serializer,
+            final @NonNull ContainerNode input) {
         if (ENABLE_CODEC_SHORTCUT && input instanceof BindingLazyContainerNode<?> lazy) {
-            return lazy.getDataObject();
+            return (RpcInput) lazy.getDataObject();
+        }
+
+        final var inputName = input.name().getNodeType();
+        if (!"input".equals(inputName.getLocalName()) || !rpcName.getModule().equals(inputName.getModule())) {
+            throw new IllegalArgumentException("Unexpected RPC " + rpcName + " input " + input.prettyTree());
         }
 
         // TODO: this is a bit inefficient: typically we get the same CurrentAdapterSerializer and the path is also
         //       constant, hence we should be able to cache this lookup and just have the appropriate
         //       BindingDataObjectCodecTreeNode and reuse it directly
-        checkArgument(inputName.equals(input.getIdentifier().getNodeType()),
-            "Unexpected RPC %s input %s", rpcName, input);
-        return serializer.fromNormalizedNodeRpcData(Absolute.of(rpcName, inputName), input);
+        // FIXME: should be a guaranteed return, as input is @NonNull
+        return verifyNotNull((RpcInput) serializer.fromNormalizedNodeRpcData(Absolute.of(rpcName, inputName), input));
     }
 }