Report ExactDataObjectStep from DataObjectModification

[mdsal.git] / binding / mdsal-binding-dom-adapter / src / main / java / org / opendaylight / mdsal / binding / dom / adapter / BindingDOMTransactionChainAdapter.java

diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapter.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapter.java
index e80579e9b4aa1bb70adeebf5ab5c376ca5f75590..8bca8533fb7dd738564c00a5be6c904e177fc800 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapter.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapter.java
@@ -7,43 +7,28 @@
  */
 package org.opendaylight.mdsal.binding.dom.adapter;
 
-import com.google.common.base.Preconditions;
-import com.google.common.util.concurrent.CheckedFuture;
-import com.google.common.util.concurrent.FutureCallback;
-import com.google.common.util.concurrent.Futures;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.MoreExecutors;
-import org.opendaylight.mdsal.binding.api.BindingTransactionChain;
+import java.util.function.Supplier;
+import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.mdsal.binding.api.ReadTransaction;
+import org.opendaylight.mdsal.binding.api.ReadWriteTransaction;
+import org.opendaylight.mdsal.binding.api.TransactionChain;
+import org.opendaylight.mdsal.binding.api.TransactionChainClosedException;
 import org.opendaylight.mdsal.binding.api.WriteTransaction;
-import org.opendaylight.mdsal.common.api.AsyncTransaction;
-import org.opendaylight.mdsal.common.api.TransactionChain;
-import org.opendaylight.mdsal.common.api.TransactionChainListener;
-import org.opendaylight.mdsal.common.api.TransactionCommitFailedException;
-import org.opendaylight.mdsal.dom.api.DOMDataBroker;
-import org.opendaylight.mdsal.dom.api.DOMDataTreeReadTransaction;
-import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
 import org.opendaylight.mdsal.dom.api.DOMTransactionChain;
+import org.opendaylight.mdsal.dom.api.DOMTransactionChainClosedException;
 import org.opendaylight.yangtools.concepts.Delegator;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-final class BindingDOMTransactionChainAdapter implements BindingTransactionChain, Delegator<DOMTransactionChain> {
+import org.opendaylight.yangtools.yang.common.Empty;
 
-    private static final Logger LOG = LoggerFactory.getLogger(BindingDOMTransactionChainAdapter.class);
+final class BindingDOMTransactionChainAdapter implements TransactionChain, Delegator<DOMTransactionChain> {
+    private final @NonNull DOMTransactionChain delegate;
+    private final @NonNull AdapterContext adapterContext;
 
-    private final DOMTransactionChain delegate;
-    private final BindingToNormalizedNodeCodec codec;
-    private final DelegateChainListener domListener;
-    private final TransactionChainListener bindingListener;
-
-    BindingDOMTransactionChainAdapter(final DOMDataBroker chainFactory,
-            final BindingToNormalizedNodeCodec codec, final TransactionChainListener listener) {
-        Preconditions.checkNotNull(chainFactory, "DOM Transaction chain factory must not be null");
-        this.domListener = new DelegateChainListener();
-        this.bindingListener = listener;
-        this.delegate = chainFactory.createTransactionChain(domListener);
-        this.codec = codec;
+    BindingDOMTransactionChainAdapter(final DOMTransactionChain delegate, final AdapterContext adapterContext) {
+        this.delegate = requireNonNull(delegate);
+        this.adapterContext = requireNonNull(adapterContext);
     }
 
     @Override
@@ -53,47 +38,25 @@ final class BindingDOMTransactionChainAdapter implements BindingTransactionChain
 
     @Override
     public ReadTransaction newReadOnlyTransaction() {
-        final DOMDataTreeReadTransaction delegateTx = delegate.newReadOnlyTransaction();
-        return new BindingDOMReadTransactionAdapter(delegateTx, codec);
+        return new BindingDOMReadTransactionAdapter(adapterContext,
+            createTransaction(delegate::newReadOnlyTransaction));
     }
 
     @Override
     public WriteTransaction newWriteOnlyTransaction() {
-        final DOMDataTreeWriteTransaction delegateTx = delegate.newWriteOnlyTransaction();
-        return new BindingDOMWriteTransactionAdapter<DOMDataTreeWriteTransaction>(delegateTx, codec) {
-
-            @Override
-            public CheckedFuture<Void,TransactionCommitFailedException> submit() {
-                return listenForFailure(this,super.submit());
-            }
-
-        };
+        return new BindingDOMWriteTransactionAdapter<>(adapterContext,
+            createTransaction(delegate::newWriteOnlyTransaction));
     }
 
-    private <T, F extends ListenableFuture<T>> F listenForFailure(final WriteTransaction tx, final F future) {
-        Futures.addCallback(future, new FutureCallback<T>() {
-            @Override
-            public void onFailure(final Throwable throwable) {
-                failTransactionChain(tx, throwable);
-            }
-
-            @Override
-            public void onSuccess(final T result) {
-                // Intentionally NOOP
-            }
-        }, MoreExecutors.directExecutor());
-
-        return future;
+    @Override
+    public ReadWriteTransaction newReadWriteTransaction() {
+        return new BindingDOMReadWriteTransactionAdapter(adapterContext,
+            createTransaction(delegate::newReadWriteTransaction));
     }
 
-    private void failTransactionChain(final WriteTransaction tx, final Throwable throwable) {
-        /*
-         *  We asume correct state change for underlaying transaction
-         *
-         * chain, so we are not changing any of our internal state
-         * to mark that we failed.
-         */
-        this.bindingListener.onTransactionChainFailed(this, tx, throwable);
+    @Override
+    public ListenableFuture<Empty> future() {
+        return delegate.future();
     }
 
     @Override
@@ -101,31 +64,11 @@ final class BindingDOMTransactionChainAdapter implements BindingTransactionChain
         delegate.close();
     }
 
-    private final class DelegateChainListener implements TransactionChainListener {
-
-        @Override
-        public void onTransactionChainFailed(final TransactionChain<?, ?> chain,
-                final AsyncTransaction<?, ?> transaction, final Throwable cause) {
-            Preconditions.checkState(delegate.equals(chain),
-                    "Illegal state - listener for %s was invoked for incorrect chain %s.", delegate, chain);
-            /*
-             * Intentionally NOOP, callback for failure, since we
-             * are also listening on each transaction future for failure,
-             * in order to have reference to Binding Transaction (which was seen by client
-             * of this transaction chain), instead of DOM transaction
-             * which is known only to this chain, binding transaction implementation
-             * and underlying transaction chain.
-             *
-             */
-            LOG.debug("Transaction chain {} failed. Failed DOM Transaction {}",this,transaction,cause);
-        }
-
-        @Override
-        public void onTransactionChainSuccessful(final TransactionChain<?, ?> chain) {
-            Preconditions.checkState(delegate.equals(chain),
-                    "Illegal state - listener for %s was invoked for incorrect chain %s.", delegate, chain);
-            bindingListener.onTransactionChainSuccessful(BindingDOMTransactionChainAdapter.this);
+    private static <T> T createTransaction(final Supplier<T> supplier) {
+        try {
+            return supplier.get();
+        } catch (DOMTransactionChainClosedException e) {
+            throw new TransactionChainClosedException("Transaction chain already closed", e);
         }
     }
-
 }