Fix checkstyle violations in yang-binding

[mdsal.git] / binding / yang-binding / src / main / java / org / opendaylight / yangtools / yang / binding / InstanceIdentifierBuilderImpl.java

diff --git a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/InstanceIdentifierBuilderImpl.java b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/InstanceIdentifierBuilderImpl.java
index 6060f57c35ce33b701670a553242cdc4cd35a3f6..d4243ce1ad04f39f76ef8f1a22f59c5eeabd4f58 100644 (file)
--- a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/InstanceIdentifierBuilderImpl.java
+++ b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/InstanceIdentifierBuilderImpl.java
@@ -10,12 +10,14 @@ package org.opendaylight.yangtools.yang.binding;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
+import java.util.Objects;
 import org.opendaylight.yangtools.util.HashCodeBuilder;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.IdentifiableItem;
+import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.Item;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.PathArgument;
 
-final class InstanceIdentifierBuilderImpl<T extends DataObject> implements InstanceIdentifier.InstanceIdentifierBuilder<T> {
+final class InstanceIdentifierBuilderImpl<T extends DataObject> implements InstanceIdentifierBuilder<T> {
     private final ImmutableList.Builder<PathArgument> pathBuilder = ImmutableList.builder();
     private final HashCodeBuilder<PathArgument> hashBuilder;
     private final Iterable<? extends PathArgument> basePath;
@@ -27,7 +29,8 @@ final class InstanceIdentifierBuilderImpl<T extends DataObject> implements Insta
         this.basePath = null;
     }
 
-    InstanceIdentifierBuilderImpl(final PathArgument item, final Iterable<? extends PathArgument> pathArguments, final int hash, final boolean wildcard) {
+    InstanceIdentifierBuilderImpl(final PathArgument item, final Iterable<? extends PathArgument> pathArguments,
+            final int hash, final boolean wildcard) {
         this.hashBuilder = new HashCodeBuilder<>(hash);
         this.basePath = pathArguments;
         this.wildcard = wildcard;
@@ -39,9 +42,23 @@ final class InstanceIdentifierBuilderImpl<T extends DataObject> implements Insta
         return hashBuilder.build();
     }
 
+    @Override
+    public boolean equals(final Object obj) {
+        if (this == obj) {
+            return true;
+        }
+        if (obj instanceof InstanceIdentifierBuilderImpl) {
+            InstanceIdentifierBuilderImpl<T> otherBuilder = (InstanceIdentifierBuilderImpl<T>) obj;
+            return wildcard == otherBuilder.wildcard && Objects.equals(basePath, otherBuilder.basePath)
+                    && Objects.equals(arg, otherBuilder.arg)
+                    && Objects.equals(hashBuilder.build(), otherBuilder.hashBuilder.build());
+        }
+        return false;
+    }
+
     @SuppressWarnings("unchecked")
     <N extends DataObject> InstanceIdentifierBuilderImpl<N> addNode(final Class<N> container) {
-        arg = new Item<N>(container);
+        arg = new Item<>(container);
         hashBuilder.addArgument(arg);
         pathBuilder.add(arg);
 
@@ -53,8 +70,9 @@ final class InstanceIdentifierBuilderImpl<T extends DataObject> implements Insta
     }
 
     @SuppressWarnings("unchecked")
-    <N extends DataObject & Identifiable<K>, K extends Identifier<N>> InstanceIdentifierBuilderImpl<N> addNode(final Class<N> listItem, final K listKey) {
-        arg = new IdentifiableItem<N, K>(listItem, listKey);
+    <N extends DataObject & Identifiable<K>, K extends Identifier<N>> InstanceIdentifierBuilderImpl<N> addNode(
+            final Class<N> listItem, final K listKey) {
+        arg = new IdentifiableItem<>(listItem, listKey);
         hashBuilder.addArgument(arg);
         pathBuilder.add(arg);
         return (InstanceIdentifierBuilderImpl<N>) this;
@@ -66,20 +84,22 @@ final class InstanceIdentifierBuilderImpl<T extends DataObject> implements Insta
     }
 
     @Override
-    public <N extends Identifiable<K> & ChildOf<? super T>, K extends Identifier<N>> InstanceIdentifierBuilderImpl<N> child(final Class<N> listItem, final K listKey) {
+    public <N extends Identifiable<K> & ChildOf<? super T>, K extends Identifier<N>> InstanceIdentifierBuilderImpl<N>
+            child(final Class<N> listItem, final K listKey) {
         return addNode(listItem, listKey);
     }
 
     /**
      * Build an identifier which refers to a specific augmentation of the current InstanceIdentifier referenced by
-     * the builder
+     * the builder.
      *
-     * @param container
-     * @param <N>
-     * @return
+     * @param container Augmentation to be added
+     * @param <N> Augmentation type
+     * @return This builder
      */
     @Override
-    public <N extends DataObject & Augmentation<? super T>> InstanceIdentifierBuilderImpl<N> augmentation(final Class<N> container) {
+    public <N extends DataObject & Augmentation<? super T>> InstanceIdentifierBuilderImpl<N> augmentation(
+            final Class<N> container) {
         return addNode(container);
     }
 
@@ -95,11 +115,14 @@ final class InstanceIdentifierBuilderImpl<T extends DataObject> implements Insta
         }
 
         @SuppressWarnings("unchecked")
-        final InstanceIdentifier<T> ret = (InstanceIdentifier<T>) InstanceIdentifier.trustedCreate(arg, pathArguments, hashBuilder.build(), wildcard);
+        final InstanceIdentifier<T> ret = (InstanceIdentifier<T>) InstanceIdentifier.trustedCreate(arg, pathArguments,
+            hashBuilder.build(), wildcard);
         return ret;
     }
 
-    /*
+    /**
+     * Build the resulting InstanceIdentifier.
+     *
      * @deprecated Use #build() instead.
      */
     @Override