Revert "Checkstyle TrailingComment, Sonar aligned"

[odlparent.git] / checkstyle / src / main / resources / odl_checks.xml

diff --git a/checkstyle/src/main/resources/odl_checks.xml b/checkstyle/src/main/resources/odl_checks.xml
index f1c23365b16285a2f0bb00bb3fc77516c0ae9277..502359b32bc20406b31a1742a2b6d0c14c75114c 100644 (file)
--- a/checkstyle/src/main/resources/odl_checks.xml
+++ b/checkstyle/src/main/resources/odl_checks.xml
@@ -57,13 +57,10 @@
             <property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
         </module>
         <module name="NeedBraces"/>
-        <module name="LeftCurly">
-            <property name="maxLineLength" value="100"/>
-        </module>
-        <module name="RightCurly"/>
+        <module name="LeftCurly" />
         <module name="RightCurly">
             <property name="option" value="alone"/>
-            <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
+            <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, STATIC_INIT, INSTANCE_INIT"/>
         </module>
         <module name="WhitespaceAround">
             <property name="allowEmptyConstructors" value="true"/>
@@ -247,27 +244,24 @@
              value="Method name ''{0}'' must match pattern ''{1}''."/>
         </module>
         <module name="SingleLineJavadoc"/>
+
+        <module name="HiddenField">
+            <property name="ignoreConstructorParameter" value="true" />
+            <property name="ignoreSetter" value="true" />
+            <property name="setterCanReturnItsClass" value="true" />
+        </module>
         <module name="EmptyStatement"/>
         <module name="EqualsHashCode"/>
+        <module name="FinalClass"/>
+        <module name="HideUtilityClassConstructor"/>
+        <module name="InnerAssignment"/>
 
         <!-- Checks for Exception Handling Anti-Patterns -->
         <module name="IllegalCatch"/>
         <module name="IllegalThrows" />
         <module name="MutableException"/>
-        <!-- TODO Once new remote repo to proxy for sevntu has be added to nexus.opendaylight.org ,
-             (waiting for ticket #24830 with helpdesk@opendaylight.org), and https://git.opendaylight.org/gerrit/#/c/41075/
-             has been merged, then add the following additional Exception Handling Anti-Patterns related checks here:
-
-        <module name="AvoidHidingCauseExceptionCheck" />
-  ??
         <module name="com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck" />
 
-        <module name="EitherLogOrThrowCheck" />
-  ??
-        <module name="com.github.sevntu.checkstyle.checks.coding.EitherLogOrThrowCheck" />
-
-          -->
-
         <!-- Checks for API conventions and the like -->
         <module name="com.github.sevntu.checkstyle.checks.coding.ForbidCertainImportsCheck">
             <property name="packageNameRegexp" value=".*" />