private static final int NUMBER_OF_THREADS = 4;
private static final long GET_DATA_SUBMIT_TIMEOUT = 3000;
private static final TimeUnit GET_DATA_SUBMIT_TIME_UNIT = TimeUnit.MILLISECONDS;
+ private static final TimeUnit MAX_DURATION_TO_SUBMIT_TIMEUNIT = TimeUnit.MILLISECONDS;
private final MountPointService mountPointService;
private final ScheduledExecutorService checkingExecutor;
private final ListeningExecutorService listeningExecutor;
private final ConcurrentMap<String, CountDownLatch> deviceLocks;
- private final long maxDurationToSubmitTransaction; // TODO set reasonable value in blueprint
- private final TimeUnit maxDurationToSubmitTransactionTimeUnit = TimeUnit.MILLISECONDS;
+ // TODO set reasonable value in blueprint for maxDurationToSubmitTransaction
+ private final long maxDurationToSubmitTransaction;
public DeviceTransactionManagerImpl(MountPointService mountPointService, long maxDurationToSubmitTransaction) {
this.mountPointService = mountPointService;
@Override
public Future<Optional<DeviceTransaction>> getDeviceTransaction(String deviceId) {
- return getDeviceTransaction(deviceId, maxDurationToSubmitTransaction, maxDurationToSubmitTransactionTimeUnit);
+ return getDeviceTransaction(deviceId, maxDurationToSubmitTransaction, MAX_DURATION_TO_SUBMIT_TIMEUNIT);
}
@Override
} catch (InterruptedException | ExecutionException | TimeoutException e) {
LOG.error("Exception thrown while reading data from device {}! IID: {}", deviceId, path, e);
} finally {
- deviceTx.submit(GET_DATA_SUBMIT_TIMEOUT, GET_DATA_SUBMIT_TIME_UNIT);
+ deviceTx.commit(GET_DATA_SUBMIT_TIMEOUT, GET_DATA_SUBMIT_TIME_UNIT);
}
} else {
LOG.error("Could not obtain transaction for device {}!", deviceId);