Trim QNameModule.compare()

[yangtools.git] / common / yang-common / src / main / java / org / opendaylight / yangtools / yang / common / QNameModule.java

diff --git a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QNameModule.java b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QNameModule.java
index fc84ae2814762c1929e04bfb564dd0448c847ea6..0e0ffeb6c1873ee8fc58107d68c8811cb7d6682b 100644 (file)
--- a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QNameModule.java
+++ b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QNameModule.java
@@ -124,11 +124,8 @@ public final class QNameModule implements Comparable<QNameModule>, Immutable, Se
     @Override
     @SuppressWarnings("checkstyle:parameterName")
     public int compareTo(final QNameModule o) {
-        int cmp = namespace.compareTo(o.namespace);
-        if (cmp != 0) {
-            return cmp;
-        }
-        return Revision.compare(revision, o.revision);
+        int cmp;
+        return (cmp = namespace.compareTo(o.namespace)) != 0 ? cmp : Revision.compare(revision, o.revision);
     }
 
     /**