Modernize mocking in yang-data-api

[yangtools.git] / data / yang-data-api / src / test / java / org / opendaylight / yangtools / yang / data / api / schema / DuplicityTest.java

diff --git a/data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/DuplicityTest.java b/data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/DuplicityTest.java
index c1a88124367d4a79b3dfb626febc8609f66811d0..ce5b7440dd3549e94db91cecf75e7c30461abb03 100644 (file)
--- a/data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/DuplicityTest.java
+++ b/data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/DuplicityTest.java
@@ -8,15 +8,32 @@
 package org.opendaylight.yangtools.yang.data.api.schema;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.doReturn;
 
+import java.util.List;
 import java.util.Map;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+// FIXME: This is a sorry-ass of a test. Move the method, DuplicateFinder and this test to yang-data-util and expand
+//        coverage using ImmutableNodes.
+class DuplicityTest {
+    @Mock
+    private LeafNode<?> leaf;
+    @Mock
+    private ContainerNode container;
+
+    @Test
+    public void testDuplicateLeaf() {
+        assertEquals(Map.of(), NormalizedNodes.findDuplicates(leaf));
+    }
 
-public class DuplicityTest {
     @Test
-    public void testDuplicate() {
-        assertEquals(Map.of(), NormalizedNodes.findDuplicates(mock(LeafNode.class)));
-        assertEquals(Map.of(), NormalizedNodes.findDuplicates(mock(ContainerNode.class)));
+    public void testDuplicateContainer() {
+        doReturn(List.of()).when(container).body();
+        assertEquals(Map.of(), NormalizedNodes.findDuplicates(container));
     }
 }