import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
+import static org.opendaylight.mdsal.dom.broker.TestUtils.TEST_CHILD;
import com.google.common.collect.Multimap;
import com.google.common.util.concurrent.ListenableFuture;
-import com.lmax.disruptor.PhasedBackoffWaitStrategy;
-import com.lmax.disruptor.WaitStrategy;
-
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
-import javax.annotation.Nonnull;
-
import org.junit.Test;
import org.opendaylight.mdsal.dom.api.DOMNotification;
import org.opendaylight.mdsal.dom.api.DOMNotificationListener;
import org.opendaylight.mdsal.dom.api.DOMNotificationPublishService;
+import org.opendaylight.mdsal.dom.broker.util.TestModel;
import org.opendaylight.mdsal.dom.spi.DOMNotificationSubscriptionListener;
-import org.opendaylight.yangtools.concepts.ListenerRegistration;
+import org.opendaylight.yangtools.concepts.AbstractListenerRegistration;
import org.opendaylight.yangtools.util.ListenerRegistry;
-import org.opendaylight.yangtools.yang.model.api.SchemaPath;
+import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Absolute;
-public class DOMNotificationRouterTest extends TestUtils {
-
- private static final WaitStrategy DEFAULT_STRATEGY = PhasedBackoffWaitStrategy.withLock(
- 1L, 30L, TimeUnit.MILLISECONDS);
+public class DOMNotificationRouterTest {
@Test
public void create() throws Exception {
- assertNotNull(DOMNotificationRouter.create(1,1,1,TimeUnit.SECONDS));
- assertNotNull(DOMNotificationRouter.create(1));
+ assertNotNull(DOMNotificationRouter.create(1024));
}
@SuppressWarnings("checkstyle:IllegalCatch")
public void complexTest() throws Exception {
final DOMNotificationSubscriptionListener domNotificationSubscriptionListener =
mock(DOMNotificationSubscriptionListener.class);
+ doNothing().when(domNotificationSubscriptionListener).onSubscriptionChanged(any());
+
final CountDownLatch latch = new CountDownLatch(1);
final DOMNotificationListener domNotificationListener = new TestListener(latch);
- final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1);
+ final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1024);
- Multimap<SchemaPath, ?> listeners = domNotificationRouter.listeners();
+ Multimap<Absolute, ?> listeners = domNotificationRouter.listeners();
assertTrue(listeners.isEmpty());
- assertNotNull(domNotificationRouter.registerNotificationListener(domNotificationListener, SchemaPath.ROOT));
- assertNotNull(domNotificationRouter.registerNotificationListener(domNotificationListener, SchemaPath.SAME));
+ assertNotNull(domNotificationRouter.registerNotificationListener(domNotificationListener,
+ Absolute.of(TestModel.TEST_QNAME)));
+ assertNotNull(domNotificationRouter.registerNotificationListener(domNotificationListener,
+ Absolute.of(TestModel.TEST2_QNAME)));
listeners = domNotificationRouter.listeners();
ListenerRegistry<DOMNotificationSubscriptionListener> subscriptionListeners =
domNotificationRouter.subscriptionListeners();
- assertFalse(subscriptionListeners.iterator().hasNext());
+ assertEquals(0, subscriptionListeners.streamListeners().count());
assertNotNull(domNotificationRouter.registerSubscriptionListener(domNotificationSubscriptionListener));
subscriptionListeners = domNotificationRouter.subscriptionListeners();
- assertTrue(subscriptionListeners.iterator().hasNext());
+ assertSame(domNotificationSubscriptionListener,
+ subscriptionListeners.streamListeners().findAny().orElseThrow());
final DOMNotification domNotification = mock(DOMNotification.class);
doReturn("test").when(domNotification).toString();
- doReturn(SchemaPath.ROOT).when(domNotification).getType();
+ doReturn(Absolute.of(TestModel.TEST_QNAME)).when(domNotification).getType();
doReturn(TEST_CHILD).when(domNotification).getBody();
assertNotNull(domNotificationRouter.offerNotification(domNotification));
assertNotNull(domNotificationRouter.offerNotification(domNotification, 1, TimeUnit.SECONDS));
assertNotNull(domNotificationRouter.offerNotification(domNotification, 1, TimeUnit.SECONDS));
} catch (Exception e) {
+ // FIXME: what is the point here?!
assertTrue(e instanceof UnsupportedOperationException);
}
@Test
public void offerNotification() throws Exception {
- final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1);
+ final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1024);
final DOMNotification domNotification = mock(DOMNotification.class);
- doReturn(SchemaPath.ROOT).when(domNotification).getType();
+ doReturn(Absolute.of(TestModel.TEST_QNAME)).when(domNotification).getType();
doReturn(TEST_CHILD).when(domNotification).getBody();
assertNotNull(domNotificationRouter.putNotification(domNotification));
assertNotNull(domNotificationRouter.offerNotification(domNotification));
final TestListener testListener = new TestListener(latch);
final DOMNotification domNotification = mock(DOMNotification.class);
doReturn("test").when(domNotification).toString();
- doReturn(SchemaPath.ROOT).when(domNotification).getType();
+ doReturn(Absolute.of(TestModel.TEST_QNAME)).when(domNotification).getType();
doReturn(TEST_CHILD).when(domNotification).getBody();
- final TestRouter testRouter = TestRouter.create(1);
- assertNotNull(testRouter.registerNotificationListener(testListener, SchemaPath.ROOT));
- assertNotNull(testRouter.registerNotificationListener(testListener, SchemaPath.SAME));
- assertNotEquals(DOMNotificationPublishService.REJECTED,
- testRouter.offerNotification(domNotification, 3, TimeUnit.SECONDS));
- assertTrue("Listener was not notified", latch.await(5, TimeUnit.SECONDS));
- assertEquals("Received notifications", 1, testListener.getReceivedNotifications().size());
+ try (TestRouter testRouter = new TestRouter(1)) {
+ assertNotNull(testRouter.registerNotificationListener(testListener, Absolute.of(TestModel.TEST_QNAME)));
+ assertNotNull(testRouter.registerNotificationListener(testListener, Absolute.of(TestModel.TEST2_QNAME)));
- assertEquals(DOMNotificationPublishService.REJECTED,
- testRouter.offerNotification(domNotification, 1, TimeUnit.SECONDS));
- assertEquals("Received notifications", 1, testListener.getReceivedNotifications().size());
+ assertNotEquals(DOMNotificationPublishService.REJECTED,
+ testRouter.offerNotification(domNotification, 3, TimeUnit.SECONDS));
+ assertTrue("Listener was not notified", latch.await(5, TimeUnit.SECONDS));
+ assertEquals("Received notifications", 1, testListener.getReceivedNotifications().size());
+ assertEquals(DOMNotificationPublishService.REJECTED,
+ testRouter.offerNotification(domNotification, 1, TimeUnit.SECONDS));
+ assertEquals("Received notifications", 1, testListener.getReceivedNotifications().size());
+ }
}
@Test
public void close() throws Exception {
- final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1);
-
+ final DOMNotificationRouter domNotificationRouter = DOMNotificationRouter.create(1024);
final ExecutorService executor = domNotificationRouter.executor();
+ final ExecutorService observer = domNotificationRouter.observer();
assertFalse(executor.isShutdown());
+ assertFalse(observer.isShutdown());
domNotificationRouter.close();
assertTrue(executor.isShutdown());
+ assertTrue(observer.isShutdown());
}
private static class TestListener implements DOMNotificationListener {
}
@Override
- public void onNotification(@Nonnull final DOMNotification notification) {
+ public void onNotification(final DOMNotification notification) {
receivedNotifications.add(notification);
latch.countDown();
}
private static class TestRouter extends DOMNotificationRouter {
- TestRouter(ExecutorService executor, int queueDepth, WaitStrategy strategy) {
- super(executor, queueDepth, strategy);
+ private boolean triggerRejected = false;
+
+ TestRouter(final int queueDepth) {
+ super(queueDepth);
}
- protected ListenableFuture<? extends Object> tryPublish(final DOMNotification notification,
- final Collection<ListenerRegistration<? extends DOMNotificationListener>> subscribers) {
- return DOMNotificationPublishService.REJECTED;
+ @Override
+ ListenableFuture<? extends Object> publish(final DOMNotification notification,
+ final Collection<AbstractListenerRegistration<? extends DOMNotificationListener>> subscribers) {
+ if (triggerRejected) {
+ return REJECTED;
+ }
+
+ triggerRejected = true;
+ return super.publish(notification, subscribers);
}
@Override
Thread.sleep(2000);
return super.putNotification(notification);
}
-
- public static TestRouter create(int queueDepth) {
- final ExecutorService executor = Executors.newCachedThreadPool();
-
- return new TestRouter(executor, queueDepth, DEFAULT_STRATEGY);
- }
}
}
Code Review / mdsal.git / blobdiff