import org.opendaylight.yangtools.yang.binding.Augmentable;
import org.opendaylight.yangtools.yang.binding.Augmentation;
import org.opendaylight.yangtools.yang.binding.DataObject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Provides augmentation resolving upon given {@link Augmentable}.
* @param <G> grouping
*/
public class GroupingLooseResolver<G> {
+ private static final Logger LOG = LoggerFactory.getLogger(GroupingLooseResolver.class);
- private Class<G> commonInterface;
- private Set<Class<? extends Augmentation<?>>> classes;
+ private final Class<G> commonInterface;
+ private final Set<Class<? extends Augmentation<?>>> classes;
/**
+ * Constructor.
+ *
* @param commonInterface common interface
*/
public GroupingLooseResolver(Class<G> commonInterface) {
}
/**
- * Get augmentation classes
+ * Get augmentation classes.
+ *
* @return list of augmentation classes
*/
public Set<Class<? extends Augmentation<?>>> getClasses() {
}
/**
+ * Adds an augmentation class.
+ *
* @param cls equivalent augmentation class
* @return this for chaining
*/
}
/**
+ * Gets the extension for the give data.
+ *
* @param data expected to match <tt><T extends Augmentable<T>></tt>
* @return shared grouping
*/
@SuppressWarnings("unchecked")
public <T extends Augmentable<T>> Optional<G> getExtension(DataObject data) {
- T guessData = (T) data;
+ // The type of 'data' should really be T for compile-time checking. Several call sites do not pass an
+ // Augmentable DataObject type which would result in a ClassCastException at runtime. This is clearly
+ // broken - those call sites need to be analyzed to determine the correct behavior in order for this method
+ // signature to be changed but for now catch ClassCastException.
+ T guessData;
+ try {
+ guessData = (T) data;
+ } catch (ClassCastException e) {
+ LOG.warn("Cannot cast to Augmentable", e);
+ return Optional.empty();
+ }
for (Class<? extends Augmentation<?>> cls : classes) {
Augmentation<T> potential = guessData
- .getAugmentation((Class<Augmentation<T>>) cls);
+ .augmentation((Class<Augmentation<T>>) cls);
if (potential != null) {
return Optional.of((G) potential);
}
return Optional.empty();
}
-
}