Merge "Change l2switch max host test"

[releng/builder.git] / jjb / opendaylight-infra-update-image-list.sh

diff --git a/jjb/opendaylight-infra-update-image-list.sh b/jjb/opendaylight-infra-update-image-list.sh
index 7c7e3c93eb779f38e6c317fecd6dccfb3ad7e186..871bdd5aa58db2ae327515e2dadc68bd736f3df7 100644 (file)
--- a/jjb/opendaylight-infra-update-image-list.sh
+++ b/jjb/opendaylight-infra-update-image-list.sh
@@ -1,20 +1,21 @@
 #!/bin/bash
-virtualenv $WORKSPACE/.venv
-source $WORKSPACE/.venv/bin/activate
+virtualenv "$WORKSPACE/.venv"
+# shellcheck disable=SC1090
+source "$WORKSPACE/.venv/bin/activate"
 pip install --upgrade --quiet pip
 pip install --upgrade --quiet python-openstackclient python-heatclient
 pip freeze
 
-cat > $WORKSPACE/docs/cloud-images.rst << EOF
+cat > "$WORKSPACE/docs/cloud-images.rst" << EOF
 Following are the list of published images available to be used with Jenkins jobs.
 
 EOF
 # Blank line before EOF is on purpose to ensure there is spacing.
 
 IFS=$'\n'
-IMAGES=(`openstack --os-cloud odlpriv image list --public -f value -c Name`)
-for i in ${IMAGES[@]}; do
-    echo "* $i" >> $WORKSPACE/docs/cloud-images.rst
+IMAGES=($(openstack image list --public -f value -c Name))
+for i in "${IMAGES[@]}"; do
+    echo "* $i" >> "$WORKSPACE/docs/cloud-images.rst"
 done
 
 git add docs/cloud-images.rst