Merge changes from topic 'cleanup-maven'

[releng/builder.git] / jjb / packaging / test-rpm-deps.sh

diff --git a/jjb/packaging/test-rpm-deps.sh b/jjb/packaging/test-rpm-deps.sh
index 987d4ce9d794d62cee6c98446fa6ee0ca5ae416f..2bb0db6dbda972cc7368a4dfee44ae40dd9e008d 100644 (file)
--- a/jjb/packaging/test-rpm-deps.sh
+++ b/jjb/packaging/test-rpm-deps.sh
@@ -6,12 +6,29 @@
 #   -o pipefail: Fail on errors in scripts this calls, give stacktrace
 set -ex -o pipefail
 
+# Verify exactly 1 RPM is in the path we expect
+set -- /home/$USER/rpmbuild/RPMS/noarch/*.rpm
+if [ $# -eq 1 ]; then
+    echo "Found one RPM in build out dir, as expected"
+else
+    echo "Expected 1 RPM, found $#"
+    echo 1
+fi
+
+# If path is globbed (/path/to/*.rpm), expand it
+path=$(sudo find / -wholename /home/$USER/rpmbuild/RPMS/noarch/*.rpm)
+
+# If no RPM found, fail clearly
+if [ -z $path ]; then
+    echo "RPM not found"
+    exit 1
+fi
+
 # Requirements for package where SRPM was built into noarch on CentOS CBS
 # rpm -qp opendaylight-8.0.0-0.1.20171125rel2049.el7.noarch.rpm --requires
 # shellcheck disable=SC2034
 declare -a expected_deps=( "/bin/bash"
                            "/bin/sh"
-                           "/usr/bin/env"
                            "java >= 1:1.8.0"
                            "rpmlib(CompressedFileNames) <= 3.0.4-1"
                            "rpmlib(FileDigests) <= 4.6.0-1"
@@ -20,19 +37,24 @@ declare -a expected_deps=( "/bin/bash"
                            "shadow-utils"
                            "rpmlib(PayloadIsXz) <= 5.2-1" )
 
+# Karaf 4 distros also have a /usr/bin/env requirement INTPAK-120
+if [[ ! $path == *opendaylight-6*  ]]; then
+    expected_deps+=( "/usr/bin/env" )
+fi
+
 # shellcheck disable=SC2034
 mapfile -t actual_deps < <( rpm -qp /home/$USER/rpmbuild/RPMS/noarch/*.rpm --requires )
 # shellcheck disable=SC2154 disable=SC2145
-printf '%s\n' "${{actual_deps[@]}}"
+printf 'Dependency found: %s\n' "${actual_deps[@]}"
 
-# shellcheck disable=SC2154 disable=SC2145 disable=SC2034
-diff_deps=(`echo "${{expected_deps[@]}}" "${{actual_deps[@]}}" | tr ' ' '\n' | sort | uniq -u `)
+# shellcheck disable=SC2154,SC2145,SC2034,SC2207
+diff_deps=(`echo "${expected_deps[@]}" "${actual_deps[@]}" | tr ' ' '\n' | sort | uniq -u`)
 # shellcheck disable=SC2154 disable=SC2145 disable=SC2068 disable=SC2170 disable=SC1083
-if [ ${{#diff_deps[*]}} -eq 0 ]; then
+if [ ${#diff_deps[*]} -eq 0 ]; then
     echo "RPM requirements are as expected"
 else
     echo "RPM requirements don't match the expected requirements"
     # shellcheck disable=SC2154 disable=SC2145
-    printf '%s\n' "${{diff_deps[@]}}"
+    printf 'Dependency mismatch: %s\n' ${diff_deps[@]}
     exit 1
 fi