OPNFLWPLUG-1032: Neon-MRI: Bump odlparent, yangtools, mdsal

[openflowplugin.git] / libraries / liblldp / src / main / java / org / opendaylight / openflowplugin / libraries / liblldp / Packet.java

diff --git a/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Packet.java b/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Packet.java
index 4183cc7c5d4455b293354eb899e80e405aea47bc..1516749232ad1d6f07bce1b92dd72ffe904ef002 100644 (file)
--- a/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Packet.java
+++ b/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Packet.java
@@ -5,7 +5,6 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.libraries.liblldp;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -17,26 +16,35 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * Abstract class which represents the generic network packet object It provides
+ * Abstract class which represents the generic network packet object. It provides
  * the basic methods which are common for all the packets, like serialize and
  * deserialize.
  */
 public abstract class Packet {
-    protected static final Logger LOG = LoggerFactory.getLogger(Packet.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(Packet.class);
+
     // Access level granted to this packet
     protected boolean writeAccess;
+
     // When deserialized from wire, packet could result corrupted
     protected boolean corrupted;
+
     // The packet that encapsulate this packet
     protected Packet parent;
+
     // The packet encapsulated by this packet
     protected Packet payload;
+
     // The unparsed raw payload carried by this packet
     protected byte[] rawPayload;
+
     // Bit coordinates of packet header fields
     protected Map<String, Pair<Integer, Integer>> hdrFieldCoordMap;
+
     // Header fields values: Map<FieldName,Value>
     protected Map<String, byte[]> hdrFieldsMap;
+
     // The class of the encapsulated packet object
     protected Class<? extends Packet> payloadClass;
 
@@ -93,7 +101,7 @@ public abstract class Packet {
             startOffset = bitOffset + this.getfieldOffset(hdrField);
             numBits = this.getfieldnumBits(hdrField);
 
-            byte[] hdrFieldBytes = null;
+            byte[] hdrFieldBytes;
             try {
                 hdrFieldBytes = BitBufferHelper.getBits(data, startOffset,
                         numBits);
@@ -187,7 +195,7 @@ public abstract class Packet {
         postSerializeCustomOperation(packetBytes);
 
         if (LOG.isTraceEnabled()) {
-            LOG.trace("{}: {}", this.getClass().getSimpleName(),
+            LOG.trace("packet {}: {}", this.getClass().getSimpleName(),
                     HexEncode.bytesToHexString(packetBytes));
         }