import static org.opendaylight.mdsal.binding.testutils.AssertDataObjects.assertEqualBeans;
import static org.opendaylight.yangtools.testutils.mockito.MoreAnswers.realOrException;
+import com.google.common.collect.ComparisonChain;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.util.concurrent.Futures;
import java.math.BigInteger;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.mockito.Mockito;
import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
import org.opendaylight.genius.mdsalutil.FlowEntity;
import org.opendaylight.genius.mdsalutil.interfaces.IMdsalApiManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Fake IMdsalApiManager useful for tests.
*/
public abstract class TestIMdsalApiManager implements IMdsalApiManager {
+ private static final Logger LOG = LoggerFactory.getLogger(TestIMdsalApiManager.class);
+
private List<FlowEntity> flows;
public static TestIMdsalApiManager newInstance() {
// TODO Support Iterable <-> List directly within XtendBeanGenerator
List<FlowEntity> expectedFlowsAsNewArrayList = Lists.newArrayList(expectedFlows);
+ List<FlowEntity> sortedFlows = sortFlows(flows);
+ List<FlowEntity> sortedExpectedFlows = sortFlows(expectedFlowsAsNewArrayList);
+
// FYI: This containsExactlyElementsIn() assumes that FlowEntity, and everything in it,
// has correctly working equals() implementations. assertEqualBeans() does not assume
// that, and would work even without equals, because it only uses property reflection.
// is not a good idea (different instances can have same hashCode), and e.g. on
// System#identityHashCode even less so.
try {
- assertThat(flows).containsExactlyElementsIn(expectedFlowsAsNewArrayList);
+ assertThat(sortedFlows).containsExactlyElementsIn(sortedExpectedFlows);
} catch (AssertionError e) {
+ // We LOG the AssertionError just for clarity why containsExactlyElementsIn() failed
+ LOG.warn("assert containsExactlyElementsIn() failed", e);
+ // We LOG the expected and actual flow in case of a failed assertion
+ // because, even though that is typically just a HUGE String that's
+ // hard to read (the diff printed subsequently by assertEqualBeans
+ // is, much, more readable), there are cases when looking more closely
+ // at the full toString() output of the flows is still useful, so:
+ LOG.warn("assert failed [order ignored!]; expected flows: {}", sortedExpectedFlows);
+ LOG.warn("assert failed [order ignored!]; actual flows : {}", sortedFlows);
// The point of this is basically just that our assertEqualBeans output,
// in case of a comparison failure, is *A LOT* more clearly readable
// than what G Truth (or Hamcrest) can do based on toString.
- assertEqualBeans(expectedFlowsAsNewArrayList, flows);
+ assertEqualBeans(sortedExpectedFlows, sortedFlows);
}
}
+ private List<FlowEntity> sortFlows(Iterable<FlowEntity> flowsToSort) {
+ List<FlowEntity> sortedFlows = Lists.newArrayList(flowsToSort);
+ Collections.sort(sortedFlows,
+ (flow1, flow2) -> ComparisonChain.start()
+ .compare(flow1.getTableId(), flow2.getTableId())
+ .compare(flow1.getPriority(), flow2.getPriority())
+ .compare(flow1.getFlowId(), flow2.getFlowId())
+ .result());
+ return sortedFlows;
+ }
+
@Override
public synchronized void installFlow(FlowEntity flowEntity) {
getOrNewFlows().add(flowEntity);
}
+ @Override
+ public synchronized CheckedFuture<Void, TransactionCommitFailedException> installFlow(BigInteger dpId,
+ FlowEntity flowEntity) {
+ installFlow(flowEntity);
+ return Futures.immediateCheckedFuture(null);
+ }
+
@Override
public synchronized CheckedFuture<Void, TransactionCommitFailedException> removeFlow(BigInteger dpnId,
FlowEntity flowEntity) {
}
@Override
- public void batchedAddFlow(BigInteger dpId, FlowEntity flowEntity) {
+ public synchronized void batchedAddFlow(BigInteger dpId, FlowEntity flowEntity) {
getOrNewFlows().add(flowEntity);
}
@Override
- public void batchedRemoveFlow(BigInteger dpId, FlowEntity flowEntity) {
+ public synchronized void batchedRemoveFlow(BigInteger dpId, FlowEntity flowEntity) {
getOrNewFlows().remove(flowEntity);
}