* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.netconf.sal.connect.netconf.sal.tx;
-import com.google.common.base.Function;
-import com.google.common.base.Optional;
-import com.google.common.util.concurrent.CheckedFuture;
-import com.google.common.util.concurrent.FutureCallback;
-import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
-import org.opendaylight.controller.md.sal.common.api.TransactionStatus;
-import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
-import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+import org.opendaylight.mdsal.dom.api.DOMRpcResult;
+import org.opendaylight.netconf.api.ModifyAction;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfBaseOps;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfRpcFutureCallback;
import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId;
import org.opendaylight.yangtools.yang.common.RpcResult;
-import org.opendaylight.yangtools.yang.data.api.ModifyAction;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
import org.slf4j.LoggerFactory;
/**
- * Tx implementation for netconf devices that support only writable-running with no candidate
+ * Tx implementation for netconf devices that support only writable-running with no candidate.
* The sequence goes as:
* <ol>
* <li>Lock running datastore on tx construction
* <li>Unlock running datastore on tx commit</li>
* </ol>
*/
-//TODO replace custom RPCs future callbacks with NetconfRpcFutureCallback
public class WriteRunningTx extends AbstractWriteTx {
private static final Logger LOG = LoggerFactory.getLogger(WriteRunningTx.class);
+ private final List<Change> changes = new ArrayList<>();
public WriteRunningTx(final RemoteDeviceId id, final NetconfBaseOps netOps,
final boolean rollbackSupport) {
- super(netOps, id, rollbackSupport);
+ this(id, netOps, rollbackSupport, true);
+ }
+
+ public WriteRunningTx(final RemoteDeviceId id, final NetconfBaseOps netconfOps, final boolean rollbackSupport,
+ final boolean isLockAllowed) {
+ super(id, netconfOps, rollbackSupport, isLockAllowed);
}
@Override
}
private void lock() {
- final FutureCallback<DOMRpcResult> lockCallback = new FutureCallback<DOMRpcResult>() {
- @Override
- public void onSuccess(DOMRpcResult result) {
- if (isSuccess(result)) {
- if (LOG.isTraceEnabled()) {
- LOG.trace("Lock running succesfull");
- }
- } else {
- LOG.warn("{}: lock running invoked unsuccessfully: {}", id, result.getErrors());
- }
- }
-
- @Override
- public void onFailure(Throwable t) {
- LOG.warn("{}: Lock running operation failed. {}", id, t);
- }
- };
- resultsFutures.add(netOps.lockRunning(lockCallback));
+ if (isLockAllowed) {
+ resultsFutures.add(netOps.lockRunning(new NetconfRpcFutureCallback("Lock running", id)));
+ } else {
+ LOG.trace("Lock is not allowed: {}", id);
+ }
}
@Override
}
@Override
- public synchronized CheckedFuture<Void, TransactionCommitFailedException> submit() {
- final ListenableFuture<Void> commmitFutureAsVoid = Futures.transform(commit(), new Function<RpcResult<TransactionStatus>, Void>() {
- @Override
- public Void apply(final RpcResult<TransactionStatus> input) {
- return null;
- }
- });
-
- return Futures.makeChecked(commmitFutureAsVoid, new Function<Exception, TransactionCommitFailedException>() {
- @Override
- public TransactionCommitFailedException apply(final Exception input) {
- return new TransactionCommitFailedException("Submit of transaction " + getIdentifier() + " failed", input);
- }
- });
- }
-
- @Override
- public synchronized ListenableFuture<RpcResult<TransactionStatus>> performCommit() {
+ public synchronized ListenableFuture<RpcResult<Void>> performCommit() {
+ for (final Change change : changes) {
+ resultsFutures.add(change.execute(id, netOps, rollbackSupport));
+ }
unlock();
-
return resultsToTxStatus();
}
@Override
- protected void editConfig(final YangInstanceIdentifier path,
- final Optional<NormalizedNode<?, ?>> data,
- final DataContainerChild<?, ?> editStructure,
+ protected void editConfig(final YangInstanceIdentifier path, final Optional<NormalizedNode> data,
+ final DataContainerChild editStructure,
final Optional<ModifyAction> defaultOperation,
final String operation) {
- FutureCallback<DOMRpcResult> editConfigCallback = new FutureCallback<DOMRpcResult>() {
- @Override
- public void onSuccess(DOMRpcResult result) {
- if (isSuccess(result)) {
- if (LOG.isTraceEnabled()) {
- LOG.trace("Edit running succesfull");
- }
- } else {
- LOG.warn("{}: Edit running invoked unsuccessfully: {}", id, result.getErrors());
- }
- }
+ changes.add(new Change(editStructure, defaultOperation));
+ }
- @Override
- public void onFailure(Throwable t) {
- LOG.warn("{}: Error {} data to (running){}, data: {}", id, operation, path, data.orNull(), t);
- }
- };
- if (defaultOperation.isPresent()) {
- resultsFutures.add(
- netOps.editConfigRunning(editConfigCallback, editStructure, defaultOperation.get(), rollbackSupport));
+ private void unlock() {
+ if (isLockAllowed) {
+ netOps.unlockRunning(new NetconfRpcFutureCallback("Unlock running", id));
} else {
- resultsFutures.add(netOps.editConfigRunning(editConfigCallback, editStructure, rollbackSupport));
+ LOG.trace("Unlock is not allowed: {}", id);
}
}
- private void unlock() {
- netOps.unlockRunning(new NetconfRpcFutureCallback("Unlock running", id));
+ private static final class Change {
+
+ private final DataContainerChild editStructure;
+ private final Optional<ModifyAction> defaultOperation;
+
+ Change(final DataContainerChild editStructure, final Optional<ModifyAction> defaultOperation) {
+ this.editStructure = editStructure;
+ this.defaultOperation = defaultOperation;
+ }
+
+ ListenableFuture<? extends DOMRpcResult> execute(final RemoteDeviceId id, final NetconfBaseOps netOps,
+ final boolean rollbackSupport) {
+ final NetconfRpcFutureCallback editConfigCallback = new NetconfRpcFutureCallback("Edit running", id);
+ if (defaultOperation.isPresent()) {
+ return netOps.editConfigRunning(editConfigCallback, editStructure, defaultOperation.get(),
+ rollbackSupport);
+ } else {
+ return netOps.editConfigRunning(editConfigCallback, editStructure, rollbackSupport);
+ }
+ }
}
}
Code Review / netconf.git / blobdiff