*/
package org.opendaylight.netconf.sal.connect.netconf.sal;
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import java.net.InetSocketAddress;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.TimeUnit;
-
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import org.mockito.Matchers;
+import org.junit.runner.RunWith;
import org.mockito.Mock;
-import org.mockito.Mockito;
-import org.mockito.MockitoAnnotations;
-import org.mockito.invocation.InvocationOnMock;
-import org.mockito.stubbing.Answer;
-import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult;
-import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
-import org.opendaylight.controller.md.sal.dom.spi.DefaultDOMRpcResult;
+import org.mockito.junit.MockitoJUnitRunner;
+import org.opendaylight.mdsal.dom.api.DOMRpcService;
+import org.opendaylight.mdsal.dom.spi.DefaultDOMRpcResult;
import org.opendaylight.netconf.sal.connect.api.RemoteDeviceHandler;
+import org.opendaylight.netconf.sal.connect.api.RemoteDeviceServices;
import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfDeviceCommunicator;
-import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfSessionPreferences;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil;
import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId;
+import org.opendaylight.yangtools.util.concurrent.FluentFutures;
+import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.common.RpcError;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
+import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
import org.opendaylight.yangtools.yang.data.impl.schema.Builders;
-import org.opendaylight.yangtools.yang.model.api.SchemaContext;
-import org.opendaylight.yangtools.yang.model.api.SchemaPath;
-
-import com.google.common.util.concurrent.Futures;
+@RunWith(MockitoJUnitRunner.StrictStubs.class)
public class KeepaliveSalFacadeTest {
- private static final RemoteDeviceId REMOTE_DEVICE_ID = new RemoteDeviceId("test", new InetSocketAddress("localhost", 22));
+ private static final RemoteDeviceId REMOTE_DEVICE_ID =
+ new RemoteDeviceId("test", new InetSocketAddress("localhost", 22));
@Mock
- private RemoteDeviceHandler<NetconfSessionPreferences> underlyingSalFacade;
+ private RemoteDeviceHandler underlyingSalFacade;
private ScheduledExecutorService executorServiceSpy;
private DOMRpcService proxyRpc;
- @Mock
- private ScheduledFuture currentKeepalive;
+ private KeepaliveSalFacade keepaliveSalFacade;
@Before
public void setUp() throws Exception {
executorServiceSpy = Executors.newScheduledThreadPool(1);
- MockitoAnnotations.initMocks(this);
-
doNothing().when(listener).disconnect();
- doReturn("mockedRpc").when(deviceRpc).toString();
- doNothing().when(underlyingSalFacade).onDeviceConnected(
- any(SchemaContext.class), any(NetconfSessionPreferences.class), any(DOMRpcService.class));
-
- ScheduledExecutorService executorService = Executors.newScheduledThreadPool(1);
- executorServiceSpy = Mockito.spy(executorService);
- doAnswer(new Answer<ScheduledFuture>() {
- @Override
- public ScheduledFuture answer(InvocationOnMock invocationOnMock)
- throws Throwable {
- invocationOnMock.callRealMethod();
- return currentKeepalive;
- }
- }).when(executorServiceSpy).schedule(Mockito.<Runnable> any(),
- Mockito.anyLong(), Matchers.<TimeUnit> any());
-
- Mockito.when(currentKeepalive.isDone()).thenReturn(true);
+ doNothing().when(underlyingSalFacade).onDeviceConnected(isNull(), isNull(), any(RemoteDeviceServices.class));
+
+ keepaliveSalFacade =
+ new KeepaliveSalFacade(REMOTE_DEVICE_ID, underlyingSalFacade, executorServiceSpy, 1L, 1L);
+ keepaliveSalFacade.setListener(listener);
}
@After
@Test
public void testKeepaliveSuccess() throws Exception {
- final DOMRpcResult result = new DefaultDOMRpcResult(Builders.containerBuilder().withNodeIdentifier(
- new YangInstanceIdentifier.NodeIdentifier(NetconfMessageTransformUtil.NETCONF_RUNNING_QNAME)).build());
-
- doReturn(Futures.immediateCheckedFuture(result)).when(deviceRpc).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
-
- final KeepaliveSalFacade keepaliveSalFacade =
- new KeepaliveSalFacade(REMOTE_DEVICE_ID, underlyingSalFacade, executorServiceSpy, 1L, 1L);
- keepaliveSalFacade.setListener(listener);
+ doReturn(FluentFutures.immediateFluentFuture(new DefaultDOMRpcResult(Builders.containerBuilder()
+ .withNodeIdentifier(NetconfMessageTransformUtil.NETCONF_RUNNING_NODEID)
+ .build()))).when(deviceRpc).invokeRpc(any(QName.class), any(ContainerNode.class));
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
+ final var services = new RemoteDeviceServices(deviceRpc, null);
+ keepaliveSalFacade.onDeviceConnected(null, null, services);
- verify(underlyingSalFacade).onDeviceConnected(
- any(SchemaContext.class), any(NetconfSessionPreferences.class), any(DOMRpcService.class));
+ verify(underlyingSalFacade).onDeviceConnected(isNull(), isNull(), any(RemoteDeviceServices.class));
- verify(deviceRpc, timeout(15000).times(5)).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
+ verify(deviceRpc, timeout(15000).times(5)).invokeRpc(any(QName.class), any(ContainerNode.class));
}
@Test
- public void testKeepaliveFail() throws Exception {
- final DOMRpcResult result = new DefaultDOMRpcResult(Builders.containerBuilder().withNodeIdentifier(
- new YangInstanceIdentifier.NodeIdentifier(NetconfMessageTransformUtil.NETCONF_RUNNING_QNAME)).build());
+ public void testKeepaliveRpcFailure() {
- RpcError error = mock(RpcError.class);
- doReturn("Failure").when(error).toString();
+ doReturn(FluentFutures.immediateFailedFluentFuture(new IllegalStateException("illegal-state")))
+ .when(deviceRpc).invokeRpc(any(QName.class), any(ContainerNode.class));
- final DOMRpcResult resultFailWithResultAndError = new DefaultDOMRpcResult(mock(NormalizedNode.class), error);
+ keepaliveSalFacade.onDeviceConnected(null, null, new RemoteDeviceServices(deviceRpc, null));
- doReturn(Futures.immediateCheckedFuture(result))
- .doReturn(Futures.immediateCheckedFuture(resultFailWithResultAndError))
- .doReturn(Futures.immediateFailedCheckedFuture(new IllegalStateException("illegal-state")))
- .when(deviceRpc).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
+ verify(underlyingSalFacade).onDeviceConnected(isNull(), isNull(), any(RemoteDeviceServices.class));
- final KeepaliveSalFacade keepaliveSalFacade =
- new KeepaliveSalFacade(REMOTE_DEVICE_ID, underlyingSalFacade, executorServiceSpy, 1L, 1L);
- keepaliveSalFacade.setListener(listener);
-
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
-
- verify(underlyingSalFacade).onDeviceConnected(
- any(SchemaContext.class), any(NetconfSessionPreferences.class), any(DOMRpcService.class));
-
- // 1 failed that results in disconnect
+ // Should disconnect the session
verify(listener, timeout(15000).times(1)).disconnect();
- // 3 attempts total
- verify(deviceRpc, times(3)).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
-
- // Reconnect with same keepalive responses
- doReturn(Futures.immediateCheckedFuture(result))
- .doReturn(Futures.immediateCheckedFuture(resultFailWithResultAndError))
- .doReturn(Futures.immediateFailedCheckedFuture(new IllegalStateException("illegal-state")))
- .when(deviceRpc).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
-
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
-
- // 1 failed that results in disconnect, 2 total with previous fail
- verify(listener, timeout(15000).times(2)).disconnect();
- // 6 attempts now total
- verify(deviceRpc, times(3 * 2)).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
+ verify(deviceRpc, times(1)).invokeRpc(any(QName.class), any(ContainerNode.class));
+ }
- final DOMRpcResult resultFailwithError = new DefaultDOMRpcResult(error);
+ @Test
+ public void testKeepaliveSuccessWithRpcError() {
- doReturn(Futures.immediateCheckedFuture(resultFailwithError))
- .when(deviceRpc).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
+ final var rpcSuccessWithError = new DefaultDOMRpcResult(mock(RpcError.class));
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
+ doReturn(FluentFutures.immediateFluentFuture(rpcSuccessWithError))
+ .when(deviceRpc).invokeRpc(any(QName.class), any(ContainerNode.class));
- // 1 failed that results in disconnect, 3 total with previous fail
- verify(listener, timeout(15000).times(3)).disconnect();
+ keepaliveSalFacade.onDeviceConnected(null, null, new RemoteDeviceServices(deviceRpc, null));
+ verify(underlyingSalFacade).onDeviceConnected(isNull(), isNull(), any(RemoteDeviceServices.class));
- Mockito.when(currentKeepalive.isDone()).thenReturn(false);
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
- // 1 failed that results in disconnect, 4 total with previous fail
- verify(listener, timeout(15000).times(4)).disconnect();
+ // Shouldn't disconnect the session
+ verify(listener, times(0)).disconnect();
+ verify(deviceRpc, timeout(15000).times(1)).invokeRpc(any(QName.class), any(ContainerNode.class));
}
@Test
public void testNonKeepaliveRpcFailure() throws Exception {
- doAnswer(new Answer() {
- @Override
- public Object answer(final InvocationOnMock invocationOnMock) throws Throwable {
- proxyRpc = (DOMRpcService) invocationOnMock.getArguments()[2];
- return null;
- }
- }).when(underlyingSalFacade).onDeviceConnected(any(SchemaContext.class), any(NetconfSessionPreferences.class), any(DOMRpcService.class));
-
- doReturn(Futures.immediateFailedCheckedFuture(new IllegalStateException("illegal-state")))
- .when(deviceRpc).invokeRpc(any(SchemaPath.class), any(NormalizedNode.class));
-
- final KeepaliveSalFacade keepaliveSalFacade =
+ doAnswer(invocation -> proxyRpc = invocation.getArgument(2, RemoteDeviceServices.class).rpcs())
+ .when(underlyingSalFacade).onDeviceConnected(isNull(), isNull(), any(RemoteDeviceServices.class));
+
+ doReturn(FluentFutures.immediateFailedFluentFuture(new IllegalStateException("illegal-state")))
+ .when(deviceRpc).invokeRpc(any(QName.class), any(ContainerNode.class));
+
+ keepaliveSalFacade =
new KeepaliveSalFacade(REMOTE_DEVICE_ID, underlyingSalFacade, executorServiceSpy, 100L, 1L);
keepaliveSalFacade.setListener(listener);
- keepaliveSalFacade.onDeviceConnected(null, null, deviceRpc);
+ keepaliveSalFacade.onDeviceConnected(null, null, new RemoteDeviceServices(deviceRpc, null));
- proxyRpc.invokeRpc(mock(SchemaPath.class), mock(NormalizedNode.class));
+ proxyRpc.invokeRpc(QName.create("foo", "bar"), mock(ContainerNode.class));
verify(listener, times(1)).disconnect();
}
-}
\ No newline at end of file
+}
Code Review / netconf.git / blobdiff