package org.opendaylight.netconf.sal.connect.netconf.sal;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.eq;
+import static org.junit.Assert.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
-import static org.mockito.MockitoAnnotations.initMocks;
import java.net.InetSocketAddress;
-import java.util.Arrays;
import java.util.List;
import org.junit.Before;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Captor;
import org.mockito.Mock;
-import org.opendaylight.controller.md.sal.dom.api.DOMActionService;
-import org.opendaylight.controller.md.sal.dom.api.DOMDataBroker;
-import org.opendaylight.controller.md.sal.dom.api.DOMNotification;
-import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
+import org.mockito.junit.MockitoJUnitRunner;
+import org.opendaylight.mdsal.binding.api.DataBroker;
+import org.opendaylight.mdsal.binding.api.TransactionChain;
+import org.opendaylight.mdsal.binding.api.WriteTransaction;
+import org.opendaylight.mdsal.common.api.CommitInfo;
+import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
+import org.opendaylight.mdsal.dom.api.DOMDataBroker;
+import org.opendaylight.mdsal.dom.api.DOMNotification;
+import org.opendaylight.mdsal.dom.api.DOMRpcService;
+import org.opendaylight.netconf.dom.api.NetconfDataTreeService;
+import org.opendaylight.netconf.sal.connect.netconf.NetconfDeviceSchema;
import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfDeviceCapabilities;
import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfSessionPreferences;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil;
import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId;
-import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.node.topology.rev150114.NetconfNode;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.node.topology.rev150114.NetconfNodeConnectionStatus.ConnectionStatus;
+import org.opendaylight.yangtools.rfc8528.data.util.EmptyMountPointContext;
+import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
+@RunWith(MockitoJUnitRunner.StrictStubs.class)
public class NetconfDeviceSalFacadeTest {
+ private final RemoteDeviceId remoteDeviceId = new RemoteDeviceId("test", new InetSocketAddress("127.0.0.1", 8000));
- private NetconfDeviceSalFacade deviceFacade;
-
- @Mock
- private NetconfDeviceTopologyAdapter netconfDeviceTopologyAdapter;
@Mock
private NetconfDeviceSalProvider.MountInstance mountInstance;
-
@Mock
private NetconfDeviceSalProvider salProvider;
+ @Mock
+ private DataBroker dataBroker;
+ @Mock
+ private TransactionChain txChain;
+ @Mock
+ private WriteTransaction tx;
+ @Captor
+ private ArgumentCaptor<NetconfNode> nodeCaptor;
+
+ private NetconfDeviceSalFacade deviceFacade;
@Before
public void setUp() throws Exception {
- initMocks(this);
- final InetSocketAddress address = new InetSocketAddress("127.0.0.1", 8000);
- final RemoteDeviceId remoteDeviceId = new RemoteDeviceId("test", address);
+ doReturn(txChain).when(dataBroker).createMergingTransactionChain(any());
+ doReturn(tx).when(txChain).newWriteOnlyTransaction();
+ doNothing().when(tx).mergeParentStructurePut(eq(LogicalDatastoreType.OPERATIONAL),
+ eq(remoteDeviceId.getTopologyBindingPath().augmentation(NetconfNode.class)), nodeCaptor.capture());
+ doReturn(CommitInfo.emptyFluentFuture()).when(tx).commit();
- deviceFacade = new NetconfDeviceSalFacade(remoteDeviceId, salProvider);
+ final NetconfDeviceTopologyAdapter adapter = new NetconfDeviceTopologyAdapter(dataBroker, remoteDeviceId);
- doReturn(netconfDeviceTopologyAdapter).when(salProvider).getTopologyDatastoreAdapter();
- doNothing().when(netconfDeviceTopologyAdapter)
- .updateDeviceData(any(Boolean.class), any(NetconfDeviceCapabilities.class));
+ deviceFacade = new NetconfDeviceSalFacade(remoteDeviceId, salProvider, dataBroker, "mockTopo");
+
+ doReturn(adapter).when(salProvider).getTopologyDatastoreAdapter();
doReturn(mountInstance).when(salProvider).getMountInstance();
doNothing().when(mountInstance).onTopologyDeviceDisconnected();
public void testOnDeviceDisconnected() {
deviceFacade.onDeviceDisconnected();
- verify(netconfDeviceTopologyAdapter).updateDeviceData(eq(false), any(NetconfDeviceCapabilities.class));
+ verifyConnectionStatusUpdate(ConnectionStatus.Connecting);
verify(mountInstance, times(1)).onTopologyDeviceDisconnected();
-
}
@Test
final Throwable throwable = new Throwable();
deviceFacade.onDeviceFailed(throwable);
- verify(netconfDeviceTopologyAdapter).setDeviceAsFailed(throwable);
+ verifyConnectionStatusUpdate(ConnectionStatus.UnableToConnect);
verify(mountInstance, times(1)).onTopologyDeviceDisconnected();
}
@Test
public void testOnDeviceConnected() {
- final SchemaContext schemaContext = mock(SchemaContext.class);
+ final EffectiveModelContext schemaContext = mock(EffectiveModelContext.class);
- final NetconfSessionPreferences netconfSessionPreferences =
- NetconfSessionPreferences.fromStrings(getCapabilities());
+ final var netconfSessionPreferences = NetconfSessionPreferences.fromStrings(
+ List.of(NetconfMessageTransformUtil.NETCONF_CANDIDATE_URI.toString()));
final DOMRpcService deviceRpc = mock(DOMRpcService.class);
- deviceFacade.onDeviceConnected(schemaContext, netconfSessionPreferences, deviceRpc, null);
+ deviceFacade.onDeviceConnected(
+ new NetconfDeviceSchema(NetconfDeviceCapabilities.empty(), new EmptyMountPointContext(schemaContext)),
+ netconfSessionPreferences, deviceRpc, null);
+ verifyConnectionStatusUpdate(ConnectionStatus.Connected);
verify(mountInstance, times(1)).onTopologyDeviceConnected(eq(schemaContext),
- any(DOMDataBroker.class), eq(deviceRpc), any(NetconfDeviceNotificationService.class),
- any(DOMActionService.class));
- verify(netconfDeviceTopologyAdapter,
- times(1)).updateDeviceData(true, netconfSessionPreferences.getNetconfDeviceCapabilities());
+ any(DOMDataBroker.class), any(NetconfDataTreeService.class), eq(deviceRpc),
+ any(NetconfDeviceNotificationService.class), isNull());
}
@Test
verify(mountInstance).publish(domNotification);
}
- private static List<String> getCapabilities() {
- return Arrays.asList(NetconfMessageTransformUtil.NETCONF_CANDIDATE_URI.toString());
+ private void verifyConnectionStatusUpdate(final ConnectionStatus expectedStatus) {
+ verify(tx).mergeParentStructurePut(eq(LogicalDatastoreType.OPERATIONAL),
+ eq(remoteDeviceId.getTopologyBindingPath().augmentation(NetconfNode.class)), any());
+ assertEquals(expectedStatus, nodeCaptor.getValue().getConnectionStatus());
}
}