import com.google.common.base.Preconditions;
import com.google.common.io.CharStreams;
import com.google.common.io.Files;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.StringJoiner;
import net.sourceforge.argparse4j.inf.ArgumentParser;
import net.sourceforge.argparse4j.inf.ArgumentParserException;
+@SuppressFBWarnings({"DM_EXIT", "DM_DEFAULT_ENCODING"})
public class TesttoolParameters {
private static final String HOST_KEY = "{HOST}";
private static final String PORT_KEY = "{PORT}";
private static final String TCP_ONLY = "{TCP_ONLY}";
private static final String ADDRESS_PORT = "{ADDRESS:PORT}";
- private static final String dest = "http://{ADDRESS:PORT}/restconf/config/network-topology:network-topology/topology/topology-netconf/";
- private static final Pattern YANG_FILENAME_PATTERN = Pattern.compile("(?<name>.*)@(?<revision>\\d{4}-\\d{2}-\\d{2})\\.yang");
+ private static final String DEST =
+ "http://{ADDRESS:PORT}/restconf/config/network-topology:network-topology/topology/topology-netconf/";
+ private static final Pattern YANG_FILENAME_PATTERN = Pattern
+ .compile("(?<name>.*)@(?<revision>\\d{4}-\\d{2}-\\d{2})\\.yang");
private static final Pattern DATE_PATTERN = Pattern.compile("(\\d{4}-\\d{2}-\\d{2})");
private static final String RESOURCE = "/config-template.json";
@Arg(dest = "time-out")
public long timeOut;
private InputStream stream;
-
@Arg(dest = "ip")
public String ip;
-
@Arg(dest = "thread-pool-size")
public int threadPoolSize;
+ @Arg(dest = "rpc-config")
+ public File rpcConfig;
+ @SuppressWarnings("checkstyle:lineLength")
static ArgumentParser getParser() {
final ArgumentParser parser = ArgumentParsers.newArgumentParser("netconf testtool");
parser.addArgument("--async-requests")
.type(Boolean.class)
- .setDefault(false)
+ .setDefault(Boolean.FALSE)
.dest("async");
parser.addArgument("--thread-amount")
parser.addArgument("--throttle")
.type(Integer.class)
.setDefault(5000)
- .help("Maximum amount of async requests that can be open at a time, " +
- "with mutltiple threads this gets divided among all threads")
+ .help("Maximum amount of async requests that can be open at a time, "
+ + "with mutltiple threads this gets divided among all threads")
.dest("throttle");
parser.addArgument("--auth")
parser.addArgument("--controller-destination")
.type(String.class)
- .help("Ip address and port of controller. Must be in following format <ip>:<port> " +
- "if available it will be used for spawning netconf connectors via topology configuration as " +
- "a part of URI. Example (http://<controller destination>/restconf/config/network-topology:network-topology/topology/topology-netconf/node/<node-id>)" +
- "otherwise it will just start simulated devices and skip the execution of PUT requests")
+ .help("Ip address and port of controller. Must be in following format <ip>:<port> "
+ + "if available it will be used for spawning netconf connectors via topology configuration as "
+ + "a part of URI. Example (http://<controller destination>/restconf/config/network-topology:network-topology/topology/topology-netconf/node/<node-id>)"
+ + "otherwise it will just start simulated devices and skip the execution of PUT requests")
.dest("controller-destination");
parser.addArgument("--device-count")
parser.addArgument("--ssh")
.type(Boolean.class)
- .setDefault(true)
+ .setDefault(Boolean.TRUE)
.help("Whether to use ssh for transport or just pure tcp")
.dest("ssh");
parser.addArgument("--exi")
.type(Boolean.class)
- .setDefault(true)
+ .setDefault(Boolean.TRUE)
.help("Whether to use exi to transport xml content")
.dest("exi");
parser.addArgument("--debug")
.type(Boolean.class)
- .setDefault(false)
+ .setDefault(Boolean.FALSE)
.help("Whether to use debug log level instead of INFO")
.dest("debug");
parser.addArgument("--md-sal")
.type(Boolean.class)
- .setDefault(false)
+ .setDefault(Boolean.FALSE)
.help("Whether to use md-sal datastore instead of default simulated datastore.")
.dest("md-sal");
parser.addArgument("-ip")
.type(String.class)
.setDefault("0.0.0.0")
- .help("Ip address which will be used for creating a socket address." +
- "It can either be a machine name, such as " +
- "java.sun.com, or a textual representation of its IP address.")
+ .help("Ip address which will be used for creating a socket address."
+ + "It can either be a machine name, such as "
+ + "java.sun.com, or a textual representation of its IP address.")
.dest("ip");
parser.addArgument("--thread-pool-size")
.setDefault(8)
.help("The number of threads to keep in the pool, when creating a device simulator. Even if they are idle.")
.dest("thread-pool-size");
+ parser.addArgument("--rpc-config")
+ .type(File.class)
+ .help("Rpc config file. It can be used to define custom rpc behavior, or override the default one."
+ + "Usable for testing buggy device behavior.")
+ .dest("rpc-config");
return parser;
}
return payloadBuilder.toString();
}
+ @SuppressWarnings("checkstyle:regexpSinglelineJava")
void validate() {
if (editContent == null) {
stream = TesttoolParameters.class.getResourceAsStream(RESOURCE);
}
if (controllerDestination != null) {
- Preconditions.checkArgument(controllerDestination.contains(":"), "Controller Destination needs to be in a following format <ip>:<port>");
+ Preconditions.checkArgument(controllerDestination.contains(":"),
+ "Controller Destination needs to be in a following format <ip>:<port>");
final String[] parts = controllerDestination.split(Pattern.quote(":"));
Preconditions.checkArgument(Integer.parseInt(parts[1]) > 0, "Port =< 0");
}
checkArgument(schemasDir.isDirectory(), "Schemas dir has to be a directory");
checkArgument(schemasDir.canRead(), "Schemas dir has to be readable");
- final List<File> files = Arrays.asList(schemasDir.listFiles());
+ final File[] filesArray = schemasDir.listFiles();
+ final List<File> files = filesArray != null ? Arrays.asList(filesArray) : Collections.emptyList();
for (final File file : files) {
final Matcher matcher = YANG_FILENAME_PATTERN.matcher(file.getName());
if (!matcher.matches()) {
- final BufferedReader reader;
- try {
- reader = new BufferedReader(new FileReader(file));
+ try (BufferedReader reader = new BufferedReader(new FileReader(file))) {
String line = reader.readLine();
while (!DATE_PATTERN.matcher(line).find()) {
line = reader.readLine();
final String revision = m.group(1);
final String correctName = moduleName + "@" + revision + ".yang";
final File correctNameFile = new File(correctName);
- file.renameTo(correctNameFile);
+ if (!file.renameTo(correctNameFile)) {
+ System.err.println("Failed to rename " + file);
+ }
}
-
} catch (final IOException e) {
+ // print error to console (test tool is running from console)
e.printStackTrace();
}
}
}
}
+ if (rpcConfig != null) {
+ checkArgument(rpcConfig.exists(), "Rpc config file has to exist");
+ checkArgument(!rpcConfig.isDirectory(), "Rpc config file can't be a directory");
+ checkArgument(rpcConfig.canRead(), "Rpc config file to be readable");
+ }
}
public ArrayList<ArrayList<Execution.DestToPayload>> getThreadsPayloads(final List<Integer> openDevices) {
final String editContentString;
try {
if (stream == null) {
- editContentString = Files.toString(editContent, StandardCharsets.UTF_8);
+ editContentString = Files.asCharSource(editContent, StandardCharsets.UTF_8).read();
} else {
editContentString = CharStreams.toString(new InputStreamReader(stream, StandardCharsets.UTF_8));
}
} catch (final IOException e) {
- throw new IllegalArgumentException("Cannot read content of " + editContent);
+ throw new IllegalArgumentException("Cannot read content of " + editContent, e);
}
- int from, to;
+ int from;
+ int to;
Iterator<Integer> iterator;
final ArrayList<ArrayList<Execution.DestToPayload>> allThreadsPayloads = new ArrayList<>();
final int batchedRequests = openDevices.size() / generateConfigBatchSize;
final int batchedRequestsPerThread = batchedRequests / threadAmount;
- final int leftoverBatchedRequests = (batchedRequests) % threadAmount;
- final int leftoverRequests = openDevices.size() - (batchedRequests * generateConfigBatchSize);
+ final int leftoverBatchedRequests = batchedRequests % threadAmount;
+ final int leftoverRequests = openDevices.size() - batchedRequests * generateConfigBatchSize;
- final StringBuilder destBuilder = new StringBuilder(dest);
- destBuilder.replace(destBuilder.indexOf(ADDRESS_PORT), destBuilder.indexOf(ADDRESS_PORT) + ADDRESS_PORT.length(), controllerDestination);
+ final StringBuilder destBuilder = new StringBuilder(DEST);
+ destBuilder.replace(destBuilder.indexOf(ADDRESS_PORT),
+ destBuilder.indexOf(ADDRESS_PORT) + ADDRESS_PORT.length(),
+ controllerDestination);
for (int l = 0; l < threadAmount; l++) {
- from = l * (batchedRequests * batchedRequestsPerThread);
- to = from + (batchedRequests * batchedRequestsPerThread);
+ from = l * batchedRequests * batchedRequestsPerThread;
+ to = from + batchedRequests * batchedRequestsPerThread;
iterator = openDevices.subList(from, to).iterator();
- allThreadsPayloads.add(createBatchedPayloads(batchedRequestsPerThread, iterator, editContentString, destBuilder.toString()));
+ allThreadsPayloads.add(createBatchedPayloads(batchedRequestsPerThread, iterator, editContentString,
+ destBuilder.toString()));
}
ArrayList<Execution.DestToPayload> payloads = null;
if (leftoverBatchedRequests > 0) {
- from = threadAmount * (batchedRequests * batchedRequestsPerThread);
- to = from + (batchedRequests * batchedRequestsPerThread);
+ from = threadAmount * batchedRequests * batchedRequestsPerThread;
+ to = from + batchedRequests * batchedRequestsPerThread;
iterator = openDevices.subList(from, to).iterator();
- payloads = createBatchedPayloads(leftoverBatchedRequests, iterator, editContentString, destBuilder.toString());
+ payloads = createBatchedPayloads(leftoverBatchedRequests, iterator, editContentString,
+ destBuilder.toString());
}
String payload = "";
from = openDevices.size() - leftoverRequests;
to = openDevices.size();
iterator = openDevices.subList(from, to).iterator();
- final StringBuilder payloadBuilder = new StringBuilder(prepareMessage(iterator.next(), editContentString));
+ final StringBuilder payloadBuilder = new StringBuilder(
+ prepareMessage(iterator.next(), editContentString));
payload += modifyMessage(payloadBuilder, j, leftoverRequests);
}
if (leftoverRequests > 0 || leftoverBatchedRequests > 0) {
}
if (leftoverRequests > 0) {
- from = (threadAmount) * requestPerThreads;
+ from = threadAmount * requestPerThreads;
to = from + leftoverRequests;
iterator = openDevices.subList(from, to).iterator();
allThreadsPayloads.add(createPayloads(iterator, editContentString));
final StringBuilder messageBuilder = new StringBuilder(editContentString);
if (editContentString.contains(HOST_KEY)) {
- messageBuilder.replace(messageBuilder.indexOf(HOST_KEY), messageBuilder.indexOf(HOST_KEY) + HOST_KEY.length(), generateConfigsAddress);
+ messageBuilder.replace(messageBuilder.indexOf(HOST_KEY),
+ messageBuilder.indexOf(HOST_KEY) + HOST_KEY.length(),
+ generateConfigsAddress);
}
if (editContentString.contains(PORT_KEY)) {
- while (messageBuilder.indexOf(PORT_KEY) != -1)
- messageBuilder.replace(messageBuilder.indexOf(PORT_KEY), messageBuilder.indexOf(PORT_KEY) + PORT_KEY.length(), Integer.toString(openDevice));
+ while (messageBuilder.indexOf(PORT_KEY) != -1) {
+ messageBuilder.replace(messageBuilder.indexOf(PORT_KEY),
+ messageBuilder.indexOf(PORT_KEY) + PORT_KEY.length(),
+ Integer.toString(openDevice));
+ }
}
if (editContentString.contains(TCP_ONLY)) {
- messageBuilder.replace(messageBuilder.indexOf(TCP_ONLY), messageBuilder.indexOf(TCP_ONLY) + TCP_ONLY.length(), Boolean.toString(!ssh));
+ messageBuilder.replace(messageBuilder.indexOf(TCP_ONLY),
+ messageBuilder.indexOf(TCP_ONLY) + TCP_ONLY.length(),
+ Boolean.toString(!ssh));
}
return messageBuilder.toString();
}
- private ArrayList<Execution.DestToPayload> createPayloads(final Iterator<Integer> openDevices, final String editContentString) {
+ private ArrayList<Execution.DestToPayload> createPayloads(final Iterator<Integer> openDevices,
+ final String editContentString) {
final ArrayList<Execution.DestToPayload> payloads = new ArrayList<>();
while (openDevices.hasNext()) {
- final StringBuilder destBuilder = new StringBuilder(dest);
- destBuilder.replace(destBuilder.indexOf(ADDRESS_PORT), destBuilder.indexOf(ADDRESS_PORT) + ADDRESS_PORT.length(), controllerDestination);
- payloads.add(new Execution.DestToPayload(destBuilder.toString(), prepareMessage(openDevices.next(), editContentString)));
+ final StringBuilder destBuilder = new StringBuilder(DEST);
+ destBuilder.replace(destBuilder.indexOf(ADDRESS_PORT),
+ destBuilder.indexOf(ADDRESS_PORT) + ADDRESS_PORT.length(), controllerDestination);
+ payloads.add(new Execution.DestToPayload(
+ destBuilder.toString(), prepareMessage(openDevices.next(), editContentString)));
}
return payloads;
}
- private ArrayList<Execution.DestToPayload> createBatchedPayloads(final int batchedRequestsCount, final Iterator<Integer> openDevices, final String editContentString,
- final String destination) {
+ private ArrayList<Execution.DestToPayload> createBatchedPayloads(final int batchedRequestsCount,
+ final Iterator<Integer> openDevices, final String editContentString, final String destination) {
final ArrayList<Execution.DestToPayload> payloads = new ArrayList<>();
for (int i = 0; i < batchedRequestsCount; i++) {
- String payload = "";
+ StringBuilder payload = new StringBuilder();
for (int j = 0; j < generateConfigBatchSize; j++) {
- final StringBuilder payloadBuilder = new StringBuilder(prepareMessage(openDevices.next(), editContentString));
- payload += modifyMessage(payloadBuilder, j, generateConfigBatchSize);
+ final StringBuilder payloadBuilder = new StringBuilder(
+ prepareMessage(openDevices.next(), editContentString));
+ payload.append(modifyMessage(payloadBuilder, j, generateConfigBatchSize));
}
- payloads.add(new Execution.DestToPayload(destination, payload));
+ payloads.add(new Execution.DestToPayload(destination, payload.toString()));
}
return payloads;
}
Code Review / netconf.git / blobdiff