Fix findbugs violations in netconf

[netconf.git] / netconf / tools / netconf-testtool / src / main / java / org / opendaylight / netconf / test / tool / customrpc / RpcMapping.java

diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/customrpc/RpcMapping.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/customrpc/RpcMapping.java
index 5d3f7eb14c6887a03e83f6f2ccd4d9dda92ca9f5..3b6722f76fb127603c3c85c2a049bca66de819af 100644 (file)
--- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/customrpc/RpcMapping.java
+++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/customrpc/RpcMapping.java
@@ -76,7 +76,7 @@ class RpcMapping {
         private final XmlElement xmlElement;
         private final int hashCode;
 
-        private Request(final XmlElement element) {
+        Request(final XmlElement element) {
             this.xmlElement = element;
             hashCode = XmlUtil.toString(element)
                     .replaceAll("message-id=.*(>| )", "") //message id is variable, remove it
@@ -85,14 +85,14 @@ class RpcMapping {
         }
 
         @Override
-        public boolean equals(final Object o) {
-            if (this == o) {
+        public boolean equals(final Object obj) {
+            if (this == obj) {
                 return true;
             }
-            if (o == null || getClass() != o.getClass()) {
+            if (obj == null || getClass() != obj.getClass()) {
                 return false;
             }
-            final Request request = (Request) o;
+            final Request request = (Request) obj;
             return documentEquals(this.xmlElement, request.xmlElement);
         }
 
@@ -125,7 +125,7 @@ class RpcMapping {
                 }
             }
 
-            if (e1Children.isEmpty() && e1Children.isEmpty()) {
+            if (e1Children.isEmpty() && e2Children.isEmpty()) {
                 try {
                     return e1.getTextContent().equals(e2.getTextContent());
                 } catch (final DocumentedException e) {