spi: consolidate common member
[neutron.git] / neutron-spi / src / main / java / org / opendaylight / neutron / spi / NeutronFirewallRule.java
index 5640415486722ee8c3fcfe36d9b1279627c03101..360f9cb7c4abe8000bc4edd4f1105c5927d16133 100644 (file)
@@ -8,13 +8,12 @@
 
 package org.opendaylight.neutron.spi;
 
+import java.io.Serializable;
+import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
-import java.io.Serializable;
-import java.util.Iterator;
-import java.util.List;
 
 /**
  * OpenStack Neutron v2.0 Firewall as a service
@@ -24,17 +23,17 @@ import java.util.List;
  *
  * tenant_id               uuid-str
  * name                    String
- * description             String
  * admin_state_up          Bool
- * status                  String
  * shared                  Bool
  * firewall_policy_id      uuid-str
  * protocol                String
  * ip_version              Integer
  * source_ip_address       String (IP addr or CIDR)
  * destination_ip_address  String (IP addr or CIDR)
- * source_port             Integer
- * destination_port        Integer
+ * source_port_range_min    Integer
+ * source_port_range_max    Integer
+ * destination_port_range_min Integer
+ * destination_port_range_max Integer
  * position                Integer
  * action                  String
  * enabled                 Bool
@@ -45,19 +44,9 @@ import java.util.List;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-
-public class NeutronFirewallRule extends NeutronObject implements Serializable, INeutronObject {
+public final class NeutronFirewallRule extends NeutronBaseAttributes<NeutronFirewallRule> implements Serializable {
     private static final long serialVersionUID = 1L;
 
-    @XmlElement(name = "name")
-    String firewallRuleName;
-
-    @XmlElement(name = "description")
-    String firewallRuleDescription;
-
-    @XmlElement(name = "status")
-    String firewallRuleStatus;
-
     @XmlElement(defaultValue = "false", name = "shared")
     Boolean firewallRuleIsShared;
 
@@ -76,11 +65,17 @@ public class NeutronFirewallRule extends NeutronObject implements Serializable,
     @XmlElement(name = "destination_ip_address")
     String firewallRuleDstIpAddr;
 
-    @XmlElement(name = "source_port")
-    Integer firewallRuleSrcPort;
+    @XmlElement(name = "source_port_range_min")
+    Integer firewallRuleSrcPortRangeMin;
+
+    @XmlElement(name = "source_port_range_max")
+    Integer firewallRuleSrcPortRangeMax;
 
-    @XmlElement(name = "destination_port")
-    Integer firewallRuleDstPort;
+    @XmlElement(name = "destination_port_range_min")
+    Integer firewallRuleDstPortRangeMin;
+
+    @XmlElement(name = "destination_port_range_max")
+    Integer firewallRuleDstPortRangeMax;
 
     @XmlElement(name = "position")
     Integer firewallRulePosition;
@@ -115,20 +110,36 @@ public class NeutronFirewallRule extends NeutronObject implements Serializable,
         this.firewallRulePosition = firewallRulePosition;
     }
 
-    public Integer getFirewallRuleDstPort() {
-        return firewallRuleDstPort;
+    public Integer getFirewallRuleDstPortRangeMin() {
+        return firewallRuleDstPortRangeMin;
+    }
+
+    public void setFirewallRuleDstPortRangeMin(Integer firewallRuleDstPortRangeMin) {
+        this.firewallRuleDstPortRangeMin = firewallRuleDstPortRangeMin;
     }
 
-    public void setFirewallRuleDstPort(Integer firewallRuleDstPort) {
-        this.firewallRuleDstPort = firewallRuleDstPort;
+    public Integer getFirewallRuleDstPortRangeMax() {
+        return firewallRuleDstPortRangeMax;
     }
 
-    public Integer getFirewallRuleSrcPort() {
-        return firewallRuleSrcPort;
+    public void setFirewallRuleDstPortRangeMax(Integer firewallRuleDstPortRangeMax) {
+        this.firewallRuleDstPortRangeMax = firewallRuleDstPortRangeMax;
     }
 
-    public void setFirewallRuleSrcPort(Integer firewallRuleSrcPort) {
-        this.firewallRuleSrcPort = firewallRuleSrcPort;
+    public Integer getFirewallRuleSrcPortRangeMin() {
+        return firewallRuleSrcPortRangeMin;
+    }
+
+    public void setFirewallRuleSrcPortRangeMin(Integer firewallRuleSrcPortRangeMin) {
+        this.firewallRuleSrcPortRangeMin = firewallRuleSrcPortRangeMin;
+    }
+
+    public Integer getFirewallRuleSrcPortRangeMax() {
+        return firewallRuleSrcPortRangeMax;
+    }
+
+    public void setFirewallRuleSrcPortRangeMax(Integer firewallRuleSrcPortRangeMax) {
+        this.firewallRuleSrcPortRangeMax = firewallRuleSrcPortRangeMax;
     }
 
     public String getFirewallRuleDstIpAddr() {
@@ -179,70 +190,10 @@ public class NeutronFirewallRule extends NeutronObject implements Serializable,
         this.firewallRuleIsShared = firewallRuleIsShared;
     }
 
-    public String getFirewallRuleStatus() {
-        return firewallRuleStatus;
-    }
-
-    public void setFirewallRuleStatus(String firewallRuleStatus) {
-        this.firewallRuleStatus = firewallRuleStatus;
-    }
-
-    public String getFirewallRuleDescription() {
-        return firewallRuleDescription;
-    }
-
-    public void setFirewallRuleDescription(String firewallRuleDescription) {
-        this.firewallRuleDescription = firewallRuleDescription;
-    }
-
-    public String getFirewallRuleName() {
-        return firewallRuleName;
-    }
-
-    public void setFirewallRuleName(String firewallRuleName) {
-        this.firewallRuleName = firewallRuleName;
-    }
-
-    @Deprecated
-    public String getFirewallRuleTenantID() {
-        return getTenantID();
-    }
-
-    @Deprecated
-    public void setFirewallRuleTenantID(String tenantID) {
-        setTenantID(tenantID);
-    }
-
-    // @deprecated use getID()
-    public String getFirewallRuleUUID() {
-        return getID();
-    }
-
-    // @deprecated use setID()
-    public void setFireWallRuleID(String uuid) {
-        setID(uuid);
-    }
-
     public NeutronFirewallRule extractFields(List<String> fields) {
         NeutronFirewallRule ans = new NeutronFirewallRule();
-        Iterator<String> i = fields.iterator();
-        while (i.hasNext()) {
-            String s = i.next();
-            if (s.equals("id")) {
-                ans.setID(this.getID());
-            }
-            if (s.equals("tenant_id")) {
-                ans.setTenantID(this.getTenantID());
-            }
-            if (s.equals("name")) {
-                ans.setFirewallRuleName(this.getFirewallRuleName());
-            }
-            if (s.equals("description")) {
-                ans.setFirewallRuleDescription(this.getFirewallRuleDescription());
-            }
-            if (s.equals("status")) {
-                ans.setFirewallRuleStatus(this.getFirewallRuleStatus());
-            }
+        for (String s : fields) {
+            extractField(s, ans);
             if (s.equals("shared")) {
                 ans.setFirewallRuleIsShared(firewallRuleIsShared);
             }
@@ -258,11 +209,17 @@ public class NeutronFirewallRule extends NeutronObject implements Serializable,
             if (s.equals("destination_ip_address")) {
                 ans.setFirewallRuleDstIpAddr(this.getFirewallRuleDstIpAddr());
             }
-            if (s.equals("source_port")) {
-                ans.setFirewallRuleSrcPort(this.getFirewallRuleSrcPort());
+            if (s.equals("source_port_range_min")) {
+                ans.setFirewallRuleSrcPortRangeMin(this.getFirewallRuleSrcPortRangeMin());
+            }
+            if (s.equals("source_port_range_max")) {
+                ans.setFirewallRuleSrcPortRangeMax(this.getFirewallRuleSrcPortRangeMax());
             }
-            if (s.equals("destination_port")) {
-                ans.setFirewallRuleDstPort(this.getFirewallRuleDstPort());
+            if (s.equals("destination_port_range_min")) {
+                ans.setFirewallRuleDstPortRangeMin(this.getFirewallRuleDstPortRangeMin());
+            }
+            if (s.equals("destination_port_range_max")) {
+                ans.setFirewallRuleDstPortRangeMax(this.getFirewallRuleDstPortRangeMax());
             }
             if (s.equals("position")) {
                 ans.setFirewallRulePosition(this.getFirewallRulePosition());
@@ -280,26 +237,18 @@ public class NeutronFirewallRule extends NeutronObject implements Serializable,
 
     @Override
     public String toString() {
-        return "firewallPolicyRules{" +
-            "firewallRuleUUID='" + uuid + '\'' +
-            ", firewallRuleTenantID='" + tenantID + '\'' +
-            ", firewallRuleName='" + firewallRuleName + '\'' +
-            ", firewallRuleDescription='" + firewallRuleDescription + '\'' +
-            ", firewallRuleStatus='" + firewallRuleStatus + '\'' +
-            ", firewallRuleIsShared=" + firewallRuleIsShared +
-            ", firewallRulePolicyID=" + firewallRulePolicyID +
-            ", firewallRuleProtocol='" + firewallRuleProtocol + '\'' +
-            ", firewallRuleIpVer=" + firewallRuleIpVer +
-            ", firewallRuleSrcIpAddr='" + firewallRuleSrcIpAddr + '\'' +
-            ", firewallRuleDstIpAddr='" + firewallRuleDstIpAddr + '\'' +
-            ", firewallRuleSrcPort=" + firewallRuleSrcPort +
-            ", firewallRuleDstPort=" + firewallRuleDstPort +
-            ", firewallRulePosition=" + firewallRulePosition +
-            ", firewallRuleAction='" + firewallRuleAction + '\'' +
-            ", firewallRuleIsEnabled=" + firewallRuleIsEnabled +
-            '}';
+        return "firewallPolicyRules{" + "firewallRuleUUID='" + uuid + '\'' + ", firewallRuleTenantID='" + tenantID
+                + '\'' + ", firewallRuleName='" + name + '\'' + ", firewallRuleIsShared="
+                + firewallRuleIsShared + ", firewallRulePolicyID=" + firewallRulePolicyID + ", firewallRuleProtocol='"
+                + firewallRuleProtocol + '\'' + ", firewallRuleIpVer=" + firewallRuleIpVer + ", firewallRuleSrcIpAddr='"
+                + firewallRuleSrcIpAddr + '\'' + ", firewallRuleDstIpAddr='" + firewallRuleDstIpAddr + '\''
+                + ", firewallRuleSrcPort=" + firewallRuleSrcPortRangeMin + ':' + firewallRuleSrcPortRangeMax
+                + ", firewallRuleDstPort=" + firewallRuleDstPortRangeMin + ':' + firewallRuleDstPortRangeMax
+                + ", firewallRulePosition=" + firewallRulePosition + ", firewallRuleAction='" + firewallRuleAction
+                + '\'' + ", firewallRuleIsEnabled=" + firewallRuleIsEnabled + '}';
     }
 
+    @Override
     public void initDefaults() {
     }
 }