import akka.actor.ActorSelection;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Collections;
-import java.util.Map.Entry;
+import java.util.concurrent.ConcurrentHashMap;
+import org.opendaylight.controller.cluster.datastore.actors.DataTreeNotificationListenerRegistrationActor;
import org.opendaylight.controller.cluster.datastore.messages.EnableNotification;
import org.opendaylight.controller.cluster.datastore.messages.RegisterDataTreeChangeListener;
-import org.opendaylight.controller.cluster.datastore.messages.RegisterDataTreeChangeListenerReply;
-import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener;
-import org.opendaylight.yangtools.concepts.ListenerRegistration;
-import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate;
+import org.opendaylight.controller.cluster.datastore.messages.RegisterDataTreeNotificationListenerReply;
+import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeListener;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-final class DataTreeChangeListenerSupport extends LeaderLocalDelegateFactory<RegisterDataTreeChangeListener, ListenerRegistration<DOMDataTreeChangeListener>, DataTreeCandidate> {
+final class DataTreeChangeListenerSupport extends LeaderLocalDelegateFactory<RegisterDataTreeChangeListener> {
private static final Logger LOG = LoggerFactory.getLogger(DataTreeChangeListenerSupport.class);
- private final ArrayList<DelayedDataTreeListenerRegistration> delayedRegistrations = new ArrayList<>();
- private final Collection<ActorSelection> actors = new ArrayList<>();
+
+ private final Collection<DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener>>
+ delayedDataTreeChangeListenerRegistrations = ConcurrentHashMap.newKeySet();
+ private final Collection<DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener>>
+ delayedListenerOnAllRegistrations = ConcurrentHashMap.newKeySet();
+ private final Collection<ActorSelection> leaderOnlyListenerActors = ConcurrentHashMap.newKeySet();
+ private final Collection<ActorSelection> allListenerActors = ConcurrentHashMap.newKeySet();
DataTreeChangeListenerSupport(final Shard shard) {
super(shard);
}
+ void doRegistration(final RegisterDataTreeChangeListener message, final ActorRef registrationActor) {
+ final ActorSelection listenerActor = processListenerRegistrationMessage(message);
+
+ final DOMDataTreeChangeListener listener = new ForwardingDataTreeChangeListener(listenerActor);
+
+ LOG.debug("{}: Registering listenerActor {} for path {}", persistenceId(), listenerActor, message.getPath());
+
+ final ShardDataTree shardDataTree = getShard().getDataStore();
+ shardDataTree.registerTreeChangeListener(message.getPath(),
+ listener, shardDataTree.readCurrentData(), registration -> registrationActor.tell(
+ new DataTreeNotificationListenerRegistrationActor.SetRegistration(registration, () ->
+ removeListenerActor(listenerActor)), ActorRef.noSender()));
+ }
+
+ Collection<ActorSelection> getListenerActors() {
+ return new ArrayList<>(allListenerActors);
+ }
+
@Override
- void onLeadershipChange(final boolean isLeader) {
- if (isLeader) {
- for (DelayedDataTreeListenerRegistration reg : delayedRegistrations) {
- reg.createDelegate(this);
+ void onLeadershipChange(final boolean isLeader, final boolean hasLeader) {
+ LOG.debug("{}: onLeadershipChange, isLeader: {}, hasLeader : {}", persistenceId(), isLeader, hasLeader);
+
+ final EnableNotification msg = new EnableNotification(isLeader, persistenceId());
+ for (ActorSelection dataChangeListener : leaderOnlyListenerActors) {
+ dataChangeListener.tell(msg, getSelf());
+ }
+
+ if (hasLeader) {
+ for (DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener> reg :
+ delayedListenerOnAllRegistrations) {
+ reg.doRegistration(this);
}
- delayedRegistrations.clear();
- delayedRegistrations.trimToSize();
+
+ delayedListenerOnAllRegistrations.clear();
}
- final EnableNotification msg = new EnableNotification(isLeader);
- for (ActorSelection dataChangeListener : actors) {
- dataChangeListener.tell(msg, getSelf());
+ if (isLeader) {
+ for (DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener> reg :
+ delayedDataTreeChangeListenerRegistrations) {
+ reg.doRegistration(this);
+ }
+
+ delayedDataTreeChangeListenerRegistrations.clear();
}
}
@Override
- void onMessage(final RegisterDataTreeChangeListener registerTreeChangeListener, final boolean isLeader) {
- LOG.debug("{}: registerTreeChangeListener for {}, leader: {}", persistenceId(), registerTreeChangeListener.getPath(), isLeader);
-
- final ListenerRegistration<DOMDataTreeChangeListener> registration;
- final DataTreeCandidate event;
- if (!isLeader) {
- LOG.debug("{}: Shard is not the leader - delaying registration", persistenceId());
-
- DelayedDataTreeListenerRegistration delayedReg =
- new DelayedDataTreeListenerRegistration(registerTreeChangeListener);
- delayedRegistrations.add(delayedReg);
- registration = delayedReg;
- event = null;
- } else {
- final Entry<ListenerRegistration<DOMDataTreeChangeListener>, DataTreeCandidate> res = createDelegate(registerTreeChangeListener);
- registration = res.getKey();
- event = res.getValue();
- }
+ void onMessage(final RegisterDataTreeChangeListener message, final boolean isLeader, final boolean hasLeader) {
+ LOG.debug("{}: onMessage {}, isLeader: {}, hasLeader: {}", persistenceId(), message, isLeader, hasLeader);
- ActorRef listenerRegistration = createActor(DataTreeChangeListenerRegistrationActor.props(registration));
+ final ActorRef registrationActor = createActor(DataTreeNotificationListenerRegistrationActor.props());
- LOG.debug("{}: registerDataChangeListener sending reply, listenerRegistrationPath = {} ",
- persistenceId(), listenerRegistration.path());
+ if (hasLeader && message.isRegisterOnAllInstances() || isLeader) {
+ doRegistration(message, registrationActor);
+ } else {
+ LOG.debug("{}: Shard does not have a leader - delaying registration", persistenceId());
+
+ final DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener> delayedReg =
+ new DelayedDataTreeChangeListenerRegistration<>(message, registrationActor);
+ final Collection<DelayedDataTreeChangeListenerRegistration<DOMDataTreeChangeListener>> delayedRegList;
+ if (message.isRegisterOnAllInstances()) {
+ delayedRegList = delayedListenerOnAllRegistrations;
+ } else {
+ delayedRegList = delayedDataTreeChangeListenerRegistrations;
+ }
- tellSender(new RegisterDataTreeChangeListenerReply(listenerRegistration));
- if (event != null) {
- registration.getInstance().onDataTreeChanged(Collections.singletonList(event));
+ delayedRegList.add(delayedReg);
+ registrationActor.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(
+ delayedReg, () -> delayedRegList.remove(delayedReg)), ActorRef.noSender());
}
+
+ LOG.debug("{}: sending RegisterDataTreeNotificationListenerReply, listenerRegistrationPath = {} ",
+ persistenceId(), registrationActor.path());
+
+ tellSender(new RegisterDataTreeNotificationListenerReply(registrationActor));
}
- @Override
- Entry<ListenerRegistration<DOMDataTreeChangeListener>, DataTreeCandidate> createDelegate(final RegisterDataTreeChangeListener message) {
- ActorSelection dataChangeListenerPath = selectActor(message.getDataTreeChangeListenerPath());
+ private ActorSelection processListenerRegistrationMessage(final RegisterDataTreeChangeListener message) {
+ final ActorSelection listenerActor = selectActor(message.getListenerActorPath());
- // Notify the listener if notifications should be enabled or not
- // If this shard is the leader then it will enable notifications else
- // it will not
- dataChangeListenerPath.tell(new EnableNotification(true), getSelf());
+ // We have a leader so enable the listener.
+ listenerActor.tell(new EnableNotification(true, persistenceId()), getSelf());
- // Now store a reference to the data change listener so it can be notified
- // at a later point if notifications should be enabled or disabled
- actors.add(dataChangeListenerPath);
+ if (!message.isRegisterOnAllInstances()) {
+ // This is a leader-only registration so store a reference to the listener actor so it can be notified
+ // at a later point if notifications should be enabled or disabled.
+ leaderOnlyListenerActors.add(listenerActor);
+ }
- DOMDataTreeChangeListener listener = new ForwardingDataTreeChangeListener(dataChangeListenerPath);
+ allListenerActors.add(listenerActor);
- LOG.debug("{}: Registering for path {}", persistenceId(), message.getPath());
+ return listenerActor;
+ }
- return getShard().getDataStore().registerTreeChangeListener(message.getPath(), listener);
+ private void removeListenerActor(final ActorSelection listenerActor) {
+ allListenerActors.remove(listenerActor);
+ leaderOnlyListenerActors.remove(listenerActor);
}
}