package org.opendaylight.controller.sal.restconf.impl.test;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertSame;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.when;
+
import com.google.common.base.Optional;
import com.google.common.util.concurrent.CheckedFuture;
import com.google.common.util.concurrent.Futures;
+import java.util.concurrent.Future;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.opendaylight.controller.md.sal.dom.api.DOMDataReadWriteTransaction;
import org.opendaylight.controller.md.sal.dom.api.DOMDataWriteTransaction;
import org.opendaylight.controller.md.sal.dom.api.DOMMountPoint;
+import org.opendaylight.controller.md.sal.dom.api.DOMRpcException;
+import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult;
+import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
import org.opendaylight.controller.sal.core.api.Broker.ConsumerSession;
import org.opendaylight.controller.sal.restconf.impl.BrokerFacade;
import org.opendaylight.controller.sal.restconf.impl.ControllerContext;
import org.opendaylight.controller.sal.streams.listeners.Notificator;
import org.opendaylight.yangtools.concepts.ListenerRegistration;
import org.opendaylight.yangtools.yang.common.QName;
-import org.opendaylight.yangtools.yang.common.RpcResult;
-import org.opendaylight.yangtools.yang.data.api.CompositeNode;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
import org.opendaylight.yangtools.yang.data.impl.schema.Builders;
-
-import java.util.concurrent.Future;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertSame;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.eq;
-import static org.mockito.Mockito.inOrder;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.verifyNoMoreInteractions;
-import static org.mockito.Mockito.when;
+import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.opendaylight.yangtools.yang.model.api.SchemaPath;
/**
* Unit tests for BrokerFacade.
DOMDataBroker domDataBroker;
@Mock
- ConsumerSession mockConsumerSession;
+ ConsumerSession context;
+
+ @Mock
+ DOMRpcService mockRpcService;
@Mock
DOMMountPoint mockMountInstance;
BrokerFacade brokerFacade = BrokerFacade.getInstance();
- CompositeNode dataNode;
-
NormalizedNode<?, ?> dummyNode = createDummyNode("test:module", "2014-01-09", "interfaces");
CheckedFuture<Optional<NormalizedNode<?, ?>>,ReadFailedException> dummyNodeInFuture = wrapDummyNode(dummyNode);
QName qname = TestUtils.buildQName("interfaces","test:module", "2014-01-09");
- YangInstanceIdentifier instanceID = YangInstanceIdentifier.builder().node(qname).toInstance();
+ SchemaPath type = SchemaPath.create(true, qname);
+
+ YangInstanceIdentifier instanceID = YangInstanceIdentifier.builder().node(qname).build();
@Mock
DOMDataReadOnlyTransaction rTransaction;
MockitoAnnotations.initMocks(this);
// TODO it is started before every test method
brokerFacade.setDomDataBroker(domDataBroker);
- brokerFacade.setContext(mockConsumerSession);
+ brokerFacade.setRpcService(mockRpcService);
+ brokerFacade.setContext(context);
when(domDataBroker.newReadOnlyTransaction()).thenReturn(rTransaction);
when(domDataBroker.newWriteOnlyTransaction()).thenReturn(wTransaction);
when(domDataBroker.newReadWriteTransaction()).thenReturn(rwTransaction);
- dataNode = TestUtils.prepareCompositeNodeWithIetfInterfacesInterfacesData();
-
ControllerContext.getInstance().setSchemas(TestUtils.loadSchemaContext("/full-versions/test-module"));
}
return Futures.immediateCheckedFuture(Optional.<NormalizedNode<?, ?>> of(dummyNode));
}
- private CheckedFuture<Boolean,ReadFailedException> wrapExistence(Boolean exists) {
+ private CheckedFuture<Boolean,ReadFailedException> wrapExistence(final Boolean exists) {
return Futures.immediateCheckedFuture(exists);
}
when(rTransaction.read(any(LogicalDatastoreType.class), any(YangInstanceIdentifier.class))).thenReturn(
dummyNodeInFuture);
- NormalizedNode<?, ?> actualNode = brokerFacade.readConfigurationData(instanceID);
+ final NormalizedNode<?, ?> actualNode = brokerFacade.readConfigurationData(instanceID);
assertSame("readConfigurationData", dummyNode, actualNode);
}
when(rTransaction.read(any(LogicalDatastoreType.class), any(YangInstanceIdentifier.class))).thenReturn(
dummyNodeInFuture);
- NormalizedNode<?, ?> actualNode = brokerFacade.readOperationalData(instanceID);
+ final NormalizedNode<?, ?> actualNode = brokerFacade.readOperationalData(instanceID);
assertSame("readOperationalData", dummyNode, actualNode);
}
brokerFacade.readOperationalData(instanceID);
}
- @SuppressWarnings("unchecked")
@Test
public void testInvokeRpc() throws Exception {
- RpcResult<CompositeNode> expResult = mock(RpcResult.class);
- Future<RpcResult<CompositeNode>> future = Futures.immediateFuture(expResult);
- when(mockConsumerSession.rpc(qname, dataNode)).thenReturn(future);
+ final DOMRpcResult expResult = mock(DOMRpcResult.class);
+ final CheckedFuture<DOMRpcResult, DOMRpcException> future = Futures.immediateCheckedFuture(expResult);
+ when(mockRpcService.invokeRpc(type, dummyNode)).thenReturn(future);
- Future<RpcResult<CompositeNode>> actualFuture = brokerFacade.invokeRpc(qname, dataNode);
+ final CheckedFuture<DOMRpcResult, DOMRpcException> actualFuture = brokerFacade.invokeRpc(type, dummyNode);
assertNotNull("Future is null", actualFuture);
- RpcResult<CompositeNode> actualResult = actualFuture.get();
-
+ final DOMRpcResult actualResult = actualFuture.get();
assertSame("invokeRpc", expResult, actualResult);
}
@Test(expected = RestconfDocumentedException.class)
public void testInvokeRpcWithNoConsumerSession() {
brokerFacade.setContext(null);
-
- brokerFacade.invokeRpc(qname, dataNode);
+ brokerFacade.invokeRpc(type, dummyNode);
}
@Ignore
@Test
public void testCommitConfigurationDataPut() {
- CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
+ @SuppressWarnings("unchecked")
+ final CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
when(wTransaction.submit()).thenReturn(expFuture);
- Future<Void> actualFuture = brokerFacade.commitConfigurationDataPut(instanceID, dummyNode);
+ final Future<Void> actualFuture = brokerFacade.commitConfigurationDataPut((SchemaContext)null, instanceID, dummyNode);
assertSame("commitConfigurationDataPut", expFuture, actualFuture);
- InOrder inOrder = inOrder(domDataBroker, wTransaction);
+ final InOrder inOrder = inOrder(domDataBroker, wTransaction);
inOrder.verify(domDataBroker).newWriteOnlyTransaction();
inOrder.verify(wTransaction).put(LogicalDatastoreType.CONFIGURATION, instanceID, dummyNode);
inOrder.verify(wTransaction).submit();
@Test
public void testCommitConfigurationDataPost() {
- CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
+ @SuppressWarnings("unchecked")
+ final CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
- NormalizedNode<?, ?> dummyNode2 = createDummyNode("dummy:namespace2", "2014-07-01", "dummy local name2");
+ final NormalizedNode<?, ?> dummyNode2 = createDummyNode("dummy:namespace2", "2014-07-01", "dummy local name2");
when(rwTransaction.read(eq(LogicalDatastoreType.CONFIGURATION), any(YangInstanceIdentifier.class))).thenReturn(
wrapDummyNode(dummyNode2));
when(rwTransaction.submit()).thenReturn(expFuture);
- CheckedFuture<Void, TransactionCommitFailedException> actualFuture = brokerFacade.commitConfigurationDataPost(
- instanceID, dummyNode);
+ final CheckedFuture<Void, TransactionCommitFailedException> actualFuture = brokerFacade.commitConfigurationDataPost(
+ (SchemaContext)null, YangInstanceIdentifier.builder().build(), dummyNode);
assertSame("commitConfigurationDataPost", expFuture, actualFuture);
- InOrder inOrder = inOrder(domDataBroker, rwTransaction);
+ final InOrder inOrder = inOrder(domDataBroker, rwTransaction);
inOrder.verify(domDataBroker).newReadWriteTransaction();
inOrder.verify(rwTransaction).merge(LogicalDatastoreType.CONFIGURATION, instanceID, dummyNode);
inOrder.verify(rwTransaction).submit();
when(rwTransaction.read(eq(LogicalDatastoreType.CONFIGURATION), any(YangInstanceIdentifier.class))).thenReturn(
dummyNodeInFuture);
try {
- brokerFacade.commitConfigurationDataPost(instanceID, dummyNode);
- } catch (RestconfDocumentedException e) {
+ // Schema context is only necessary for ensuring parent structure
+ brokerFacade.commitConfigurationDataPost((SchemaContext)null, instanceID, dummyNode);
+ } catch (final RestconfDocumentedException e) {
assertEquals("getErrorTag", RestconfError.ErrorTag.DATA_EXISTS, e.getErrors().get(0).getErrorTag());
throw e;
}
@Test
public void testCommitConfigurationDataDelete() {
- CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
+ @SuppressWarnings("unchecked")
+ final CheckedFuture<Void, TransactionCommitFailedException> expFuture = mock(CheckedFuture.class);
when(wTransaction.submit()).thenReturn(expFuture);
- CheckedFuture<Void, TransactionCommitFailedException> actualFuture = brokerFacade
+ final CheckedFuture<Void, TransactionCommitFailedException> actualFuture = brokerFacade
.commitConfigurationDataDelete(instanceID);
assertSame("commitConfigurationDataDelete", expFuture, actualFuture);
- InOrder inOrder = inOrder(domDataBroker, wTransaction);
+ final InOrder inOrder = inOrder(domDataBroker, wTransaction);
inOrder.verify(domDataBroker).newWriteOnlyTransaction();
inOrder.verify(wTransaction).delete(eq(LogicalDatastoreType.CONFIGURATION), any(YangInstanceIdentifier.class));
inOrder.verify(wTransaction).submit();
@SuppressWarnings("unchecked")
@Test
public void testRegisterToListenDataChanges() {
- ListenerAdapter listener = Notificator.createListener(instanceID, "stream");
+ final ListenerAdapter listener = Notificator.createListener(instanceID, "stream");
- ListenerRegistration<DOMDataChangeListener> mockRegistration = mock(ListenerRegistration.class);
+ final ListenerRegistration<DOMDataChangeListener> mockRegistration = mock(ListenerRegistration.class);
when(
domDataBroker.registerDataChangeListener(any(LogicalDatastoreType.class), eq(instanceID), eq(listener),