import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.BarrierInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.MultipartReplyMessage;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PacketOutInput;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
private FutureCallback<OfHeader> callback;
private OfHeader message;
private boolean completed;
+ private boolean barrier;
private volatile boolean committed;
void commit(final OfHeader message, final FutureCallback<OfHeader> callback) {
this.message = message;
this.callback = callback;
+ this.barrier = message instanceof BarrierInput;
// Volatile write, needs to be last
committed = true;
}
void reset() {
+ barrier = false;
callback = null;
- message = null;
completed = false;
+ message = null;
// Volatile write, needs to be last
committed = false;
}
boolean isBarrier() {
- return message instanceof BarrierInput;
+ return barrier;
}
boolean isCommitted() {
return completed;
}
- OfHeader getMessage() {
- return message;
+ OfHeader takeMessage() {
+ final OfHeader ret = message;
+ checkCompletionNeed();
+ message = null;
+ return ret;
+ }
+
+ private void checkCompletionNeed() {
+ if (callback == null || PacketOutInput.class.isInstance(message)) {
+ completed = true;
+ callback = null;
+ }
}
boolean complete(final OfHeader response) {
- Preconditions.checkState(!completed, "Attempted to complete a completed message %s with response %s", message, response);
+ Preconditions.checkState(!completed, "Attempted to complete a completed message with response %s", response);
// Multipart requests are special, we have to look at them to see
// if there is something outstanding and adjust ourselves accordingly
completed = reallyComplete;
if (callback != null) {
callback.onSuccess(response);
+ if (reallyComplete) {
+ // We will not need the callback anymore, make sure it can be GC'd
+ callback = null;
+ }
}
LOG.debug("Entry {} completed {} with response {}", this, completed, response);
return reallyComplete;
completed = true;
if (callback != null) {
callback.onFailure(cause);
+ callback = null;
}
} else {
- LOG.warn("Ignoring failure {} for completed message {}", cause, message);
+ LOG.warn("Ignoring failure {} for completed message", cause);
}
}
-
}