"Added more deserialization factories & their unit tests"

[openflowjava.git] / openflow-protocol-impl / src / main / java / org / opendaylight / openflowjava / protocol / impl / deserialization / factories / FeaturesReplyMessageFactory.java

diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FeaturesReplyMessageFactory.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FeaturesReplyMessageFactory.java
index cb111cff0eb919867185d9f041c32804768fe10b..aeb3353c5eb23a9f4649fe5a664ec1ca967923e6 100644 (file)
--- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FeaturesReplyMessageFactory.java
+++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FeaturesReplyMessageFactory.java
@@ -33,26 +33,21 @@ public class FeaturesReplyMessageFactory implements OFDeserializer<GetFeaturesOu
         return instance;\r
     }\r
     \r
-    /* (non-Javadoc)\r
-     * @see org.openflow.core.deserialization.OfDeserializer#createMessage(io.netty.buffer.ByteBuf, short)\r
-     */\r
     @Override\r
     public GetFeaturesOutput bufferToMessage(ByteBuf rawMessage, short version) {\r
-        GetFeaturesOutputBuilder gfob = new GetFeaturesOutputBuilder();\r
-        gfob.setVersion(version);\r
-        gfob.setXid(rawMessage.readUnsignedInt());\r
-        \r
-        // TODO - unsigned long - check for appropriate process\r
-        byte[] datapathId = new byte[8];\r
+        GetFeaturesOutputBuilder builder = new GetFeaturesOutputBuilder();\r
+        builder.setVersion(version);\r
+        builder.setXid(rawMessage.readUnsignedInt());\r
+        byte[] datapathId = new byte[Long.SIZE/Byte.SIZE];\r
         rawMessage.readBytes(datapathId);\r
-        gfob.setDatapathId(new BigInteger(datapathId));\r
-        gfob.setBuffers(rawMessage.readUnsignedInt());\r
-        gfob.setTables(rawMessage.readUnsignedByte());\r
-        gfob.setAuxiliaryId(rawMessage.readUnsignedByte());\r
+        builder.setDatapathId(new BigInteger(datapathId));\r
+        builder.setBuffers(rawMessage.readUnsignedInt());\r
+        builder.setTables(rawMessage.readUnsignedByte());\r
+        builder.setAuxiliaryId(rawMessage.readUnsignedByte());\r
         rawMessage.skipBytes(PADDING_IN_FEATURES_REPLY_HEADER);\r
-        gfob.setCapabilities(rawMessage.readUnsignedInt());\r
-        gfob.setReserved(rawMessage.readUnsignedInt());\r
-        return gfob.build();\r
+        builder.setCapabilities(rawMessage.readUnsignedInt());\r
+        builder.setReserved(rawMessage.readUnsignedInt());\r
+        return builder.build();\r
     }\r
 \r
 }\r