Constants introduced

[openflowjava.git] / openflow-protocol-impl / src / main / java / org / opendaylight / openflowjava / protocol / impl / deserialization / factories / OF10StatsReplyMessageFactory.java

diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/OF10StatsReplyMessageFactory.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/OF10StatsReplyMessageFactory.java
index 75517fc1ce2c6e8c4b378c40455210329e95f4a3..bbff2e372c463a45af180e723a30ba2f663db48f 100644 (file)
--- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/OF10StatsReplyMessageFactory.java
+++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/OF10StatsReplyMessageFactory.java
@@ -8,6 +8,7 @@ import java.util.ArrayList;
 import java.util.List;\r
 \r
 import org.opendaylight.openflowjava.protocol.impl.deserialization.OFDeserializer;\r
+import org.opendaylight.openflowjava.protocol.impl.util.EncodeConstants;\r
 import org.opendaylight.openflowjava.protocol.impl.util.OF10ActionsDeserializer;\r
 import org.opendaylight.openflowjava.protocol.impl.util.OF10MatchDeserializer;\r
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartRequestFlags;\r
@@ -43,6 +44,16 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
  */\r
 public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartReplyMessage> {\r
 \r
+    private static final int DESC_STR_LEN = 256;\r
+    private static final int SERIAL_NUM_LEN = 32;\r
+    private static final byte PADDING_IN_FLOW_STATS_HEADER = 1;\r
+    private static final byte PADDING_IN_FLOW_STATS_HEADER_02 = 6;\r
+    private static final byte PADDING_IN_AGGREGATE_HEADER = 4;\r
+    private static final byte PADDING_IN_TABLE_HEADER = 3;\r
+    private static final byte MAX_TABLE_NAME_LENGTH = 32;\r
+    private static final byte PADDING_IN_PORT_STATS_HEADER = 6;\r
+    private static final byte PADDING_IN_QUEUE_HEADER = 2;\r
+\r
     private static OF10StatsReplyMessageFactory instance;\r
     \r
     private OF10StatsReplyMessageFactory() {\r
@@ -89,8 +100,6 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyDesc setDesc(ByteBuf input) {\r
-        final int DESC_STR_LEN = 256;\r
-        final int SERIAL_NUM_LEN = 32;\r
         MultipartReplyDescBuilder descBuilder = new MultipartReplyDescBuilder();\r
         byte[] mfrDescBytes = new byte[DESC_STR_LEN];\r
         input.readBytes(mfrDescBytes);\r
@@ -116,13 +125,11 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyFlow setFlow(ByteBuf input) {\r
-        final byte PADDING_IN_FLOW_STATS_HEADER = 1;\r
-        final byte PADDING_IN_FLOW_STATS_HEADER_02 = 6;\r
         MultipartReplyFlowBuilder flowBuilder = new MultipartReplyFlowBuilder();\r
         List<FlowStats> flowStatsList = new ArrayList<>();\r
         while (input.readableBytes() > 0) {\r
             FlowStatsBuilder flowStatsBuilder = new FlowStatsBuilder();\r
-            input.skipBytes(Short.SIZE / Byte.SIZE);\r
+            input.skipBytes(EncodeConstants.SIZE_OF_SHORT_IN_BYTES);\r
             flowStatsBuilder.setTableId(input.readUnsignedByte());\r
             input.skipBytes(PADDING_IN_FLOW_STATS_HEADER);\r
             flowStatsBuilder.setMatchV10(OF10MatchDeserializer.createMatchV10(input));\r
@@ -149,7 +156,6 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyAggregate setAggregate(ByteBuf input) {\r
-        final byte PADDING_IN_AGGREGATE_HEADER = 4;\r
         MultipartReplyAggregateBuilder builder = new MultipartReplyAggregateBuilder();\r
         byte[] packetCount = new byte[Long.SIZE/Byte.SIZE];\r
         input.readBytes(packetCount);\r
@@ -163,8 +169,6 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyTable setTable(ByteBuf input) {\r
-        final byte PADDING_IN_TABLE_HEADER = 3;\r
-        final byte MAX_TABLE_NAME_LENGTH = 32;\r
         MultipartReplyTableBuilder builder = new MultipartReplyTableBuilder();\r
         List<TableStats> tableStatsList = new ArrayList<>();\r
         while (input.readableBytes() > 0) {\r
@@ -186,7 +190,6 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyPortStats setPortStats(ByteBuf input) {\r
-        final byte PADDING_IN_PORT_STATS_HEADER = 6;\r
         MultipartReplyPortStatsBuilder builder = new MultipartReplyPortStatsBuilder();\r
         List<PortStats> portStatsList = new ArrayList<>();\r
         while (input.readableBytes() > 0) {\r
@@ -235,7 +238,6 @@ public class OF10StatsReplyMessageFactory implements OFDeserializer<MultipartRep
     }\r
     \r
     private static MultipartReplyQueue setQueue(ByteBuf input) {\r
-        final byte PADDING_IN_QUEUE_HEADER = 2;\r
         MultipartReplyQueueBuilder builder = new MultipartReplyQueueBuilder();\r
         List<QueueStats> queueStatsList = new ArrayList<>();\r
         while (input.readableBytes() > 0) {\r