BUG-2245 Sonar technical debt

[openflowjava.git] / openflow-protocol-impl / src / main / java / org / opendaylight / openflowjava / protocol / impl / util / OpenflowUtils.java

diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/OpenflowUtils.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/OpenflowUtils.java
index 8ba8e74c5badbf1a76095253e9e283822bba2d05..78f27eac865b1a2f7afbdf02836ed651dc5f5c80 100644 (file)
--- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/OpenflowUtils.java
+++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/OpenflowUtils.java
@@ -25,15 +25,15 @@ public abstract class OpenflowUtils {
      * @return port state\r
      */\r
     public static PortStateV10 createPortState(long input){\r
-        final Boolean _linkDown = ((input) & (1<<0)) != 0;\r
-        final Boolean _blocked = ((input) & (1<<1)) != 0;\r
-        final Boolean _live = ((input) & (1<<2)) != 0;\r
-        final Boolean _stpListen = ((input) & (1<<8)) == 0;\r
-        final Boolean _stpLearn = ((input) & (1<<8)) != 0;\r
-        final Boolean _stpForward = ((input) & (1<<9)) != 0; // equals 2 << 8\r
-        final Boolean _stpBlock = (((input) & (1<<9)) != 0) && (((input) & (1<<8)) != 0); // equals 3 << 8\r
-        final Boolean _stpMask = ((input) & (1<<10)) != 0; // equals 4 << 8\r
-        return new PortStateV10(_blocked, _linkDown, _live, _stpBlock, _stpForward, _stpLearn, _stpListen, _stpMask);\r
+        final Boolean psLinkDown = ((input) & (1<<0)) != 0;\r
+        final Boolean psBlocked = ((input) & (1<<1)) != 0;\r
+        final Boolean psLive = ((input) & (1<<2)) != 0;\r
+        final Boolean psStpListen = ((input) & (1<<8)) == 0;\r
+        final Boolean psStpLearn = ((input) & (1<<8)) != 0;\r
+        final Boolean psStpForward = ((input) & (1<<9)) != 0; // equals 2 << 8\r
+        final Boolean psStpBlock = (((input) & (1<<9)) != 0) && (((input) & (1<<8)) != 0); // equals 3 << 8\r
+        final Boolean psStpMask = ((input) & (1<<10)) != 0; // equals 4 << 8\r
+        return new PortStateV10(psBlocked, psLinkDown, psLive, psStpBlock, psStpForward, psStpLearn, psStpListen, psStpMask);\r
     }\r
 \r
     /**\r
@@ -42,14 +42,14 @@ public abstract class OpenflowUtils {
      * @return port state\r
      */\r
     public static PortConfigV10 createPortConfig(long input){\r
-        final Boolean _portDown = ((input) & (1<<0)) != 0;\r
-        final Boolean _noStp = ((input) & (1<<1)) != 0;\r
-        final Boolean _noRecv = ((input) & (1<<2)) != 0;\r
-        final Boolean _noRecvStp = ((input) & (1<<3)) != 0;\r
-        final Boolean _noFlood = ((input) & (1<<4)) != 0;\r
-        final Boolean _noFwd  = ((input) & (1<<5)) != 0;\r
-        final Boolean _noPacketIn = ((input) & (1<<6)) != 0;\r
-        return new PortConfigV10(_noFlood, _noFwd, _noPacketIn, _noRecv, _noRecvStp, _noStp, _portDown);\r
+        final Boolean pcPortDown = ((input) & (1<<0)) != 0;\r
+        final Boolean pcNoStp = ((input) & (1<<1)) != 0;\r
+        final Boolean pcNoRecv = ((input) & (1<<2)) != 0;\r
+        final Boolean pcNoRecvStp = ((input) & (1<<3)) != 0;\r
+        final Boolean pcNoFlood = ((input) & (1<<4)) != 0;\r
+        final Boolean pcNoFwd  = ((input) & (1<<5)) != 0;\r
+        final Boolean pcNoPacketIn = ((input) & (1<<6)) != 0;\r
+        return new PortConfigV10(pcNoFlood, pcNoFwd, pcNoPacketIn, pcNoRecv, pcNoRecvStp, pcNoStp, pcPortDown);\r
     }\r
 \r
     /**\r
@@ -58,19 +58,19 @@ public abstract class OpenflowUtils {
      * @return port state\r
      */\r
     public static PortFeaturesV10 createPortFeatures(long input){\r
-        final Boolean _10mbHd = ((input) & (1<<0)) != 0;\r
-        final Boolean _10mbFd = ((input) & (1<<1)) != 0;\r
-        final Boolean _100mbHd = ((input) & (1<<2)) != 0;\r
-        final Boolean _100mbFd = ((input) & (1<<3)) != 0;\r
-        final Boolean _1gbHd = ((input) & (1<<4)) != 0;\r
-        final Boolean _1gbFd = ((input) & (1<<5)) != 0;\r
-        final Boolean _10gbFd = ((input) & (1<<6)) != 0;\r
-        final Boolean _copper = ((input) & (1<<7)) != 0;\r
-        final Boolean _fiber = ((input) & (1<<8)) != 0;\r
-        final Boolean _autoneg = ((input) & (1<<9)) != 0;\r
-        final Boolean _pause = ((input) & (1<<10)) != 0;\r
-        final Boolean _pauseAsym = ((input) & (1<<11)) != 0;\r
-        return new PortFeaturesV10(_100mbFd, _100mbHd, _10gbFd, _10mbFd, _10mbHd,\r
-                _1gbFd, _1gbHd, _autoneg, _copper, _fiber, _pause, _pauseAsym);\r
+        final Boolean pf10mbHd = ((input) & (1<<0)) != 0;\r
+        final Boolean pf10mbFd = ((input) & (1<<1)) != 0;\r
+        final Boolean pf100mbHd = ((input) & (1<<2)) != 0;\r
+        final Boolean pf100mbFd = ((input) & (1<<3)) != 0;\r
+        final Boolean pf1gbHd = ((input) & (1<<4)) != 0;\r
+        final Boolean pf1gbFd = ((input) & (1<<5)) != 0;\r
+        final Boolean pf10gbFd = ((input) & (1<<6)) != 0;\r
+        final Boolean pfCopper = ((input) & (1<<7)) != 0;\r
+        final Boolean pfFiber = ((input) & (1<<8)) != 0;\r
+        final Boolean pfAutoneg = ((input) & (1<<9)) != 0;\r
+        final Boolean pfPause = ((input) & (1<<10)) != 0;\r
+        final Boolean pfPauseAsym = ((input) & (1<<11)) != 0;\r
+        return new PortFeaturesV10(pf100mbFd, pf100mbHd, pf10gbFd, pf10mbFd, pf10mbHd,\r
+                pf1gbFd, pf1gbHd, pfAutoneg, pfCopper, pfFiber, pfPause, pfPauseAsym);\r
     }\r
 }
\ No newline at end of file