Increased unit test coverage for keys

[openflowjava.git] / openflow-protocol-impl / src / test / java / org / opendaylight / openflowjava / protocol / impl / deserialization / MessageTypeCodeKeyTest.java

diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageTypeCodeKeyTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageTypeCodeKeyTest.java
index d63a792f37757593aede7c3bdf88a0af081a2482..337d3d36d839ced41eeb0cf0096e205e1c270075 100644 (file)
--- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageTypeCodeKeyTest.java
+++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageTypeCodeKeyTest.java
@@ -8,9 +8,9 @@
 
 package org.opendaylight.openflowjava.protocol.impl.deserialization;
 
+import org.junit.Assert;
 import org.junit.Test;
 
-import junit.framework.Assert;
 
 /**
  * 
@@ -19,37 +19,44 @@ import junit.framework.Assert;
  */
 public class MessageTypeCodeKeyTest {
 
+    /**
+     * Tests equals and hashCode
+     */
     @Test
-    public void testEquals(){
+    public void testEqualsAndHashcode(){
         short msgType1 = 12;
         short msgVersion1 = 34;
         short msgType2 = 21;
         short msgVersion2 = 43;
-        
         MessageTypeCodeKey key1 = new MessageTypeCodeKey(msgVersion1, msgType1);
-        
-        Assert.assertTrue("Wrong - equals to same obejct",key1.equals(key1));
-        Assert.assertFalse("Wrong - equals to null",key1.equals(null));
-        Assert.assertFalse("Wrong - equals to different class",key1.equals(new Object()));
-        
-        MessageTypeCodeKey key2 = new MessageTypeCodeKey(msgVersion2, msgType2);
-        Assert.assertFalse("Wrong - equals by msgType",key1.equals(key2));
-        
+
+        Assert.assertTrue("Wrong - equals to same object", key1.equals(key1));
+        Assert.assertFalse("Wrong - equals to null", key1.equals(null));
+        Assert.assertFalse("Wrong - equals to different class", key1.equals(new Object()));
+
+        MessageTypeCodeKey key2 = new MessageTypeCodeKey(msgVersion1, msgType1);
+        Assert.assertTrue("Wrong hashcode", key1.hashCode() == key2.hashCode());
+        Assert.assertTrue("Wrong - equals to mirror object", key1.equals(key2));
+
+        key2 = new MessageTypeCodeKey(msgVersion2, msgType2);
+        Assert.assertFalse("Wrong hashcode", key1.hashCode() == key2.hashCode());
+        Assert.assertFalse("Wrong - equals by msgType", key1.equals(key2));
+
         key2 = new MessageTypeCodeKey(msgVersion2, msgType1);
-        Assert.assertFalse("Wrong - equals by msgVersion",key1.equals(key2));
+        Assert.assertFalse("Wrong - equals by msgVersion", key1.equals(key2));
+        Assert.assertFalse("Wrong hashcode", key1.hashCode() == key2.hashCode());
     }
 
+    /**
+     * Tests getters
+     */
     @Test
     public void testGetter(){
-        
         short msgType = 12;
         short msgVersion = 34;
-
         MessageTypeCodeKey key1 = new MessageTypeCodeKey(msgVersion, msgType);
 
         Assert.assertEquals(msgType, key1.getMsgType());
         Assert.assertEquals(msgVersion, key1.getMsgVersion());
-
     }
-
-}
+}
\ No newline at end of file