Match and actions (de)serialization + fix

[openflowjava.git] / openflow-protocol-impl / src / test / java / org / opendaylight / openflowjava / protocol / impl / deserialization / factories / QueueGetConfigReplyMessageFactoryTest.java

diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java
index 01a7d025ac30b49f69af9ae657cae7a119b93fea..4c447fc3441430860b3effe02ffb696d08b5255f 100644 (file)
--- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java
+++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java
@@ -1,12 +1,11 @@
 /* Copyright (C)2013 Pantheon Technologies, s.r.o. All rights reserved. */\r
 package org.opendaylight.openflowjava.protocol.impl.deserialization.factories;\r
 \r
+import io.netty.buffer.ByteBuf;\r
+\r
 import java.util.ArrayList;\r
-import java.util.Comparator;\r
 import java.util.List;\r
 \r
-import io.netty.buffer.ByteBuf;\r
-\r
 import org.junit.Assert;\r
 import org.junit.Test;\r
 import org.opendaylight.openflowjava.protocol.impl.util.BufferHelper;\r
@@ -19,14 +18,15 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.queue.get.config.reply.Queues;\r
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.queue.get.config.reply.QueuesBuilder;\r
 \r
-import com.google.common.collect.ComparisonChain;\r
-\r
 /**\r
  * @author timotej.kubas\r
  * @author michal.polkorab\r
  */\r
 public class QueueGetConfigReplyMessageFactoryTest {\r
 \r
+    /**\r
+     * Testing {@link QueueGetConfigReplyMessageFactory} for correct translation into POJO\r
+     */\r
     @Test\r
     public void test(){\r
         ByteBuf bb = BufferHelper.buildBuffer("00 01 02 03 00 00 00 00 00 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 00 02 00 00 00 00 00 00");\r
@@ -36,8 +36,8 @@ public class QueueGetConfigReplyMessageFactoryTest {
         Assert.assertEquals("Wrong queues", builtByFactory.getQueues(), createQueuesList());\r
     }\r
     \r
-    public List<Queues> createQueuesList(){\r
-        List<Queues> queuesList = new ArrayList<Queues>();\r
+    private static List<Queues> createQueuesList(){\r
+        List<Queues> queuesList = new ArrayList<>();\r
         QueuesBuilder qb = new QueuesBuilder();\r
         qb.setQueueId(new QueueId(1L));\r
         qb.setPort(new PortNumber(1L));\r
@@ -47,8 +47,8 @@ public class QueueGetConfigReplyMessageFactoryTest {
         return queuesList;\r
     }\r
     \r
-    public List<Properties> createPropertiesList(){\r
-        List<Properties> propertiesList = new ArrayList<Properties>();\r
+    private static List<Properties> createPropertiesList(){\r
+        List<Properties> propertiesList = new ArrayList<>();\r
         PropertiesBuilder pb = new PropertiesBuilder();\r
         pb.setProperty(QueueProperty.values()[2]);\r
         propertiesList.add(pb.build());\r