Bug 2245 Fixed Avoid cycle between java packages

[openflowjava.git] / openflow-protocol-impl / src / test / java / org / opendaylight / openflowjava / protocol / impl / serialization / factories / GroupModInputMessageFactoryTest.java

diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
index eceb0d6630dd3a1356518527033aa8b80c7fc8c9..37396655a372426a6cdb3d42583c7cdddf0b5c34 100644 (file)
--- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
+++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
@@ -15,10 +15,14 @@ import java.util.ArrayList;
 import java.util.List;
 
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
-import org.opendaylight.openflowjava.protocol.impl.deserialization.factories.HelloMessageFactoryTest;
+import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
+import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
+import org.opendaylight.openflowjava.protocol.api.keys.MessageTypeKey;
+import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants;
+import org.opendaylight.openflowjava.protocol.impl.serialization.SerializerRegistryImpl;
 import org.opendaylight.openflowjava.protocol.impl.util.BufferHelper;
-import org.opendaylight.openflowjava.protocol.impl.util.EncodeConstants;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.GroupId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.GroupModCommand;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.GroupType;
@@ -33,8 +37,22 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
  *
  */
 public class GroupModInputMessageFactoryTest {
+    private static final byte MESSAGE_TYPE = 15;
     private static final byte PADDING_IN_GROUP_MOD_MESSAGE = 1;
-    
+    private SerializerRegistry registry;
+    private OFSerializer<GroupModInput> groupModFactory;
+
+    /**
+     * Initializes serializer registry and stores correct factory in field
+     */
+    @Before
+    public void startUp() {
+        registry = new SerializerRegistryImpl();
+        registry.init();
+        groupModFactory = registry.getSerializer(
+                new MessageTypeKey<>(EncodeConstants.OF13_VERSION_ID, GroupModInput.class));
+    }
+
     /**
      * @throws Exception
      * Testing of {@link GroupModInputMessageFactory} for correct translation from POJO
@@ -49,12 +67,11 @@ public class GroupModInputMessageFactoryTest {
         List<BucketsList> exp = createBucketsList();
         builder.setBucketsList(exp);
         GroupModInput message = builder.build();
-        
+
         ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer();
-        GroupModInputMessageFactory factory = GroupModInputMessageFactory.getInstance();
-        factory.messageToBuffer(HelloMessageFactoryTest.VERSION_YET_SUPPORTED, out, message);
-        
-        BufferHelper.checkHeaderV13(out, factory.getMessageType(), factory.computeLength(message));
+        groupModFactory.serialize(message, out);
+
+        BufferHelper.checkHeaderV13(out, MESSAGE_TYPE, 32);
         Assert.assertEquals("Wrong command", message.getCommand().getIntValue(), out.readUnsignedShort());
         Assert.assertEquals("Wrong type", message.getType().getIntValue(), out.readUnsignedByte());
         out.skipBytes(PADDING_IN_GROUP_MOD_MESSAGE);
@@ -62,7 +79,7 @@ public class GroupModInputMessageFactoryTest {
         List<BucketsList> rec = createBucketsListFromBufer(out);
         Assert.assertArrayEquals("Wrong bucketList", exp.toArray(), rec.toArray());
     }
-    
+
     private static List<BucketsList> createBucketsList(){
         List<BucketsList> bucketsList = new ArrayList<>();
         BucketsListBuilder bucketsBuilder = new BucketsListBuilder();
@@ -74,7 +91,7 @@ public class GroupModInputMessageFactoryTest {
         bucketsList.add(bucket);
         return bucketsList;
     }
-    
+
     private static List<BucketsList> createBucketsListFromBufer(ByteBuf out){
         List<BucketsList> bucketsList = new ArrayList<>();
         BucketsListBuilder bucketsBuilder = new BucketsListBuilder();
@@ -88,4 +105,28 @@ public class GroupModInputMessageFactoryTest {
         bucketsList.add(bucket);
         return bucketsList;
     }
-}
+
+    /**
+     * Testing of {@link GroupModInputMessageFactory} for correct translation from POJO
+     * @throws Exception
+     */
+    @Test
+    public void testGroupModInputWithNoBuckets() throws Exception {
+        GroupModInputBuilder builder = new GroupModInputBuilder();
+        BufferHelper.setupHeader(builder, EncodeConstants.OF13_VERSION_ID);
+        builder.setCommand(GroupModCommand.forValue(2));
+        builder.setType(GroupType.forValue(3));
+        builder.setGroupId(new GroupId(256L));
+        GroupModInput message = builder.build();
+
+        ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer();
+        groupModFactory.serialize(message, out);
+
+        BufferHelper.checkHeaderV13(out, MESSAGE_TYPE, 16);
+        Assert.assertEquals("Wrong command", message.getCommand().getIntValue(), out.readUnsignedShort());
+        Assert.assertEquals("Wrong type", message.getType().getIntValue(), out.readUnsignedByte());
+        out.skipBytes(PADDING_IN_GROUP_MOD_MESSAGE);
+        Assert.assertEquals("Wrong groupId", message.getGroupId().getValue().intValue(), out.readUnsignedInt());
+        Assert.assertTrue("Unexpected data", out.readableBytes() == 0);
+    }
+}
\ No newline at end of file