new serialization factories and tests

[openflowjava.git] / openflow-protocol-impl / src / test / java / org / opendaylight / openflowjava / protocol / impl / serialization / factories / GroupModInputMessageFactoryTest.java

diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
index 5379488264f5f678c1902e1e09e7f5e2471ba3e7..7f98d2cbe4f602b4ad12e667ebd9c964d0907501 100644 (file)
--- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
+++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/GroupModInputMessageFactoryTest.java
@@ -50,7 +50,7 @@ public class GroupModInputMessageFactoryTest {
         Assert.assertEquals("Wrong type", message.getType().getIntValue(), out.readByte());\r
         out.skipBytes(PADDING_IN_GROUP_MOD_MESSAGE);\r
         Assert.assertEquals("Wrong groupId", message.getGroupId().intValue(), out.readUnsignedInt());\r
-        Assert.assertEquals("Wrong bucketList", true, compareBucketsLists(createBucketsList(), createBucketsListFromBufer(out)));\r
+        Assert.assertEquals("Wrong bucketList", createBucketsList(), createBucketsListFromBufer(out));\r
     }\r
     \r
     private static List<Buckets> createBucketsList(){\r
@@ -77,34 +77,4 @@ public class GroupModInputMessageFactoryTest {
         bucketsList.add(bucket);\r
         return bucketsList;\r
     }\r
-    \r
-    private static boolean compareBucketsLists(List<Buckets> bucketsFromMessage, List<Buckets> bucketsFromBuffer) {\r
-        boolean result = false;\r
-        int bucketsFromMessageLength = bucketsFromMessage.size();\r
-        for (int i = 0; i < bucketsFromMessageLength; i++) {\r
-            if (bucketsFromMessage.get(i).getWeight().equals(bucketsFromBuffer.get(i).getWeight())) {\r
-                result = true;\r
-            } else {\r
-                result = false;\r
-                break;\r
-            }\r
-            if (bucketsFromMessage.get(i).getWatchPort()\r
-                    .equals(bucketsFromBuffer.get(i).getWatchPort())) {\r
-                result = true;\r
-            } else {\r
-                result = false;\r
-                break;\r
-            }\r
-            if (bucketsFromMessage.get(i).getWatchGroup()\r
-                    .equals(bucketsFromBuffer.get(i).getWatchGroup())) {\r
-                result = true;\r
-            } else {\r
-                result = false;\r
-                break;\r
-            }\r
-        }\r
-     // TODO get method for field length missing\r
-     // TODO actions structure missing\r
-        return result;\r
-    }\r
 }\r